💬 maflcko commented on pull request "msvc: Compile `test\fuzz\miniscript.cpp`":
(https://github.com/bitcoin/bitcoin/pull/30031#issuecomment-2094079027)
ACK 9155b733e153e799f09cc7f7e9199ad776b2cbb1

💬 maflcko commented on pull request "Testnet4 including PoW difficulty adjustment fix":
(https://github.com/bitcoin/bitcoin/pull/29775#issuecomment-2094081656)
> and `acceptnonstdtxn=1` as default is still a good solution

Not sure. `acceptnonstdtxn` is limited in what it allows. There are many non-standard examples that are not even exposed as a setting.

💬 maflcko commented on pull request "build: no-longer disable WARN_CXXFLAGS when CXXFLAGS is set":
(https://github.com/bitcoin/bitcoin/pull/25972#issuecomment-2094082588)
> Maybe into the CI or dev docs, given we'll never use -Werror by default for compilation?

Oh I see. `--enable-werror` is only set in the CI in this project. Seems fine to leave as-is.

💬 0xB10C commented on issue "Manually Banning Peers Results in Crash":
(https://github.com/bitcoin/bitcoin/issues/29916#issuecomment-2094082633)
Could this be a race between "clicking on the peer to ban it in the GUI" and "the peer disconnecting"?

💬 0xB10C commented on issue "Possible to Ban Clients by Name?":
(https://github.com/bitcoin/bitcoin/issues/30036#issuecomment-2094083082)
Looking at a few of my nodes, I haven't seen any `/Satoshi-BTC(Bitcoin Finance):0.15.1/` peers at all (yet?). Normally, user agents show up Additionally, I don't see any unusual amounts of outbound traffic on my nodes.

Do you know what they are sending to you? Can you post some of the IP addresses or the IP subnet they are connecting from? Do you think this could be targeted to your node? Does your node offer any special services e.g. `blockfilterindex=1 peerblockfilters=1 peerbloomfilters=1`
...

💬 hebasto commented on issue "Use sigstore software transparency for releases":
(https://github.com/bitcoin/bitcoin/issues/21524#issuecomment-2094083640)
> But I think as soon as it does go into production use, we should try to use it for our releases.

The time has come?

👍 TheCharlatan approved a pull request: "msvc: Compile `test\fuzz\miniscript.cpp`"
(https://github.com/bitcoin/bitcoin/pull/30031#pullrequestreview-2039302733)
ACK 9155b733e153e799f09cc7f7e9199ad776b2cbb1

💬 maflcko commented on issue "Use sigstore software transparency for releases":
(https://github.com/bitcoin/bitcoin/issues/21524#issuecomment-2094089674)
Does it offer any benefit over the existing workflow with guix attestations? See https://github.com/bitcoin-core/guix.sigs/

I presume every key and every attestation would have to be done twice and then uploaded to two different places? Or can sigstore just download and mirror the contents of the https://github.com/bitcoin-core/guix.sigs/ repo on its own?

✅ maflcko closed an issue: "Error when launching Bitcoin Core"
(https://github.com/bitcoin/bitcoin/issues/29995)

💬 maflcko commented on issue "Error when launching Bitcoin Core":
(https://github.com/bitcoin/bitcoin/issues/29995#issuecomment-2094090470)
Closing for now, but please leave a comment if you have more information indicating that this is a bug in the software, as opposed to a user error, or corrupt hardware.

💬 maflcko commented on pull request "ci: add markdown link check job":
(https://github.com/bitcoin/bitcoin/pull/30034#discussion_r1589940997)
Not sure. I think it would be good to instead run it in the existing lint task. Otherwise it can not be run locally. (See e.g. shellcheck)

Also, duplicating the exclude list in yet another place isn't ideal.

💬 maflcko commented on pull request "Remove redundant `-datacarrier` option":
(https://github.com/bitcoin/bitcoin/pull/29942#issuecomment-2094095382)
Are you still working on this?

📝 maciejsszmigiero opened a pull request: "dbwrapper: Bump LevelDB max file size to 128 MiB to avoid system slowdown from high disk cache flush rate"
(https://github.com/bitcoin/bitcoin/pull/30039)
The default max file size for LevelDB is 2 MiB, which results in the LevelDB compaction code generating ~4 disk cache flushes per second when syncing with the Bitcoin network.
These disk cache flushes are triggered by `fdatasync()` syscall issued by the LevelDB compaction code when reaching the max file size.

If the database is on a HDD this flush rate brings the whole system to a crawl.
It also results in very slow throughput since 2 MiB * 4 flushes per second is about 8 MiB / second max t
...

💬 emc99 commented on pull request "msvc: Compile `test\fuzz\miniscript.cpp`":
(https://github.com/bitcoin/bitcoin/pull/30031#issuecomment-2094127754)
There is no file at test/fuzz/miniscript

💬 hebasto commented on pull request "msvc: Compile `test\fuzz\miniscript.cpp`":
(https://github.com/bitcoin/bitcoin/pull/30031#issuecomment-2094128496)
> There is no file at test/fuzz/miniscript

```
$ file src/test/fuzz/miniscript.cpp
src/test/fuzz/miniscript.cpp: C++ source, ASCII text
```

💬 hebasto commented on pull request "Simplify network-adjusted time warning logic":
(https://github.com/bitcoin/bitcoin/pull/29623#issuecomment-2094140548)
Ported to the CMake-based build system in https://github.com/hebasto/bitcoin/pull/186.

💬 Sjors commented on pull request "Silent payment index (for light wallets and consistency check)":
(https://github.com/bitcoin/bitcoin/pull/28241#issuecomment-2094145823)
Took two days, but everything matches!

Best to run this script in a few parallel windows, because after block 790K or so it gets extremely slow.

```sh
./compare.sh 709632 790000
```

```sh
./compare.sh 790000 800000
```

etc

```sh
#!/bin/bash
# Taproot activation: 709632
set -e
TIP=`bitcoin-cli getblockcount`
for height in $(seq $1 $2); do
if [ $height -eq $TIP ]; then
echo "Reached the tip at $height"
exit 0
fi
if [ $((height % 1000)) -eq 0 ]; then

...

💬 hebasto commented on pull request "msvc: Compile `test\fuzz\miniscript.cpp`":
(https://github.com/bitcoin/bitcoin/pull/30031#issuecomment-2094192476)
Ported to the CMake-based build system in https://github.com/hebasto/bitcoin/pull/187.

💬 hebasto commented on pull request "build: no-longer disable WARN_CXXFLAGS when CXXFLAGS is set":
(https://github.com/bitcoin/bitcoin/pull/25972#issuecomment-2094203809)
Ported to the CMake-based build system in https://github.com/hebasto/bitcoin/pull/188.

💬 sipa commented on pull request "dbwrapper: Bump LevelDB max file size to 128 MiB to avoid system slowdown from high disk cache flush rate":
(https://github.com/bitcoin/bitcoin/pull/30039#issuecomment-2094216364)
@jamesob Feel like benchmarking a reindex or so with this?

💬 tdb3 commented on issue "RfC: increase minimum prune target?":
(https://github.com/bitcoin/bitcoin/issues/30037#issuecomment-2094223248)
It seems reasonable and safer to increase the min prune target, since blocks can be larger post-segwit (and we've seen it, e.g. 774628). Some rough napkin math for a new value (correct me if something looks off):
- 4MB per block, 288 blocks = 1152MB
- Add 15% for Undo data = 1325MB
- Add 20% for Orphan block rate = 1590MB
- Add one block file + added 15% undo data = 147MB
- Target >= 1737MB, so something like 1750MB seems at first glance that it could work

I would recommend we minimize
...