💬 willcl-ark commented on issue "Testsuite for Bitcoin Core 27.0.0 - FAIL: qt/test/test_bitcoin-qt":
(https://github.com/bitcoin/bitcoin/issues/30020#issuecomment-2090021621)
A few other thoughts:
1. Have you installed all the [GUI dependencies](https://github.com/bitcoin/bitcoin/blob/master/doc/build-unix.md#linux-distribution-specific-instructions)? (preumably you must have, and I see "Using QtTest library 5.15.8, Qt 5.15.8", but just thought I'd double check)
2. Does this happen if you configure with debug mode enabled: `./configure --enable-debug`? If so, the output may also be more useful to us to find what is failing rather than guessing from "No symbol tab
...
(https://github.com/bitcoin/bitcoin/issues/30020#issuecomment-2090021621)
A few other thoughts:
1. Have you installed all the [GUI dependencies](https://github.com/bitcoin/bitcoin/blob/master/doc/build-unix.md#linux-distribution-specific-instructions)? (preumably you must have, and I see "Using QtTest library 5.15.8, Qt 5.15.8", but just thought I'd double check)
2. Does this happen if you configure with debug mode enabled: `./configure --enable-debug`? If so, the output may also be more useful to us to find what is failing rather than guessing from "No symbol tab
...
💬 maflcko commented on issue "Bitcoin Core 27 crash at sync - Ubuntu - No error in logs":
(https://github.com/bitcoin/bitcoin/issues/30001#issuecomment-2090032624)
I mean it doesn't contain the crash information. Are you sure this is a crash and not a normal shutdown or someone initiating a shutdown?
In any case, if this really is a crash, you can get the traceback with something like:
```
gdb --args .../bitcoin-qt
...
> run
```
Then recreate the crash and check the output in the terminal.
(https://github.com/bitcoin/bitcoin/issues/30001#issuecomment-2090032624)
I mean it doesn't contain the crash information. Are you sure this is a crash and not a normal shutdown or someone initiating a shutdown?
In any case, if this really is a crash, you can get the traceback with something like:
```
gdb --args .../bitcoin-qt
...
> run
```
Then recreate the crash and check the output in the terminal.
💬 ajtowns commented on pull request "Improve new LogDebug/Trace/Info/Warning/Error Macros":
(https://github.com/bitcoin/bitcoin/pull/29256#issuecomment-2090083022)
> To reiterate my own point of view, `-logsourcelocation` does not solve the same problem this PR solves because it does not
That ignores bullets (1), (2) and (5) from your OP (as it stands today).
It also ignores comments like [vasild's](https://github.com/bitcoin/bitcoin/pull/29256#pullrequestreview-1884614153), [jamesob's](https://github.com/bitcoin/bitcoin/pull/28318#discussion_r1445429093), [luke-jr's](https://github.com/bitcoin/bitcoin/pull/24464#pullrequestreview-902452600), [jonata
...
(https://github.com/bitcoin/bitcoin/pull/29256#issuecomment-2090083022)
> To reiterate my own point of view, `-logsourcelocation` does not solve the same problem this PR solves because it does not
That ignores bullets (1), (2) and (5) from your OP (as it stands today).
It also ignores comments like [vasild's](https://github.com/bitcoin/bitcoin/pull/29256#pullrequestreview-1884614153), [jamesob's](https://github.com/bitcoin/bitcoin/pull/28318#discussion_r1445429093), [luke-jr's](https://github.com/bitcoin/bitcoin/pull/24464#pullrequestreview-902452600), [jonata
...
💬 Sjors commented on issue "Change estimate_mode default to "ECONOMICAL" in these RPC calls":
(https://github.com/bitcoin/bitcoin/issues/30009#issuecomment-2090106386)
Are you sure this isn't already happening?
This code suggests it does, but I haven't tested:
https://github.com/bitcoin/bitcoin/blob/9d1a286f20b8a602ffe72928bcd79be09fdbf9d0/src/wallet/fees.cpp#L52-L53
cc @achow101
(https://github.com/bitcoin/bitcoin/issues/30009#issuecomment-2090106386)
Are you sure this isn't already happening?
This code suggests it does, but I haven't tested:
https://github.com/bitcoin/bitcoin/blob/9d1a286f20b8a602ffe72928bcd79be09fdbf9d0/src/wallet/fees.cpp#L52-L53
cc @achow101
🤔 hebasto reviewed a pull request: "Fix misleading signmessage error with segwit"
(https://github.com/bitcoin-core/gui/pull/819#pullrequestreview-2035359966)
Approach ACK 83def1c5a3741878aa63e6f28cc3def99f76c358 on the content of the messages.
However, splitting lines makes translation work harder due to providing less context. Could you make every touched message a single translatable string?
Also, if you'd like, add translation comment will be very useful to avoid any potential issue similar to [ (for example, https://github.com/bitcoin/bitcoin/commit/](https://github.com/bitcoin/bitcoin/issues/29979).
(https://github.com/bitcoin-core/gui/pull/819#pullrequestreview-2035359966)
Approach ACK 83def1c5a3741878aa63e6f28cc3def99f76c358 on the content of the messages.
However, splitting lines makes translation work harder due to providing less context. Could you make every touched message a single translatable string?
Also, if you'd like, add translation comment will be very useful to avoid any potential issue similar to [ (for example, https://github.com/bitcoin/bitcoin/commit/](https://github.com/bitcoin/bitcoin/issues/29979).
🤔 hebasto reviewed a pull request: "Fix misleading signmessage error with segwit"
(https://github.com/bitcoin-core/gui/pull/819#pullrequestreview-2035365546)
And "Bitcoin Core" phrase should be replaced with `PACKAGE_NAME` (see https://github.com/bitcoin/bitcoin/pull/18646, https://github.com/bitcoin/bitcoin/pull/19282 etc).
(https://github.com/bitcoin-core/gui/pull/819#pullrequestreview-2035365546)
And "Bitcoin Core" phrase should be replaced with `PACKAGE_NAME` (see https://github.com/bitcoin/bitcoin/pull/18646, https://github.com/bitcoin/bitcoin/pull/19282 etc).
💬 paplorinc commented on pull request "test: create assert_less_than util":
(https://github.com/bitcoin/bitcoin/pull/30019#discussion_r1587398443)
This looks worse now
(https://github.com/bitcoin/bitcoin/pull/30019#discussion_r1587398443)
This looks worse now
💬 paplorinc commented on pull request "test: create assert_less_than util":
(https://github.com/bitcoin/bitcoin/pull/30019#discussion_r1587399692)
why so general, the previous one was a simple operator, why obfuscate it as such?
(https://github.com/bitcoin/bitcoin/pull/30019#discussion_r1587399692)
why so general, the previous one was a simple operator, why obfuscate it as such?
🤔 paplorinc reviewed a pull request: "test: create assert_less_than util"
(https://github.com/bitcoin/bitcoin/pull/30019#pullrequestreview-2035362348)
I'm not sure I understand what's wrong with the original operators, this seems less readable to me
(https://github.com/bitcoin/bitcoin/pull/30019#pullrequestreview-2035362348)
I'm not sure I understand what's wrong with the original operators, this seems less readable to me
💬 virtu commented on pull request "chainparams: Add achow101 DNS seeder":
(https://github.com/bitcoin/bitcoin/pull/30007#issuecomment-2090115678)
> @virtu FYI, would it be easily possible to run some of the metrics of https://21.ninja/dns-seeds/ for this new seeder?
@mzumsande, the seed is now being monitored on [dev.21.ninja](dev.21.ninja/dns-seeds/).
There may be some graph artifacts until a second data point becomes available. But so far data looks good: 40 advertised addresses (half of them ipv4, the other ipv6), and 35 of them reachable.
(https://github.com/bitcoin/bitcoin/pull/30007#issuecomment-2090115678)
> @virtu FYI, would it be easily possible to run some of the metrics of https://21.ninja/dns-seeds/ for this new seeder?
@mzumsande, the seed is now being monitored on [dev.21.ninja](dev.21.ninja/dns-seeds/).
There may be some graph artifacts until a second data point becomes available. But so far data looks good: 40 advertised addresses (half of them ipv4, the other ipv6), and 35 of them reachable.
💬 glozow commented on pull request "opportunistic 1p1c followups":
(https://github.com/bitcoin/bitcoin/pull/30012#issuecomment-2090123427)
> Can this also address:
Added. I made a copy instead of reference because it's a pointer.
(https://github.com/bitcoin/bitcoin/pull/30012#issuecomment-2090123427)
> Can this also address:
Added. I made a copy instead of reference because it's a pointer.
🤔 glozow reviewed a pull request: "test: create assert_less_than util"
(https://github.com/bitcoin/bitcoin/pull/30019#pullrequestreview-2035382457)
Why not just use `assert_greater_than_or_equal`?
(https://github.com/bitcoin/bitcoin/pull/30019#pullrequestreview-2035382457)
Why not just use `assert_greater_than_or_equal`?
💬 paplorinc commented on pull request "refactor, fuzz: Make 64-bit shift explicit":
(https://github.com/bitcoin/bitcoin/pull/30017#discussion_r1587407613)
was the `1U` deliberately kept here?
(https://github.com/bitcoin/bitcoin/pull/30017#discussion_r1587407613)
was the `1U` deliberately kept here?
💬 maflcko commented on pull request "refactor: Avoid unused-variable warning in init.cpp":
(https://github.com/bitcoin/bitcoin/pull/29968#issuecomment-2090190099)
> Avoids the worry about future compilers, and (void)blah which isn't explanatory
I think `(void)blah;` is well understood to mean this (to both code readers and compilers), but `[[maybe_unused]]` seems fine as well. Switched to that.
(https://github.com/bitcoin/bitcoin/pull/29968#issuecomment-2090190099)
> Avoids the worry about future compilers, and (void)blah which isn't explanatory
I think `(void)blah;` is well understood to mean this (to both code readers and compilers), but `[[maybe_unused]]` seems fine as well. Switched to that.
📝 Cryptocurrencei opened a pull request: "Rename CONTRIBUTING.md to CONTRIBUTING.cryptocurrency.md"
(https://github.com/bitcoin/bitcoin/pull/30021)
<!--
*** Please remove the following help text before submitting: ***
Pull requests without a rationale and clear improvement may be closed
immediately.
GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->
<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:
* Any test improvements or new tests that improv
...
(https://github.com/bitcoin/bitcoin/pull/30021)
<!--
*** Please remove the following help text before submitting: ***
Pull requests without a rationale and clear improvement may be closed
immediately.
GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->
<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:
* Any test improvements or new tests that improv
...
💬 glozow commented on pull request "p2p: index TxOrphanage by wtxid, allow entries with same txid":
(https://github.com/bitcoin/bitcoin/pull/30000#discussion_r1587460520)
> It's not immediately obvious to me why it is safe to just convert any gtxid into a Wtxid here
The argument I'm making in this PR is that in all the places we are checking by txid, we shouldn't be doing that, because we're missing same-txid-different-witness cases. But yeah totally fair to say it's difficult to review it together, so I'll split the first commit to make it more explicit where the change is happening and why that's ok.
> I think it could be a better approach to update Alre
...
(https://github.com/bitcoin/bitcoin/pull/30000#discussion_r1587460520)
> It's not immediately obvious to me why it is safe to just convert any gtxid into a Wtxid here
The argument I'm making in this PR is that in all the places we are checking by txid, we shouldn't be doing that, because we're missing same-txid-different-witness cases. But yeah totally fair to say it's difficult to review it together, so I'll split the first commit to make it more explicit where the change is happening and why that's ok.
> I think it could be a better approach to update Alre
...
💬 dominicusadinfinitum commented on issue "Testsuite for Bitcoin Core 27.0.0 - FAIL: qt/test/test_bitcoin-qt":
(https://github.com/bitcoin/bitcoin/issues/30020#issuecomment-2090241517)
> A few other thoughts:
>
> 1. Have you installed all the [GUI dependencies](https://github.com/bitcoin/bitcoin/blob/master/doc/build-unix.md#linux-distribution-specific-instructions)? (preumably you must have, and I see "Using QtTest library 5.15.8, Qt 5.15.8", but just thought I'd double check)
> 2. Does this happen if you configure with debug mode enabled: `./configure --enable-debug`? If so, the output may also be more useful to us to find what is failing rather than guessing from "No sy
...
(https://github.com/bitcoin/bitcoin/issues/30020#issuecomment-2090241517)
> A few other thoughts:
>
> 1. Have you installed all the [GUI dependencies](https://github.com/bitcoin/bitcoin/blob/master/doc/build-unix.md#linux-distribution-specific-instructions)? (preumably you must have, and I see "Using QtTest library 5.15.8, Qt 5.15.8", but just thought I'd double check)
> 2. Does this happen if you configure with debug mode enabled: `./configure --enable-debug`? If so, the output may also be more useful to us to find what is failing rather than guessing from "No sy
...
✅ fanquake closed a pull request: "Rename CONTRIBUTING.md to CONTRIBUTING.cryptocurrency.md"
(https://github.com/bitcoin/bitcoin/pull/30021)
(https://github.com/bitcoin/bitcoin/pull/30021)
📝 fanquake locked a pull request: "Rename CONTRIBUTING.md to CONTRIBUTING.cryptocurrency.md"
(https://github.com/bitcoin/bitcoin/pull/30021)
<!--
*** Please remove the following help text before submitting: ***
Pull requests without a rationale and clear improvement may be closed
immediately.
GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->
<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:
* Any test improvements or new tests that improv
...
(https://github.com/bitcoin/bitcoin/pull/30021)
<!--
*** Please remove the following help text before submitting: ***
Pull requests without a rationale and clear improvement may be closed
immediately.
GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->
<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:
* Any test improvements or new tests that improv
...
💬 dominicusadinfinitum commented on issue "Testsuite for Bitcoin Core 27.0.0 - FAIL: qt/test/test_bitcoin-qt":
(https://github.com/bitcoin/bitcoin/issues/30020#issuecomment-2090247040)
> @dominicusadinfinitum
>
> What are the first few lines (before "Script verification uses...") in the `debug.log` file when you run `bitcoin-qt -regtest`?
I'm new to this. Trying to figure out how to do that. Keep you updated.
(https://github.com/bitcoin/bitcoin/issues/30020#issuecomment-2090247040)
> @dominicusadinfinitum
>
> What are the first few lines (before "Script verification uses...") in the `debug.log` file when you run `bitcoin-qt -regtest`?
I'm new to this. Trying to figure out how to do that. Keep you updated.
💬 dominicusadinfinitum commented on issue "Testsuite for Bitcoin Core 27.0.0 - FAIL: qt/test/test_bitcoin-qt":
(https://github.com/bitcoin/bitcoin/issues/30020#issuecomment-2090271815)
> > A few other thoughts:
> >
> > 1. Have you installed all the [GUI dependencies](https://github.com/bitcoin/bitcoin/blob/master/doc/build-unix.md#linux-distribution-specific-instructions)? (preumably you must have, and I see "Using QtTest library 5.15.8, Qt 5.15.8", but just thought I'd double check)
> > 2. Does this happen if you configure with debug mode enabled: `./configure --enable-debug`? If so, the output may also be more useful to us to find what is failing rather than guessing fro
...
(https://github.com/bitcoin/bitcoin/issues/30020#issuecomment-2090271815)
> > A few other thoughts:
> >
> > 1. Have you installed all the [GUI dependencies](https://github.com/bitcoin/bitcoin/blob/master/doc/build-unix.md#linux-distribution-specific-instructions)? (preumably you must have, and I see "Using QtTest library 5.15.8, Qt 5.15.8", but just thought I'd double check)
> > 2. Does this happen if you configure with debug mode enabled: `./configure --enable-debug`? If so, the output may also be more useful to us to find what is failing rather than guessing fro
...