💬 maflcko commented on pull request "ci: use Clang 16 for Valgrind":
(https://github.com/bitcoin/bitcoin/pull/29848#discussion_r1563849606)
```suggestion
export TEST_RUNNER_EXTRA="--exclude rpc_bind,feature_bind_extra" # Excluded for now, see https://github.com/bitcoin/bitcoin/issues/17765#issuecomment-602068547
```

unrelated, but this was fixed a while ago

💬 maflcko commented on pull request "feefrac: avoid explicitly computing diagram; compare based on chunks":
(https://github.com/bitcoin/bitcoin/pull/29757#issuecomment-2053567442)
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=68020#c1

👍 rkrux approved a pull request: "tests: add functional test for miniscript decaying multisig"
(https://github.com/bitcoin/bitcoin/pull/29156#pullrequestreview-1999196598)
tACK [5023b47](https://github.com/bitcoin/bitcoin/pull/29156/commits/5023b47e85161a0b35839ce03c7b5d55ff1cd4c1)

Build and all functional tests successful. I like the clarity and the expressiveness with which this test has been written, and believe this is a good addition. Thanks for coming up with this @mjdietzx!

Suggested adding a log message in the last portion of the test.

💬 rkrux commented on pull request "tests: add functional test for miniscript decaying multisig":
(https://github.com/bitcoin/bitcoin/pull/29156#discussion_r1563887374)
Most of the code before this one is very similar to `wallet_multisig_descriptor_psbt.py` test - `participants_create_multisigs` is different though.
As pointed out in other reviews as well, I feel this test can go in the same file and some commonalities can be extracted, but I don't think this is blocking though.

💬 rkrux commented on pull request "tests: add functional test for miniscript decaying multisig":
(https://github.com/bitcoin/bitcoin/pull/29156#discussion_r1563885340)
```
2024-04-13T08:31:05.463000Z TestFramework (INFO): At block height >= 128 this multisig is 3-of-4
2024-04-13T08:31:05.473000Z TestFramework (INFO): Check that the time-locked transaction is too immature to spend...
2024-04-13T08:31:05.614000Z TestFramework (INFO): Check that balances are correct after the transaction has been included in a block.
```

The first time I ran this test, I felt there should be another log message in between that displays something like "Generating ABC blocks
...

💬 rkrux commented on pull request "tests: add functional test for miniscript decaying multisig":
(https://github.com/bitcoin/bitcoin/pull/29156#discussion_r1563886096)
> then wallet would not process that psbt as complete with 3 valid signatures like I expected

Do you mean the 4-signature transaction was rejected?

✅ maflcko closed a pull request: "Update unix build instructions."
(https://github.com/bitcoin/bitcoin/pull/29864)

💬 maflcko commented on pull request "Update unix build instructions.":
(https://github.com/bitcoin/bitcoin/pull/29864#issuecomment-2053591846)
You will have to check out the documentation of the commit you are trying to compile.

For example, if you want to compile 27.x, you will have to use https://github.com/bitcoin/bitcoin/blob/27.x/doc/build-unix.md , not the one of master.

💬 maflcko commented on pull request "Update unix build instructions.":
(https://github.com/bitcoin/bitcoin/pull/29864#discussion_r1563908042)
This hasn't been needed for a long time. You are likely using the wrong docs to compile the wrong commit?

📝 theStack opened a pull request: "util: remove unused cpp-subprocess options"
(https://github.com/bitcoin/bitcoin/pull/29865)
The newly introduced cpp-subprocess library provides a good number of options for the `Popen` class:
https://github.com/bitcoin/bitcoin/blob/0de63b8b46eff5cda85b4950062703324ba65a80/src/util/subprocess.hpp#L1009-L1020
Some of them are either not fully implemented (`shell`, missing an implementation on Windows), implemented in an ugly way (e.g. using "Impoverished, meager, needy, truly needy version of type erasure" for `preexec_func` according to the author's own words) or simply unlikely to b
...

💬 TheCharlatan commented on pull request "util: remove unused cpp-subprocess options":
(https://github.com/bitcoin/bitcoin/pull/29865#issuecomment-2053611230)
Nice, Concept ACK.

💬 sipa commented on pull request "validation: don't clear cache on periodic flush: >2x block connection speed":
(https://github.com/bitcoin/bitcoin/pull/28233#issuecomment-2053629582)
utACK 4a6d1d1e3bc3d559cd13d134b4b827f22635ac4b

⚠️ fumisama opened an issue: "RUNE "
(https://github.com/bitcoin/bitcoin/issues/29866)
### Please describe the feature you'd like to see added.

I am a newbie but I am not very good at setting up RUNE nodes. Is there any adjective that a novice can understand? I want to learn to set up RUNE full nodes. Thank you.

### Is your feature related to a problem, if so please describe it.

_No response_

### Describe the solution you'd like

_No response_

### Describe any alternatives you've considered

_No response_

### Please leave any additional context

_No response_

✅ fanquake closed an issue: "RUNE "
(https://github.com/bitcoin/bitcoin/issues/29866)

:lock: fanquake locked an issue: "RUNE "
(https://github.com/bitcoin/bitcoin/issues/29866)

🤔 tdb3 reviewed a pull request: "test: Handle functional test disk-full error"
(https://github.com/bitcoin/bitcoin/pull/29335#pullrequestreview-1999297020)
re-ACK for 858fa78637041ae704005d4b6e564dd8245f4b5d

Thanks for incorporating the suggestion.

Used a small ramdisk (1.2GB) with high jobs count (20) to force space exhaustion. As expected, received the initial warning `Running the test suite with fewer than 3026.0 MB of free space might cause tests to fail`. and also received the exiting error `Early exiting after test failure due to disk running out of space...Test execution data left in ...Additional storage is needed to execute testing`
...

📝 furszy opened a pull request: "index: race fix, lock cs_main while 'm_synced' is subject to change"
(https://github.com/bitcoin/bitcoin/pull/29867)
Fixes #29831. Thanks to Marko for the detailed description of the issue.

The race occurs because a block could be connected and its event signaled in-between reading the 'next block' and setting 'm_synced' during the index initial synchronization process.
To address this issue, the `m_synced` set has been moved under the `cs_main` guard. This ensures that new block events are not signaled while the index sync state is being determined.

💬 davidgumberg commented on pull request "test: Handle functional test disk-full error":
(https://github.com/bitcoin/bitcoin/pull/29335#issuecomment-2053718293)
reACK https://github.com/bitcoin/bitcoin/pull/29335/commits/858fa78637041ae704005d4b6e564dd8245f4b5d

Looks great, tested on a tmpfs 1 GiB in size, and the test runner prints the intended warning, and fails immediately when the disk is full.

💬 hebasto commented on pull request "util: remove unused cpp-subprocess options":
(https://github.com/bitcoin/bitcoin/pull/29865#issuecomment-2053737139)
Concept ACK.

💬 hebasto commented on pull request "util: remove unused cpp-subprocess options":
(https://github.com/bitcoin/bitcoin/pull/29865#issuecomment-2053738677)
> remove unused cpp-subprocess options

Are all remaining options used?

🤔 vostrnad reviewed a pull request: "[27.x] More backports and finalize"
(https://github.com/bitcoin/bitcoin/pull/29780#pullrequestreview-1999340097)
Reviewed the release notes. A few style nits/suggestions, one entry is missing its PR number.