💬 hebasto commented on pull request "guix: replace GCC unaligned VMOV patch with binutils patch":
(https://github.com/bitcoin/bitcoin/pull/29846#issuecomment-2048425728)
Concept ACK.

💬 paplorinc commented on pull request "refactor: Simplify base32/64 padding calculations":
(https://github.com/bitcoin/bitcoin/pull/29847#issuecomment-2048485814)
@maflcko, you were right, the changes didn't add enough value, I've reverted them.
I've kept the tests, since I think they're valuable and unified the style between base 32 and 64 in the source. If you think that's still too much, I'll revert it.

💬 niftynei commented on pull request "RPC: add new `listmempooltransactions`":
(https://github.com/bitcoin/bitcoin/pull/29016#issuecomment-2048493284)
Yes but won't have any progress to show til May or so. Thanks

👋 paplorinc's pull request is ready for review: "refactor/test: add a few more base32/64 calculation corner cases"
(https://github.com/bitcoin/bitcoin/pull/29847)

💬 hebasto commented on pull request "guix: replace GCC unaligned VMOV patch with binutils patch":
(https://github.com/bitcoin/bitcoin/pull/29846#issuecomment-2049000540)
My Guix builds:
```
x86_64
07f97e7479e5a7e1baae091ed74839e9b7be118d0504a8b334c4add8e13c78cc guix-build-a0dc2ebcda9e/output/aarch64-linux-gnu/SHA256SUMS.part
ee4ab82a42c802dfa1e455e6badb6a49e819c77f03fcaf3568656faa5f69dce4 guix-build-a0dc2ebcda9e/output/aarch64-linux-gnu/bitcoin-a0dc2ebcda9e-aarch64-linux-gnu-debug.tar.gz
f405a168ea3aa2b3a230664381babb406b03680404ebb89e1638f07efa872520 guix-build-a0dc2ebcda9e/output/aarch64-linux-gnu/bitcoin-a0dc2ebcda9e-aarch64-linux-gnu.tar.gz
98c203bb
...

💬 laanwj commented on pull request "guix: replace GCC unaligned VMOV patch with binutils patch":
(https://github.com/bitcoin/bitcoin/pull/29846#discussion_r1560502458)
i think i'm missing something: if this is a build flag, is a patch really needed? Or is this more of a defense-in-depth approach to prevent accidentally forgetting it.

💬 laanwj commented on pull request "guix: replace GCC unaligned VMOV patch with binutils patch":
(https://github.com/bitcoin/bitcoin/pull/29846#issuecomment-2049044482)
Concept ACK, will test

💬 laanwj commented on pull request "i2p: fix and improve logs":
(https://github.com/bitcoin/bitcoin/pull/29833#discussion_r1560532624)
maybe "Accept was interrupted"

📝 fanquake converted_to_draft a pull request: "RPC: add new `listmempooltransactions`"
(https://github.com/bitcoin/bitcoin/pull/29016)
## Proposed Update

Add a new RPC endpoint, `listmempooltransactions`. Takes as args a `start_sequence` and `verbose`.

Returns:
- if verbose false, list of txids + their `entry_sequence` where each entry's `entry_sequence` >= the provided `start_sequence.
- if verbose true, raw tx output info including each entry's `entry_sequence`.


Builds on work done in #19572.

## Rationale
The current mempool RPCs are lacking an ability to scan for updates in a more efficient manner. You can
...

💬 maflcko commented on pull request "build: Enable fuzz binary in MSVC":
(https://github.com/bitcoin/bitcoin/pull/29774#discussion_r1560540110)
I still fail to understand it. Can you explain what it means and why passing the env fixes it? Is there an error message on stderr or stdout as well?

💬 fanquake commented on pull request "guix: replace GCC unaligned VMOV patch with binutils patch":
(https://github.com/bitcoin/bitcoin/pull/29846#discussion_r1560542032)
It's so we build the whole world / toolchain / depends etc with this option.

💬 hebasto commented on pull request "build: Enable fuzz binary in MSVC":
(https://github.com/bitcoin/bitcoin/pull/29774#discussion_r1560558840)
On Windows, when `subprocess` sets environment variables, it effectively overrides all of them, which makes `PATH` and `COMSPEC` environment variable empty on the master branch.

💬 maflcko commented on pull request "build: Enable fuzz binary in MSVC":
(https://github.com/bitcoin/bitcoin/pull/29774#discussion_r1560562920)
Is it not the same on Linux?

💬 hebasto commented on pull request "build: Enable fuzz binary in MSVC":
(https://github.com/bitcoin/bitcoin/pull/29774#discussion_r1560567478)
Linux does not need the `COMSPEC` environment variable to spawn a new process, right?

💬 maflcko commented on pull request "build: Enable fuzz binary in MSVC":
(https://github.com/bitcoin/bitcoin/pull/29774#discussion_r1560573673)
Ok, then maybe mention that this is needed for `COMSPEC` in the commit message?

📝 fanquake opened a pull request: "ci: use Clang 16 for Valgrind"
(https://github.com/bitcoin/bitcoin/pull/29848)
Switch to Ubuntu Noble.
Valgrind 3.19 -> 3.22
Clang 14 -> Clang 16

👍 theStack approved a pull request: "AcceptMultipleTransactions: Fix workspace not being set as client_maxfeerate failure"
(https://github.com/bitcoin/bitcoin/pull/29735#pullrequestreview-1993588649)
ACK 4ba1d0b55339c3ea90e2bcd64662a06f0f90dd46

💬 dergoegge commented on pull request "feefrac: avoid explicitly computing diagram; compare based on chunks":
(https://github.com/bitcoin/bitcoin/pull/29757#issuecomment-2049209648)
`package_rbf` crash (base64): [rbf-2369c110673171b822af54ba3f33aabab58e7aeb.crash.txt](https://github.com/bitcoin/bitcoin/files/14943549/rbf-2369c110673171b822af54ba3f33aabab58e7aeb.crash.txt)

`util/feefrac.cpp:44 CompareChunks: Assertion slope_ap.size > 0 failed.`

💬 maflcko commented on pull request "depends: add new LLVM debug macro":
(https://github.com/bitcoin/bitcoin/pull/29781#issuecomment-2049211637)
post-merge NACK. Can you add exact steps to reproduce the debug mode works as expected?

💬 dergoegge commented on pull request "feefrac: avoid explicitly computing diagram; compare based on chunks":
(https://github.com/bitcoin/bitcoin/pull/29757#issuecomment-2049220195)
UBSan `package_rbf` crash (base64):
[rbf-ubsan-fac11eca92adf89df0e6840e5faa58873144d98a.crash.txt](https://github.com/bitcoin/bitcoin/files/14943698/rbf-ubsan-fac11eca92adf89df0e6840e5faa58873144d98a.crash.txt)


```
INFO: Running with entropic power schedule (0xFF, 100).
INFO: Seed: 3880912967
INFO: Loaded 1 modules (756212 inline 8-bit counters): 756212 [0xaaaadcf1c108, 0xaaaadcfd4afc),
INFO: Loaded 1 PC tables (756212 PCs): 756212 [0xaaaadcfd4b00,0xaaaaddb5ea40),
/workdir/fuzz_bin
...

💬 maflcko commented on pull request "ci: use Clang 16 for Valgrind":
(https://github.com/bitcoin/bitcoin/pull/29848#issuecomment-2049230133)
lgtm ACK 9996fba412f2d6d0e899906e8b3c387ef9d199d3

Didn't test