💬 laanwj commented on pull request "security: restrict abis in bitcoind.service":
(https://github.com/bitcoin/bitcoin/pull/28340#issuecomment-2045362990)
ACK 0244416aacbad03e4ebe8f2c95c7861a318916ea . This is a sensible security feature.
It looks like [the documentation](https://www.freedesktop.org/software/systemd/man/latest/systemd.exec.html) of systemd.exec even mentions this pairing.

I do agree with @sjors, however, that when we're adding systemd hardening options, we might as well look further.

✅ achow101 closed a pull request: "Fix issues in ZMQ error handling"
(https://github.com/bitcoin/bitcoin/pull/28029)

💬 achow101 commented on pull request "Fix issues in ZMQ error handling":
(https://github.com/bitcoin/bitcoin/pull/28029#issuecomment-2045368032)
The PR didn't seem to attract much attention in the past. Also, the issue seems not important enough right now to keep it sitting around idle in the list of open PRs.

Closing due to lack of interest.

💬 theStack commented on pull request "test: p2p: add test for rejected tx request logic (`m_recent_rejects` filter)":
(https://github.com/bitcoin/bitcoin/pull/29827#discussion_r1557776951)
Got rid of the "got inv" `assert_debug_log`s, the mempool reject reason is now checked with `testmempoolaccept`.

✅ achow101 closed a pull request: "wallet: Fix wallet directory initialization"
(https://github.com/bitcoin/bitcoin/pull/28514)

💬 achow101 commented on pull request "wallet: Fix wallet directory initialization":
(https://github.com/bitcoin/bitcoin/pull/28514#issuecomment-2045374108)
The PR didn't seem to attract much attention in the past. Also, the issue seems not important enough right now to keep it sitting around idle in the list of open PRs.

Closing due to lack of interest.

✅ achow101 closed an issue: "odd behaviour of GetDataDir creating wallets/ subdirectory"
(https://github.com/bitcoin/bitcoin/issues/16220)

💬 achow101 commented on issue "odd behaviour of GetDataDir creating wallets/ subdirectory":
(https://github.com/bitcoin/bitcoin/issues/16220#issuecomment-2045376507)
The feature request didn't seem to attract much attention in the past. Also, the issue seems not important enough right now to keep it sitting around idle in the list of open issues.

Closing due to lack of interest. Pull requests with improvements are always welcome.

💬 darosior commented on issue "odd behaviour of GetDataDir creating wallets/ subdirectory":
(https://github.com/bitcoin/bitcoin/issues/16220#issuecomment-2045376833)
Is it just that it creates a "wallets" folder even without wallets? If so it doesn't seem important.

💬 laanwj commented on pull request "Introduce 'getblockfileinfo' RPC command":
(https://github.com/bitcoin/bitcoin/pull/27770#issuecomment-2045379103)
I think this information is too low-level. In the past we've rejected changes that expose low-level information about our block storage because block files are not an external API, and exposing this kind of info limits our flexibility in regard to changing the block storage model.

I agree that it can be useful to have more transparency into pruning, however, but I'm not sure adding a RPC giving information per file is the best approach.

💬 achow101 commented on pull request "Add ASM optimizations for MuHash3072":
(https://github.com/bitcoin/bitcoin/pull/19181#issuecomment-2045383736)
> One possibility is just taking the asm generated by clang 14 and including that as asm blocks in the C++ code?

Seems like we should do that.

✅ achow101 closed a pull request: "Add ASM optimizations for MuHash3072"
(https://github.com/bitcoin/bitcoin/pull/19181)

💬 achow101 commented on pull request "Add ASM optimizations for MuHash3072":
(https://github.com/bitcoin/bitcoin/pull/19181#issuecomment-2045388051)
Closing as up for grabs due to lack of activity.

💬 maflcko commented on pull request "Wallet: Functions to enable adding used balance to GUI overview page":
(https://github.com/bitcoin/bitcoin/pull/28776#discussion_r1557805199)
Interface functions that are newly introduced or are only called by the GUI can be handled in the GUI repo. Closing for now, this can be moved into the GUI pull.

✅ maflcko closed a pull request: "Wallet: Functions to enable adding used balance to GUI overview page"
(https://github.com/bitcoin/bitcoin/pull/28776)

📝 fanquake opened a pull request: "ci: disable `_FORTIFY_SOURCE` with MSAN"
(https://github.com/bitcoin/bitcoin/pull/29837)
By undefining `_FORTIFY_SOURCE` we can drop`--disable-hardening`.

💬 achow101 commented on pull request "Implement BIP 370 PSBTv2":
(https://github.com/bitcoin/bitcoin/pull/21283#issuecomment-2045401277)
Will split this up

💬 theStack commented on pull request "test: p2p: add test for rejected tx request logic (`m_recent_rejects` filter)":
(https://github.com/bitcoin/bitcoin/pull/29827#issuecomment-2045403274)
This PR is based on https://github.com/bitcoin/bitcoin/pull/29735 now in order to take use of the `fill_mempool` (see https://github.com/bitcoin/bitcoin/pull/29827#discussion_r1555420823). Note that I had issues with this helper due to `tx_to_be_evicted` not being evicted (failed assertion `assert tx_to_be_evicted_id not in node.getrawmempool()`), as the mempool filling txs spent that newly created coin again; fixed by the first commit.

💬 ismaelsadeeq commented on issue "Wallet: Nondescript error message for 502nd unconfirmed transaction":
(https://github.com/bitcoin/bitcoin/issues/29711#issuecomment-2045403310)
Currently, if you have more than 500 independent unconfirmed transactions, the wallet prevent users from creating a transaction with an unconfirmed input to prevent some DOS vector.

The limit is set by the `CTxMempool::GatherClusters` method, which was added with the introduction of the mini miner and package-aware funding to prevent the calculation of clusters containing 500 or more unconfirmed transactions in #27021.


I’ve bisected, and this issue does not occur on ab42b2ebdbf61225e636e
...

💬 laanwj commented on pull request "Add ASM optimizations for MuHash3072":
(https://github.com/bitcoin/bitcoin/pull/19181#issuecomment-2045406134)
> One possibility is just taking the asm generated by clang 14 and including that as asm blocks in the C++ code?

In general i really dislike the idea of copy/pasting assembly output from a compiler into the source code. It's already hard enough to review human-generated asm code but at least you can ask the author about the reasoning how and why. In the case of compiler output, well, it'd be a matter of waiting for gcc to improve :slightly_smiling_face:

💬 darosior commented on pull request "test: verify spend from 999-of-999 taproot multisig wallet":
(https://github.com/bitcoin/bitcoin/pull/28212#issuecomment-2045410857)
This has not seen any activity for a while. It's depending on https://github.com/bitcoin/bitcoin/issues/29098#issuecomment-1860221553, which i unfortunately do not plan on implementing right now. If you do i'm happy to review, but in the meantime i think this PR can be closed and potentially re-opened once the performance of the satisfier is reasonable.