💬 instagibbs commented on pull request "feefrac: avoid explicitly computing diagram; compare based on chunks":
(https://github.com/bitcoin/bitcoin/pull/29757#issuecomment-2039001407)
ACK https://github.com/bitcoin/bitcoin/pull/29757/commits/c2fdcf42e9c4ca0157115e465cca298df70fc700

💬 instagibbs commented on pull request "AcceptMultipleTransactions: Fix workspace not being set as client_maxfeerate failure":
(https://github.com/bitcoin/bitcoin/pull/29735#discussion_r1552969962)
that's the error string as it's reported unfortunately!

💬 instagibbs commented on pull request "AcceptMultipleTransactions: Fix workspace not being set as client_maxfeerate failure":
(https://github.com/bitcoin/bitcoin/pull/29735#discussion_r1552985927)
done

💬 instagibbs commented on pull request "AcceptMultipleTransactions: Fix workspace not being set as client_maxfeerate failure":
(https://github.com/bitcoin/bitcoin/pull/29735#discussion_r1552985990)
no but this is even better, taken

💬 instagibbs commented on pull request "AcceptMultipleTransactions: Fix workspace not being set as client_maxfeerate failure":
(https://github.com/bitcoin/bitcoin/pull/29735#discussion_r1552986070)
I don't want to blow away extra_args the caller may want, so took the comment suggestion for now

💬 instagibbs commented on pull request "AcceptMultipleTransactions: Fix workspace not being set as client_maxfeerate failure":
(https://github.com/bitcoin/bitcoin/pull/29735#discussion_r1552986113)
split out the moving and docstring changes, should be minimal now?

✅ fanquake closed an issue: "H"
(https://github.com/bitcoin/bitcoin/issues/29812)

:lock: fanquake locked an issue: "H"
(https://github.com/bitcoin/bitcoin/issues/29812)

💬 maflcko commented on pull request "util/system: Close non-std fds when execing slave processes":
(https://github.com/bitcoin/bitcoin/pull/22417#issuecomment-2039148601)
Are you still working on this? There has been no reply to a review comment for about a year: https://github.com/bitcoin/bitcoin/pull/22417#discussion_r1253372361

💬 maflcko commented on pull request "Fix waste calculation in SelectionResult":
(https://github.com/bitcoin/bitcoin/pull/28366#issuecomment-2039175023)
Are you still working on this?

💬 Sjors commented on pull request "net_processing: make any misbehavior trigger immediate discouragement":
(https://github.com/bitcoin/bitcoin/pull/29575#issuecomment-2039194761)
It's been two weeks and I don't see a single `MISBEHAVE` log entry.

💬 Sjors commented on pull request "rpc: Optimize serialization disk space of dumptxoutset - Reloaded":
(https://github.com/bitcoin/bitcoin/pull/29612#issuecomment-2039223974)
I like magic bytes. For PSBT it's just "psbt" in ascii followed by 0xff: https://en.bitcoin.it/wiki/BIP_0174

So you could use "utxo" in ascii: 0x75 0x74 0x78 0x6F 0xFF

But then while you're at it, you could also append:
* ChainTypeToString ("main", "testnet", "signet", "regtest")
* height (so we can have an error like "you tried to load a snapshot at height X, but only heights Y, Z are supported by this version of PACKAGE_NAME. Newer releases may support more recent snapshots.")
* for s
...

💬 Sjors commented on pull request "Change Luke Dashjr seed to dashjr-list-of-p2p-nodes.us":
(https://github.com/bitcoin/bitcoin/pull/29691#issuecomment-2039240747)
@luke-jr can you GPG sign this commit?

Someone, possibly you, should also make a PR to update it here: https://github.com/bitcoin-core/bitcoin-maintainer-tools/blob/main/check-dnsseeds.py (better still if it just parses `src/kernel/chainparams.cpp`).

I ran the above script locally and it's happy.

💬 Sjors commented on issue "MuSig2 support":
(https://github.com/bitcoin/bitcoin/issues/23326#issuecomment-2039308803)
WIP in #29675!

📝 brunoerg opened a pull request: "doc: i2p: improve `-i2pacceptincoming` mention"
(https://github.com/bitcoin/bitcoin/pull/29813)
In i2p documentation, it says that "the first time Bitcoin Core connects to the I2P router,
it automatically generates a persistent I2P address and its corresponding private key by
default **or if `-i2pacceptincoming=1` is set**". This is weird, because `-i2pacceptincoming=1`
by itself does not have any effect. Moreover, `-i2pacceptincoming` is 1 by default anyway.

💬 brunoerg commented on pull request "doc: i2p: improve `-i2pacceptincoming` mention":
(https://github.com/bitcoin/bitcoin/pull/29813#issuecomment-2039311131)
cc: @vasild

✅ Sjors closed an issue: "Add taproot descriptor to existing descriptor wallet"
(https://github.com/bitcoin/bitcoin/issues/24193)

💬 Sjors commented on issue "Add taproot descriptor to existing descriptor wallet":
(https://github.com/bitcoin/bitcoin/issues/24193#issuecomment-2039314544)
The future is here!

💬 fanquake commented on pull request "depends: swap some cctools tools for LLVM tools":
(https://github.com/bitcoin/bitcoin/pull/29739#issuecomment-2039370588)
> I did run into a confusing, but unrelated (happens on https://github.com/bitcoin/bitcoin/commit/28f2ca675f89a764e1ec8eb5671b35357b8677f3 too, see https://github.com/bitcoin/bitcoin/issues/29792), failure with bdb,

Yes that is unrelated.

> CI seems unhappy for macOS cross:

Fixed up.

💬 maflcko commented on issue "depens: bdb build fails on Intel macOS 13.6.6 ":
(https://github.com/bitcoin/bitcoin/issues/29792#issuecomment-2039443040)
What is your `patch --version`?

💬 Sjors commented on issue "depens: bdb build fails on Intel macOS 13.6.6 ":
(https://github.com/bitcoin/bitcoin/issues/29792#issuecomment-2039482595)
patch 2.0-12u11-Apple