💬 vasild commented on pull request "Broadcast own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/29415#discussion_r1551600727)
Done

💬 vasild commented on pull request "Broadcast own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/29415#discussion_r1551600883)
Done

💬 vasild commented on pull request "Broadcast own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/29415#discussion_r1551601200)
Done

💬 vasild commented on pull request "Broadcast own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/29415#issuecomment-2037088808)
`390e628a07...9297437af2`: rebase and address suggestions

> Do we need test coverage for retrying stale txs and having multiple concurrent txs queued for private broadcast?

Yes.

🤔 furszy reviewed a pull request: "Wallet: Add `max_tx_weight` to transaction funding options (take 2)"
(https://github.com/bitcoin/bitcoin/pull/29523#pullrequestreview-1979773330)
Any chance to turn the first commit into an scripted-diff?

💬 vostrnad commented on issue "IBD performance regression in 27.0rc1 on Windows":
(https://github.com/bitcoin/bitcoin/issues/29785#issuecomment-2037129737)
Ran the original benchmark again (pre-built binaries on Windows) with only these configuration options:

- `-connect`
- `-datadir`
- `-port`
- `-rpcport`
- `-rpcuser`
- `-rpcpassword`

This time 27.0rc1 was about 5% slower on average than 26.0, still with a much higher variance. Measured around 250 runs of each.

26.0:

27.0rc1:
![ibd27rc1noconfig](https://github.com/bitcoin/b
...

📝 fjahr opened a pull request: "test: Fix debug recommendation in argsman_tests"
(https://github.com/bitcoin/bitcoin/pull/29805)
There are recommendations in the `argsman_tests` comments on how to re-run and debug a test failure to see if it reflects an expected or unexpected change. The command tries to run a test in `util_tests` but this is in `argsman_tests` so the command doesn't work with just copy+paste. I didn't investigate further but I suspect that these tests were moved between files.

💬 furszy commented on pull request "Don't permit port in proxy IP option":
(https://github.com/bitcoin-core/gui/pull/813#discussion_r1551654604)
What about using `SplitHostPort()` from `#include <util/strencodings.h>` instead?
Would only need to verify that the port isn't set.

💬 willcl-ark commented on pull request "Don't permit port in proxy IP option":
(https://github.com/bitcoin-core/gui/pull/813#discussion_r1551664405)
That certainly looks like it could be what is needed here!

✅ ryanofsky closed an issue: "ThreadSanitizer: data race src/flatfile.cpp:47:13 in FlatFileSeq::Open(FlatFilePos const&, bool)"
(https://github.com/bitcoin/bitcoin/issues/29767)

🚀 ryanofsky merged a pull request: "ThreadSanitizer: Fix #29767"
(https://github.com/bitcoin/bitcoin/pull/29776)

✅ maflcko closed an issue: "test: failure in feature_coinstatsindex.py "
(https://github.com/bitcoin/bitcoin/issues/29746)

💬 maflcko commented on issue "test: failure in feature_coinstatsindex.py ":
(https://github.com/bitcoin/bitcoin/issues/29746#issuecomment-2037230147)
Closing for now, but this can be reopened if it happens again.

💬 ryanofsky commented on pull request "ThreadSanitizer: Fix #29767":
(https://github.com/bitcoin/bitcoin/pull/29776#issuecomment-2037233316)
Merged this since it is a small straightfoward fix, only affects indexing, has 2 acks (ryanofsky, fjahr) and positive comments from other reviewers (mzumsande, sjors, furszy)

💬 fanquake commented on pull request "test: Fix debug recommendation in argsman_tests":
(https://github.com/bitcoin/bitcoin/pull/29805#issuecomment-2037245111)
cc @ryanofsky

💬 sipa commented on pull request "refactor: Remove gmtime*":
(https://github.com/bitcoin/bitcoin/pull/29081#issuecomment-2037251004)
utACK fa9f36babaceba6ab2f88e64bc4bc2956f58871f

💬 mzumsande commented on pull request "Simplify network-adjusted time warning logic":
(https://github.com/bitcoin/bitcoin/pull/29623#discussion_r1551733252)
This isn't changed behavior, but with the threshold reduced to 10 minutes it may be a bit more relevant now:
As far as I understand it, for GUI users `ThreadSafeMessageBox()` blocks the calling thread (here `msghand`) until the user has clicked away the warning:
That means that for as long as the user didn't click anything (e.g. because they are afk), most activity stops: No more received messages are processed, the tip is no longer updated etc. The current peers will disconnect us soon (beca
...

💬 Willtech commented on issue "Signmessage doesn't work with segwit addresses":
(https://github.com/bitcoin/bitcoin/issues/10542#issuecomment-2037289362)
Also, [signmessage works in V0.18.1](https://twitter.com/CA_22562_AN/status/1775884518995747193)

https://bitcoincore.org/bin/bitcoin-core-0.18.1/

Professor. Damian A. James Williamson
Wills

⚠️ maflcko opened an issue: "intermittent issue in wallet_backwards_compatibility.py: line 245, in run_test assert txs[3]["abandoned"] AssertionError"
(https://github.com/bitcoin/bitcoin/issues/29806)
https://cirrus-ci.com/task/5524545770094592?logs=ci#L3290

💬 Eunovo commented on pull request "Wallet: Add `max_tx_weight` to transaction funding options (take 2)":
(https://github.com/bitcoin/bitcoin/pull/29523#issuecomment-2037477967)
Tested ACK https://github.com/bitcoin/bitcoin/pull/29523/commits/3a64b3a339fe55c2642369b00a382231871c283

💬 pablomartin4btc commented on pull request "Don't permit port in proxy IP option":
(https://github.com/bitcoin-core/gui/pull/813#issuecomment-2037524282)
> I'm not convinced that a large regex is "simpler" than checking if a ":" is in the string?

The large one was for the port number, the one I referred as "simpler" was for the IP address: `QRegularExpression ipRegex("^([0-9]{1,3}\\.){3}[0-9]{1,3}$");`. What I meant is that we know in advance that the ":" would be invalid so we could restrict the user to even enter it. As current we could see this (not only ":"):

![image](https://github.com/bitcoin-core/gui/assets/110166421/139224e2-aa0d-44
...