💬 nostitos commented on pull request "Remove -mempoolfullrbf option":
(https://github.com/bitcoin/bitcoin/pull/26525#issuecomment-1473050580)
> I'm certainly not inclined to spend $0.60 in fees for an on-chain transaction to pay a $15 phone top-up on Bitrefill.

Not sure where that's getting at but my typical "refill" is for 500$ cards.

💬 ariard commented on pull request "Remove -mempoolfullrbf option":
(https://github.com/bitcoin/bitcoin/pull/26525#issuecomment-1473067644)
> Just reviving this. Four months have passed. What are the current stats on people flagging mempoolfullrbf=1?
>
> My guess is that literally only the hostile devs in this thread run it, and whichever miners they managed to persuade personally, and that there is no significant signal of support or usage of the feature in the wild, or am I wrong?
>
> It would be nice for the remaining thousands of users and merchants to not have to look over our shoulder and wonder if Core will sneak it on
...

💬 ajtowns commented on pull request "Ignore datacarrier limits for dataless OP_RETURN outputs":
(https://github.com/bitcoin/bitcoin/pull/27261#issuecomment-1473155403)
NACK. If someone wants to allow a bare OP_RETURN and nothing more they can set `-datacarriersize=1`. There's no reason to ignore someone setting `-nodatacarrier` to indicate they don't want OP_RETURN outputs in their mempool.

💬 0xB10C commented on pull request "mempool: Add mempool tracepoints":
(https://github.com/bitcoin/bitcoin/pull/26531#discussion_r1139897157)
Not necessarily. Might be redundant. When a transaction is added and you pass the tracepoint arguments _directly_ to a tracing script (can't think of a reason why you would want to store it in a BPF map first for a while), then the time is very close to `now()`. Similar for rejected transactions and for the replacement transaction during RBF (the time when the replaced transaction entered is passed).

📝 Bushstar opened a pull request: "refactor: remove unused param from legacy pubkey interface"
(https://github.com/bitcoin/bitcoin/pull/27274)
Unused param present in legacy pubkey manager interface. This param will not be used and should be removed to prevent unintended usage.

📝 Bushstar opened a pull request: "build: ignore common editor files"
(https://github.com/bitcoin/bitcoin/pull/27275)
Add IntelliJ and Visual Studio Code editor files to .gitignore. Small QOL change :)

💬 fanquake commented on pull request "build: ignore common editor files":
(https://github.com/bitcoin/bitcoin/pull/27275#issuecomment-1473387105)
NACK. Feel free to add to your local (global) .gitignore.

💬 Bushstar commented on pull request "build: ignore common editor files":
(https://github.com/bitcoin/bitcoin/pull/27275#issuecomment-1473392538)
If so should the Qt Creator entry be removed or leave it as this project uses Qt?

💬 MarcoFalke commented on pull request "test: Make the unlikely race in p2p_invalid_messages impossible":
(https://github.com/bitcoin/bitcoin/pull/27212#issuecomment-1473414979)
Thanks! Removed `?` and comment completely.

💬 AdarshRawat1 commented on issue "When opening or autoloading wallets there should be clear messages about rescanning in progress and wallets' names.":
(https://github.com/bitcoin-core/gui/issues/259#issuecomment-1473479240)
can I work on this issue?

💬 willcl-ark commented on pull request "build: ignore common editor files":
(https://github.com/bitcoin/bitcoin/pull/27275#issuecomment-1473485508)
@Bushstar I add project specific things to `.git/info/exclude` inside the project. But perhaps more helpful for you if you are using an IDE like that is if you add a global gitignore and reference it in your git config:

```
[core]
excludesfile = /path/to/your/gitignore_global
```

Then you'll never be bothered by it again yourself.

💬 fanquake commented on pull request "build: ignore common editor files":
(https://github.com/bitcoin/bitcoin/pull/27275#issuecomment-1473507800)
> If so should the Qt Creator entry be removed or leave it as this project uses Qt?

Can probably just leave things as-is. At some point we had instructions for using Qt Creator.

✅ fanquake closed a pull request: "build: ignore common editor files"
(https://github.com/bitcoin/bitcoin/pull/27275)

💬 Bushstar commented on pull request "build: ignore common editor files":
(https://github.com/bitcoin/bitcoin/pull/27275#issuecomment-1473512419)
@willcl-ark top tips. I now have a global .gitignore file.

💬 fanquake commented on pull request "system: allow GUI to initialize default data dir":
(https://github.com/bitcoin/bitcoin/pull/27273#issuecomment-1473520297)
https://github.com/bitcoin/bitcoin/pull/27273/checks?check_run_id=12065322378
```bash
********* Start testing of OptionTests *********
Config: Using QtTest library 5.15.5, Qt 5.15.5 (x86_64-little_endian-lp64 static release build; by Clang 8.0.1 (tags/RELEASE_801/final)), debian 10
PASS : OptionTests::initTestCase()
PASS : OptionTests::migrateSettings()
PASS : OptionTests::integerGetArgBug()
PASS : OptionTests::parametersInteraction()
PASS : OptionTests::extractFilter()
QWARN
...

💬 willcl-ark commented on pull request "test: Support decoding segwit address in address_to_scriptpubkey()":
(https://github.com/bitcoin/bitcoin/pull/27269#issuecomment-1473539401)
Concept ACK

Thanks for working on this. Increasing the address to scriptpubkey decoding tests to include bech32 seems desirable. I think this would mean that we could remove the `todo` on [L427](https://github.com/bitcoin/bitcoin/pull/27269/commits/4b95be0c496947606aaa661507ca06d53cc358c5#diff-7932a60a9127fd22d10d367526fd7b987f9647ce017595f8b1af5c32d5db0083R427) of wallet.py too?

The way the equivalent base58 function `test_base58encodedecode()` is implemented is slightly different from th
...

💬 vasild commented on pull request "p2p: cleanup `LookupIntern`, `Lookup` and `LookupHost`":
(https://github.com/bitcoin/bitcoin/pull/26261#discussion_r1140013676)
Now it is:

```cpp
const std::optional<CNetAddr> addr{LookupHost(i->first, false)};
if (i->first.empty() && addr.has_value() && addr->IsBindAny()) {
LogPrintf("WARNING: the RPC server is not safe to expose to untrusted networks such as the public internet\n");
```

If the string (`i->first`) is empty then `addr.has_value()` will never be true. Thus this condition will never be true and the warning will never be printed. It should be:

```cpp
if (i->first.empty() || (add.has_value(
...

💬 vasild commented on pull request "p2p: set `-dnsseed` and `-listen` false if `maxconnections=0`":
(https://github.com/bitcoin/bitcoin/pull/26899#issuecomment-1473586166)
ACK fabb95e7bf02f3d8e663a02dd845d42e09d330ec

💬 glozow commented on pull request "Remove -mempoolfullrbf option":
(https://github.com/bitcoin/bitcoin/pull/26525#issuecomment-1473587233)
Philosophical arguments about full RBF aside, this PR proposes deleting an option that is (1) used by a significant amount of nodes and (2) does no harm to the node operator. It would be inappropriate to simply take such an option out from underneath users/downstream software without very strong rationale and a proper deprecation cycle.

💬 Daniel600 commented on pull request "Remove -mempoolfullrbf option":
(https://github.com/bitcoin/bitcoin/pull/26525#issuecomment-1473607546)
GAP600 stats update - GAP600 enables 0-conf acceptance
- circa 500k unique BTC Trx hashes in Jan 2023
- circa 460k unique BTC Trx hashes in Feb 2023

There is still a significant use case for 0-conf acceptance - primarily by payment processors (servicing industries like gaming) and non-custodial liquidity providers serving non-custodial wallets. GAP600 has not seen as of yet an impact of FULLRBF on activity and risk.

FullRBF approach is a significant change to the behavior of the protoc
...

💬 brunoerg commented on pull request "p2p: cleanup `LookupIntern`, `Lookup` and `LookupHost`":
(https://github.com/bitcoin/bitcoin/pull/26261#discussion_r1140043673)
Fixed it, thanks!