✅ mjdietzx closed an issue: "Build error on macOS, tag v26.0 builds fine"
(https://github.com/bitcoin/bitcoin/issues/29289)

💬 mjdietzx commented on issue "Build error on macOS, tag v26.0 builds fine":
(https://github.com/bitcoin/bitcoin/issues/29289#issuecomment-1906734501)
> Which version of clang are you using?

```
Apple clang version 13.0.0 (clang-1300.0.29.30)
Target: x86_64-apple-darwin21.1.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
```

I tried building master @ f1ab078ed7742c3350438f0315846948cf317e67 on my newer MacBook Pro. Builds properly with no errors. Where clang version is:
```
Apple clang version 14.0.0 (clang-1400.0.29.202)
Target: arm64-apple-darwin22.1.0

...

💬 murchandamus commented on pull request "Mempool util: Add RBF diagram checks for single chunks against clusters of size 2":
(https://github.com/bitcoin/bitcoin/pull/29242#discussion_r1463859645)
Yeah, that would improve it

🤔 murchandamus reviewed a pull request: "Mempool util: Add RBF diagram checks for single chunks against clusters of size 2"
(https://github.com/bitcoin/bitcoin/pull/29242#pullrequestreview-1839716607)
ACK a14b95129d3a2894b7a41ce919a426bb60f62e35

Note: I am fairly familiar with the concept of feerate diagram checks, but not particularly familiar with the mempool code.

💬 murchandamus commented on pull request "Mempool util: Add RBF diagram checks for single chunks against clusters of size 2":
(https://github.com/bitcoin/bitcoin/pull/29242#discussion_r1463863198)
```suggestion
* having a conflicting input with a proposed transaction
```

💬 murchandamus commented on pull request "Mempool util: Add RBF diagram checks for single chunks against clusters of size 2":
(https://github.com/bitcoin/bitcoin/pull/29242#discussion_r1463866212)
If all diagrams always start with `FeeFrac{0, 0}`, why do we need to mention that as a first element?

💬 achow101 commented on pull request "wallet: fix coin selection tracing to return -1 when no change pos":
(https://github.com/bitcoin/bitcoin/pull/29272#issuecomment-1906770454)
ACK d55fdb1a495190e213b1b5127f5d91e4a409765e

🚀 achow101 merged a pull request: "wallet: fix coin selection tracing to return -1 when no change pos"
(https://github.com/bitcoin/bitcoin/pull/29272)

💬 achow101 commented on pull request "wallet: avoid returning a reference to vMasterKey after releasing the mutex that guards it":
(https://github.com/bitcoin/bitcoin/pull/28774#issuecomment-1906815615)
ACK 32a9f13cb805ecf6aebb5cf4e5d92b8a47c4548b

🚀 achow101 merged a pull request: "wallet: avoid returning a reference to vMasterKey after releasing the mutex that guards it"
(https://github.com/bitcoin/bitcoin/pull/28774)

💬 achow101 commented on pull request "init: handle empty settings file gracefully":
(https://github.com/bitcoin/bitcoin/pull/29144#issuecomment-1906838728)
ACK e9014042a6bed8c16cc9a31fc35cb709d4b3c766

💬 ryanofsky commented on pull request "ci: Rename tasks (previous releases, macOS cross)":
(https://github.com/bitcoin/bitcoin/pull/29218#issuecomment-1906839971)
> a new label can be added, if a dedicated "category" is needed

I think this would be great. Ideally there would just be some link you could go to quickly see recent known CI failures and what the expected error messages look like.

This could avoid the need to debug and search for fragments of error messages when CI tasks are failing. I think a filtered issue list would work just as well as a wiki page (but I might experiment with creating a wiki page anyway since I'm about to go through m
...

💬 instagibbs commented on pull request "Add max_tx_weight to transaction funding options":
(https://github.com/bitcoin/bitcoin/pull/29264#discussion_r1463935963)
hmmm, this change to give a useful error message seems to break tests; I start getting failures in rpc_psbt.py

Can I get some assistance on how this stuff is supposed to bubble up @murchandamus

🚀 achow101 merged a pull request: "init: handle empty settings file gracefully"
(https://github.com/bitcoin/bitcoin/pull/29144)

🤔 furszy reviewed a pull request: "init: handle empty settings file gracefully"
(https://github.com/bitcoin/bitcoin/pull/29144#pullrequestreview-1839845550)
> Should we perhaps add (and recommend, for non-GUI users), a `-resetguisettings` for non-GUI?

Sure. We could introduce a `-resetsettings` in a follow-up.

💬 murchandamus commented on pull request "Add max_tx_weight to transaction funding options":
(https://github.com/bitcoin/bitcoin/pull/29264#discussion_r1463942824)
As above

💬 murchandamus commented on pull request "Add max_tx_weight to transaction funding options":
(https://github.com/bitcoin/bitcoin/pull/29264#discussion_r1463942221)
I think you meant either "Transaction building" or "Coin selection" here:

```suggestion
"Transaction building will fail if this can not be satisfied."},
```

```suggestion
"Coin selection will fail if this can not be satisfied."},
```

💬 murchandamus commented on pull request "Add max_tx_weight to transaction funding options":
(https://github.com/bitcoin/bitcoin/pull/29264#discussion_r1463954606)
My first thought would be that we are perhaps not counting the empty witness stack of a non-witness input? :thinking:

💬 murchandamus commented on pull request "Add max_tx_weight to transaction funding options":
(https://github.com/bitcoin/bitcoin/pull/29264#discussion_r1463944668)
As above

💬 murchandamus commented on pull request "Add max_tx_weight to transaction funding options":
(https://github.com/bitcoin/bitcoin/pull/29264#discussion_r1463947916)
If you do, please also add an `assert` that checks whether the fuzzed value is greater than or equal to the result’s weight.

💬 murchandamus commented on pull request "Add max_tx_weight to transaction funding options":
(https://github.com/bitcoin/bitcoin/pull/29264#discussion_r1463943149)
As above