💬 fanquake commented on pull request "logging: accept "none" as argument for rpc logging":
(https://github.com/bitcoin/bitcoin/pull/27263#issuecomment-1470313674)
See also #27231.

💬 pinheadmz commented on pull request "logging: accept "none" as argument for rpc logging":
(https://github.com/bitcoin/bitcoin/pull/27263#issuecomment-1470314719)
word! sorry, will track #27231 and review when its ready

✅ pinheadmz closed a pull request: "logging: accept "none" as argument for rpc logging"
(https://github.com/bitcoin/bitcoin/pull/27263)

📝 stratospher opened a pull request: "p2p: Improve diversification of new connections"
(https://github.com/bitcoin/bitcoin/pull/27264)
Revives #19860.

In order to make sure that our persistent outbound slots belong to different netgroups, distinct net groups of our peers are added to [`setConnected`](https://github.com/bitcoin/bitcoin/blob/8c4958bd4c06026dc108bc7f5f063d1f389d279b/src/net.cpp#L1716). We’d only open a persistent outbound connection to peers which have a different netgroup compared to those netgroups present in `setConnected`.

**behaviour on master**

we open persistent outbound connections to peers which
...

💬 MarcoFalke commented on pull request "refactor / kernel: Move non-gArgs chainparams functionality to kernel":
(https://github.com/bitcoin/bitcoin/pull/26177#discussion_r1137365115)
Thx, can be marked resolved

💬 MarcoFalke commented on pull request "refactor / kernel: Move non-gArgs chainparams functionality to kernel":
(https://github.com/bitcoin/bitcoin/pull/26177#discussion_r1137365304)
Thx, can be marked resolved

💬 MarcoFalke commented on pull request "refactor / kernel: Move non-gArgs chainparams functionality to kernel":
(https://github.com/bitcoin/bitcoin/pull/26177#discussion_r1137367474)


Thx, can be marked resolved

💬 MarcoFalke commented on pull request "refactor / kernel: Move non-gArgs chainparams functionality to kernel":
(https://github.com/bitcoin/bitcoin/pull/26177#discussion_r1137367980)


Thx, can be marked resolved

💬 MarcoFalke commented on pull request "refactor / kernel: Move non-gArgs chainparams functionality to kernel":
(https://github.com/bitcoin/bitcoin/pull/26177#discussion_r1137367822)


Thx, can be marked resolved

💬 MarcoFalke commented on pull request "refactor / kernel: Move non-gArgs chainparams functionality to kernel":
(https://github.com/bitcoin/bitcoin/pull/26177#discussion_r1137368863)


Thx, can be marked resolved

💬 MarcoFalke commented on pull request "refactor / kernel: Move non-gArgs chainparams functionality to kernel":
(https://github.com/bitcoin/bitcoin/pull/26177#discussion_r1137369578)


Thx, can be marked resolved

💬 MarcoFalke commented on pull request "refactor / kernel: Move non-gArgs chainparams functionality to kernel":
(https://github.com/bitcoin/bitcoin/pull/26177#discussion_r1137369716)


Thx, can be marked resolved

💬 MarcoFalke commented on pull request "refactor / kernel: Move non-gArgs chainparams functionality to kernel":
(https://github.com/bitcoin/bitcoin/pull/26177#discussion_r1137370113)


Thx, can be marked resolved

💬 stratospher commented on pull request "p2p: Improve diversification of new connections":
(https://github.com/bitcoin/bitcoin/pull/19860#issuecomment-1470325525)
revived this in #27264.

💬 MarcoFalke commented on pull request "refactor / kernel: Move non-gArgs chainparams functionality to kernel":
(https://github.com/bitcoin/bitcoin/pull/26177#issuecomment-1470327165)
re-ACK b3e78dc91d01e364b77aacd9fb9a2f88688ab8a6 🛁

<details><summary>Show signature</summary>

Signature:

```
untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}"
RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A3Yux4bpwZNLvVBKy0wLgM=
trusted comment: re-ACK b3e78dc91d01e364b77a
...

💬 achow101 commented on pull request "util: improve FindByte() performance":
(https://github.com/bitcoin/bitcoin/pull/19690#issuecomment-1470331104)
ACK dacd3316ca0279c56d12372957633b73a999b5b2

💬 TheCharlatan commented on pull request "Remove almost all blockstorage globals":
(https://github.com/bitcoin/bitcoin/pull/25781#discussion_r1137383018)
Right on, can be marked as resolved.

💬 desirepl commented on issue "Bitcoin ignores datadir and blocksdir parameter in .conf":
(https://github.com/bitcoin/bitcoin/issues/27246#issuecomment-1470344927)
@ryanofsky "Various ways this could be handled"
Let's think about situation:
1) we have external dir/disk with blocks only (blk* and rev* for now are stick together :|)
2) we have datadir with indexes/chainstate and other files currently belongs to datadir (peers/mempool etc) at another second/disk
3) we have configuration files at third dir/disk
4) we have logdir for everything at fourth dir/disk

It's a good solution to divide them all.
Now we do some magic - place bitcoin.conf at defa
...

💬 achow101 commented on pull request "p2p: set `-dnsseed` and `-listen` false if `maxconnections=0`":
(https://github.com/bitcoin/bitcoin/pull/26899#issuecomment-1470364821)
ACK fabb95e7bf02f3d8e663a02dd845d42e09d330ec

💬 willcl-ark commented on issue "RFC: Replacing Boost Process":
(https://github.com/bitcoin/bitcoin/issues/24907#issuecomment-1470373138)
@theStack Just tested on MacOS 13.1 (without BDB and QT) and all functional and unit tests passed ✅

👍 vasild approved a pull request: "p2p: Improve diversification of new connections"
(https://github.com/bitcoin/bitcoin/pull/27264)
ACK 72e8ffd7f8dbf908e65da6d012ede914596737ab

IMO the last commit from #19860 can also be brought up: `doc: peer selection rules do not apply to MANUAL and ADDR_FETCH`