💬 jonatack commented on pull request "doc: update -loglevel help following merge of PR 28318":
(https://github.com/bitcoin/bitcoin/pull/29230#discussion_r1449116831)
Thanks! On current master, I think `warning` and `error` are already excluded.

```
$ ./src/bitcoind -regtest -help-debug | grep -A12 loglevel=
-loglevel=<level>|<category>:<level>
Set the global or per-category severity level for logging categories
enabled with the -debug configuration option or the logging RPC:
info, debug, trace (default=debug); warning and error levels are
always logged. If <category>:<level> is supplied, the setting
will overrid
...

👍 fanquake approved a pull request: "ci: Rename tasks (previous releases, macOS cross)"
(https://github.com/bitcoin/bitcoin/pull/29218#pullrequestreview-1816017963)
ACK fa0c594b33970e12d97e6879ab4ca57045453492

💬 fanquake commented on pull request "depends: remove dependency on Darwin libtool":
(https://github.com/bitcoin/bitcoin/pull/29232#issuecomment-1887550112)
Actually, you'll also need to move `cmake-minimal` from the darwin target into the package list for all targets, in our Guix manifest. Ideally as the first commit. Otherwise this wont Guix build.

💬 theStack commented on pull request "log mempool loading progress":
(https://github.com/bitcoin/bitcoin/pull/29227#issuecomment-1887556899)
Concept ACK

👍 fanquake approved a pull request: "doc: update Bitcoin Core license to 2024"
(https://github.com/bitcoin/bitcoin/pull/29222#pullrequestreview-1816034826)
ACK 1f8450f066724dfbb5c5bc4060843e2f3340ed88

🚀 fanquake merged a pull request: "doc: update Bitcoin Core license to 2024"
(https://github.com/bitcoin/bitcoin/pull/29222)

💬 maflcko commented on pull request "test: add assumeutxo wallet test":
(https://github.com/bitcoin/bitcoin/pull/28838#issuecomment-1887580464)
https://github.com/bitcoin/bitcoin/actions/runs/7491713362/job/20393561752?pr=29218#step:27:7881

```
test_framework.authproxy.JSONRPCException: remove_all: The process cannot access the file because it is being used by another process.: "D:\a\_temp\test_runner_?_??_20240111_163825\wallet_assumeutxo_47\node1\regtest\w" (-1)

💬 stickies-v commented on pull request "doc: update -loglevel help following merge of PR 28318":
(https://github.com/bitcoin/bitcoin/pull/29230#discussion_r1449155399)
Sorry I didn't check and just assumed it printed all levels 🤦 resolved indeed.

💬 jonatack commented on pull request "doc: update -loglevel help following merge of PR 28318":
(https://github.com/bitcoin/bitcoin/pull/29230#issuecomment-1887592112)
Re-pushed to provide the accepted log levels and the always-logged ones in the same order of severity (descending).

💬 fanquake commented on pull request "Update to new logging API":
(https://github.com/bitcoin/bitcoin/pull/29231#issuecomment-1887593572)
Concept ACK - only 3 conflicts, and none looks like priority projects.

💬 m3dwards commented on pull request "build: remove `--enable-lto`":
(https://github.com/bitcoin/bitcoin/pull/29185#issuecomment-1887593784)
Tested 2d1b1c7daeeada3f737e62ceb2db7484cde5ff4e on MacOS

```shell
$ ./configure CC=clang CXX=clang++ CXXFLAGS="-g -v -flto=thin" SECP_CFLAGS="-g -flto=thin" LDFLAGS="-flto-jobs=3"
$ make check
```

With `-v` flag on CXXFLAGS I could see that `-flto=thin` was present.

👍 stickies-v approved a pull request: "doc: update -loglevel help following merge of PR 28318"
(https://github.com/bitcoin/bitcoin/pull/29230#pullrequestreview-1816071825)
ACK ec779a2b8e4fcc00596ee8833be35ae9b326552c

👍 ryanofsky approved a pull request: "init: handle empty settings file gracefully"
(https://github.com/bitcoin/bitcoin/pull/29144#pullrequestreview-1816056425)
Code review ACK 6f3183e0f0dec375241db96db417aa26e7c3e987. This seems like a helpful change.

But It does seem unfortunate that both of the commits here make tests more verbose and repetitive. And the tests even before this PR were probably unnecessarily fragile. But I'm not sure I see a better way to write the tests, or a way to avoid the repetition of warning and error messages. If anybody has any ideas on how to improve the tests here, I'd be interested to know.

💬 ryanofsky commented on pull request "init: handle empty settings file gracefully":
(https://github.com/bitcoin/bitcoin/pull/29144#discussion_r1449147413)
**In commit "settings: add auto-generated warning msg for editing the file manually" (6f3183e0f0dec375241db96db417aa26e7c3e987)

Should probably drop f'' format string prefix, since this doesn't contain any formatting expressions.

💬 theuni commented on pull request "depends: remove dependency on Darwin libtool":
(https://github.com/bitcoin/bitcoin/pull/29232#issuecomment-1887597344)
> cmake-minimal

Thanks, done.

💬 jonatack commented on pull request "Severity-based logging -- parent PR":
(https://github.com/bitcoin/bitcoin/pull/25203#discussion_r1449163824)
Noting here that this change was done in #28318.

💬 jonatack commented on pull request "Severity-based logging -- parent PR":
(https://github.com/bitcoin/bitcoin/pull/25203#discussion_r1449164398)
Noting here that this change was done in #28318, resolving.

💬 jonatack commented on pull request "logging: Simplify API for level based logging":
(https://github.com/bitcoin/bitcoin/pull/28318#discussion_r1449165848)
Possibly relevant comment: [`118c756` (#25203)](https://github.com/bitcoin/bitcoin/pull/25203/commits/118c7567f62df2b882877590f232242d7c627a05#r975577418)

💬 achow101 commented on pull request "test: detect OS in functional tests consistently using `platform.system()`":
(https://github.com/bitcoin/bitcoin/pull/29034#issuecomment-1887610930)
ACK 878d914777a03a04ecb84217152e8b7fd73a5062

🚀 achow101 merged a pull request: "test: detect OS in functional tests consistently using `platform.system()`"
(https://github.com/bitcoin/bitcoin/pull/29034)

📝 fanquake opened a pull request: "build: depends move macOS C(XX) FLAGS out of C & CXX"
(https://github.com/bitcoin/bitcoin/pull/29233)
Move some C/CXX FLAGS out of C/CXX. The remaining flags are host/SDK related, and will need some more thought.
This is more correct in any case, and simplifies future changes.
Related to #21778.