💬 glozow commented on pull request "v3 transaction policy for anti-pinning":
(https://github.com/bitcoin/bitcoin/pull/28948#discussion_r1425084623)
Ok the lazy way clearly doesn't work; I think what we have to do is calculate in-package ancestors and feed that to `ApplyV3Rules` when we call it. This will also have the effect of consolidating our v3 checks so that it's cleaner. Pushing soon...

💬 fanquake commented on pull request "ci: Use Ubuntu 24.04 Noble for asan,tsan,tidy,fuzz":
(https://github.com/bitcoin/bitcoin/pull/28992#issuecomment-1853568692)
> Will be fixed in 17.0.6-2 once noble-proposed is released,

This has shipped, and `17.0.6-2` is available.

🚀 fanquake merged a pull request: "util: Remove DirIsWritable, GetUniquePath"
(https://github.com/bitcoin/bitcoin/pull/28075)

💬 1ma commented on pull request "datacarriersize: Match more datacarrying":
(https://github.com/bitcoin/bitcoin/pull/28408#issuecomment-1853641110)
@conduition thanks for writing that article, it's a very interesting read but I still feel we are not on the same page yet.

The point of "fighting the spam TXs" is not to prevent all forms of data inscription at all costs, it's to fix Bitcoin's fee market. The crux of the problem as described [here](https://github.com/bitcoin/bitcoin/pull/28408#issuecomment-1852569550) and [here](https://github.com/bitcoin/bitcoin/pull/28408#issuecomment-1852673575) is that inscriptions dramatically overpay f
...

📝 nikodemas opened a pull request: "test: add TestNode wait_until helper"
(https://github.com/bitcoin/bitcoin/pull/29070)
Add `wait_until` method that wraps the `wait_until_helper_internal` call.

Closes https://github.com/bitcoin/bitcoin/issues/29029.

🤔 BrandonOdiwuor reviewed a pull request: "bench: wallet, fix change position out of range error"
(https://github.com/bitcoin/bitcoin/pull/29065#pullrequestreview-1779322117)
Concept ACK

💬 maflcko commented on pull request "test: add TestNode wait_until helper":
(https://github.com/bitcoin/bitcoin/pull/29070#issuecomment-1853665006)
lgtm ACK bf0f7dbec6590a54ec890e7a2ca5d85427995334

🚀 fanquake merged a pull request: "depends: fix libmultiprocess build on aarch64"
(https://github.com/bitcoin/bitcoin/pull/28846)

💬 fanquake commented on pull request "build: disable external-signer for Windows":
(https://github.com/bitcoin/bitcoin/pull/28967#issuecomment-1853689940)
> Let's at least let builders explicitly enable it?

That would mostly defeat the point of this change, and leave us supporting code that we've deemed unsafe and unreviewed. If someone wants to do that, they are free to understand the risks, and patch their own code.

📝 maflcko opened a pull request: "refactor: Remove Span operator==, Use std::ranges::equal"
(https://github.com/bitcoin/bitcoin/pull/29071)
`std::span` removed the comparison operators, so it makes sense to remove them for the `Span` "backport" as well. Using `std::ranges::equal` also has the benefit that some `Span` temporary constructions can now be dropped.

👋 BrandonOdiwuor's pull request is ready for review: "Wallet: Calculate used balance from GetBalance(...)"
(https://github.com/bitcoin/bitcoin/pull/29062)

💬 glozow commented on pull request "v3 transaction policy for anti-pinning":
(https://github.com/bitcoin/bitcoin/pull/28948#discussion_r1425181714)
deleted

💬 glozow commented on pull request "v3 transaction policy for anti-pinning":
(https://github.com/bitcoin/bitcoin/pull/28948#discussion_r1425182035)
added error string checks everywhere

💬 glozow commented on pull request "v3 transaction policy for anti-pinning":
(https://github.com/bitcoin/bitcoin/pull/28948#discussion_r1425182152)
done

💬 glozow commented on pull request "v3 transaction policy for anti-pinning":
(https://github.com/bitcoin/bitcoin/pull/28948#discussion_r1425181660)
deleted

💬 glozow commented on pull request "v3 transaction policy for anti-pinning":
(https://github.com/bitcoin/bitcoin/pull/28948#discussion_r1425181145)
Ok there are now only 2 places where v3 is checked: package sanity checks, and then `ApplyV3Rules` for each tx. I think the sanity check is very useful, as there is some heavy-ish computation done to calculate each transaction's ancestor set (including in-package and their mempool ancestors) to pass on to `ApplyV3Rules`. I've moved inheritance checks into `ApplyV3Rules` and made all errors "v3-rule-violation" with more details in the debug string.

💬 glozow commented on pull request "v3 transaction policy for anti-pinning":
(https://github.com/bitcoin/bitcoin/pull/28948#discussion_r1425180669)
yikes, fixed

💬 fanquake commented on pull request "test: Actually fail when a python unit test fails":
(https://github.com/bitcoin/bitcoin/pull/29068#issuecomment-1853733189)
> Fun fact: This problem would not exist in a type-safe language.

It's time to start rewriting code in such a language.

💬 glozow commented on pull request "v3 transaction policy for anti-pinning":
(https://github.com/bitcoin/bitcoin/pull/28948#issuecomment-1853734787)
https://github.com/bitcoin/bitcoin/pull/28948#pullrequestreview-1777711045

Added this test but changed the `tx_v3_child_heavy` test assuming that it wasn't supposed to be submitted with `tx_v3_parent_2_normal` (it fails package topo checks then), lmk if you had something else in mind?

🚀 fanquake merged a pull request: "test: Actually fail when a python unit test fails"
(https://github.com/bitcoin/bitcoin/pull/29068)

🚀 fanquake merged a pull request: "build: disable external-signer for Windows"
(https://github.com/bitcoin/bitcoin/pull/28967)