💬 MarcoFalke commented on pull request "Avoid integer overflow in CheckDiskSpace":
(https://github.com/bitcoin/bitcoin/pull/27235#discussion_r1132473107)
```suggestion
uint64_t assumed_chain_bytes{chainparams.AssumedBlockchainSize() * 1024 * 1024 * 1024};
```

Instead of "size", use "bytes", like in other places, for example `additional_bytes_needed`?

💬 MarcoFalke commented on pull request "Avoid integer overflow in CheckDiskSpace":
(https://github.com/bitcoin/bitcoin/pull/27235#issuecomment-1463915543)
Should be trivial to add a test, no?

💬 furszy commented on pull request "Mask values on Transactions View":
(https://github.com/bitcoin-core/gui/pull/708#discussion_r1132487327)
tiny nit:
Extra whitespace space.

💬 furszy commented on pull request "Mask values on Transactions View":
(https://github.com/bitcoin-core/gui/pull/708#discussion_r1132491161)
This is not needed. With line 17 is enough, the include is done in the cpp file.

💬 fanquake commented on pull request "rpc: fix logging RPC when "none" values are passed, add test coverage, improve docs":
(https://github.com/bitcoin/bitcoin/pull/27231#issuecomment-1463949565)
> The behavior was intended to be added in https://github.com/bitcoin/bitcoin/pull/11191.

It's still not clear if this was broken from the time it was merged, or at some other later point. This also does not work with 22.x, and any earlier versions are EOL.

If it's been broken forever (or at least is in all currently maintained releases), and no ones even noticed, we could take advantage of that, to remove some of the complexity here; do we definitely need multiple different ways of achiev
...

💬 TheCharlatan commented on pull request "doc: Show how less noisy clang-tidy output can be achieved":
(https://github.com/bitcoin/bitcoin/pull/27205#issuecomment-1463951556)
Updated 6a29f34ac0afce501af45097916256a9bffe8d19 -> d880c78e708d3cb0c44631e3be759d6991d5a910 ([dev-notes-clang-tidy_0](https://github.com/TheCharlatan/bitcoin/tree/dev-notes-clang-tidy_0) -> [dev-notes-clang-tidy_1](https://github.com/TheCharlatan/bitcoin/tree/dev-notes-clang-tidy_1), [compare](https://github.com/TheCharlatan/bitcoin/compare/dev-notes-clang-tidy_0..dev-notes-clang-tidy_1)) to address @MarcoFalke's feedback.

💬 MarcoFalke commented on pull request "Avoid integer overflow in CheckDiskSpace":
(https://github.com/bitcoin/bitcoin/pull/27235#issuecomment-1463966293)
Introduced in 6630a1e8448c633e4abaa8f5903f11cac6f433a7 so I guess no backport needed?

💬 TheCharlatan commented on pull request "doc: Show how less noisy clang-tidy output can be achieved":
(https://github.com/bitcoin/bitcoin/pull/27205#issuecomment-1463986021)
Updated https://github.com/bitcoin/bitcoin/commit/6a29f34ac0afce501af45097916256a9bffe8d19 -> 3d524c9d4664026c318c2ec90baacc2bee4f4525 ([dev-notes-clang-tidy_1](https://github.com/TheCharlatan/bitcoin/tree/dev-notes-clang-tidy_1) -> [dev-notes-clang-tidy_2](https://github.com/TheCharlatan/bitcoin/tree/dev-notes-clang-tidy_2), [compare](https://github.com/TheCharlatan/bitcoin/compare/dev-notes-clang-tidy_1..dev-notes-clang-tidy_2)) to fix typos and trailing newline.

💬 fanquake commented on pull request "doc: Show how less noisy clang-tidy output can be achieved":
(https://github.com/bitcoin/bitcoin/pull/27205#discussion_r1132543346)
Think you forgot to drop this?

👍 ryanofsky approved a pull request: "util: fix argsman dupe key error"
(https://github.com/bitcoin/bitcoin/pull/27236)
Code review ACK 8fcbdadfad8a9b3143527141ff37e5fe1e87f3b3. Thanks for the fix! I would maybe update the PR description or add to it to describe behavior change of this PR:

---

bugfix: Fix broken GUI "Reset" button when settings.json contains duplicate keys

Make GUI "Settings file could not be read. Do you want to reset settings to default values?" dialog actually clear all settings instead of partially keeping them when `settings.json` contains duplicate keys. This change has no effect o
...

💬 TheCharlatan commented on pull request "doc: Show how less noisy clang-tidy output can be achieved":
(https://github.com/bitcoin/bitcoin/pull/27205#issuecomment-1464014496)
Updated 3d524c9d4664026c318c2ec90baacc2bee4f4525 -> 54c4d03578c5842f19bf8bc68aca5faf8beed5c3 ([dev-notes-clang-tidy_2](https://github.com/TheCharlatan/bitcoin/tree/dev-notes-clang-tidy_2) -> [dev-notes-clang-tidy_3](https://github.com/TheCharlatan/bitcoin/tree/dev-notes-clang-tidy_3), [compare](https://github.com/TheCharlatan/bitcoin/compare/dev-notes-clang-tidy_2..dev-notes-clang-tidy_3)) to get rid of the old documentation paragraph @fanquake .

👍 ryanofsky approved a pull request: "refactor: Consistenly use context args over gArgs in node/interfaces"
(https://github.com/bitcoin/bitcoin/pull/27239)
Code review ACK facbb444bf5aea2bbaa4a4246a8a2c661d9bf314. Thanks for the cleanup. Could s/consistenly/consistently/ too

💬 ryanofsky commented on pull request "refactor: Consistenly use context args over gArgs in node/interfaces":
(https://github.com/bitcoin/bitcoin/pull/27239#discussion_r1132558283)
In commit "refactor: Consistenly use context args over gArgs in node/interfaces" (11110f2e3d97d7d88ada1fdaab70a866bf9a35d7)

Slight preference for calling this `args` not `argsman`. `args` is used more commonly in code (921 vs 340 times before this commit). Also I always thought the name `ArgsManager` was a misnomer, because it's really a data container that doesn't manage any significant internal state.

💬 brunoerg commented on pull request "rpc: Add test-only RPC getaddrmaninfo for new/tried table address count":
(https://github.com/bitcoin/bitcoin/pull/26988#issuecomment-1464036406)
perhaps we could also check this is a hidden RPC like `addpeerinfo`?

```py
self.log.debug("Test that addpeerinfo is a hidden RPC")
# It is hidden from general help, but its detailed help may be called directly.
assert "addpeerinfo" not in node.help()
assert "addpeerinfo" in node.help("addpeerinfo")
```

💬 MarcoFalke commented on pull request "doc: Show how less noisy clang-tidy output can be achieved":
(https://github.com/bitcoin/bitcoin/pull/27205#issuecomment-1464052726)
utACK 54c4d03578c5842f19bf8bc68aca5faf8beed5c3

💬 MarcoFalke commented on pull request "refactor: Consistently use context args over gArgs in node/interfaces":
(https://github.com/bitcoin/bitcoin/pull/27239#discussion_r1132594790)
thx, done

👍 ryanofsky approved a pull request: "refactor: Consistently use context args over gArgs in node/interfaces"
(https://github.com/bitcoin/bitcoin/pull/27239)
Code review ACK fa3e9b420fbc1ce9b20218f03356502e1b79d5ff

💬 willcl-ark commented on pull request "util: fix argsman dupe key error":
(https://github.com/bitcoin/bitcoin/pull/27236#issuecomment-1464067161)
Thanks @ryanofsky . I updated the PR description with your recommendation. Did you think I should update the commit title to "bugfix: Fix broken GUI "Reset" button when settings.json contains duplicate keys" also? I'm happy to do that if so.

🚀 fanquake merged a pull request: "doc: Show how less noisy clang-tidy output can be achieved"
(https://github.com/bitcoin/bitcoin/pull/27205)

💬 ishaanam commented on pull request "test: fix race condition in encrypted wallet rescan tests":
(https://github.com/bitcoin/bitcoin/pull/27199#discussion_r1132608578)
This should be fixed now, thanks.

💬 ryanofsky commented on pull request "util: fix argsman dupe key error":
(https://github.com/bitcoin/bitcoin/pull/27236#issuecomment-1464076968)
> Thanks @ryanofsky . I updated the PR description with your recommendation. Did you think I should update the commit title to "bugfix: Fix broken GUI "Reset" button when settings.json contains duplicate keys" also? I'm happy to do that if so.

Either way seems fine, it's just a choice of whether you think it's more useful to describe the goal of the PR or the implemenation of the PR. Another alternative to changing the title could be changing the first line "fixes #22638" to "fixes #22638, br
...