💬 hebasto commented on pull request "Add a note to msvc readme re building Qt for Bitcoin Core.":
(https://github.com/bitcoin/bitcoin/pull/29048#issuecomment-1848998396)
> Or, am I missing something?

Just [rewording](https://github.com/bitcoin/bitcoin/pull/29048#issuecomment-1848977484) the linter:

The problem is:
```
$ stat build_msvc/README.md
File: build_msvc/README.md
Size: 5650 Blocks: 16 IO Block: 4096 regular file
Device: 10303h/66307d Inode: 14949723 Links: 1
Access: (0755/-rwxr-xr-x) Uid: ( 1001/ hebasto) Gid: ( 1001/ hebasto)
Access: 2023-12-10 15:34:07.780145234 +0000
Modify: 2023-12-10 15:34:06.520175365 +0000
...

💬 hebasto commented on pull request "Add a note to msvc readme re building Qt for Bitcoin Core.":
(https://github.com/bitcoin/bitcoin/pull/29048#issuecomment-1849000383)
@sipsorcery

We make such changes in a single commit usually :)

Mind [squashing](https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits) your commits?

👍 hebasto approved a pull request: "Add a note to msvc readme re building Qt for Bitcoin Core."
(https://github.com/bitcoin/bitcoin/pull/29048#pullrequestreview-1774057604)
ACK d08e820abf5da2be09b8a84b5bd3450d1a55a039.

💬 kashifs commented on pull request "wallet: Add CoinGrinder coin selection algorithm":
(https://github.com/bitcoin/bitcoin/pull/27877#discussion_r1421777389)
For consistency, I think this should read:

`the 4th is deselected, the 2nd is deselected and the 3rd is selected`

💬 hebasto commented on pull request "test: detect OS in functional tests consistently using `platform.system()`":
(https://github.com/bitcoin/bitcoin/pull/29034#issuecomment-1849009261)
> The following table shows values for common operating systems, found via
>
> ```
> $ python3 -c "import os; import sys; import platform; print(os.name, sys.platform, platform.system())"
> ```
>
> | OS | os.name | sys.platform | platform.system() |
> |---|---|---|---|
> | MacOS* | posix | darwin | Darwin |
> | Windows* | nt | win32 | Windows |
>
> * = I neither have a MacOS nor a Windows machine available, so I extracted the values from documentation and our current code. Also I'm
...

💬 subhakundu commented on issue "test: 999 of 999 multisig":
(https://github.com/bitcoin/bitcoin/issues/28179#issuecomment-1849010214)
Is someone working on it? Otherwise, I would like to work on it. This is the first time I will work on Bitcoin code base. I see, this is the only first-time not active issue.

💬 eriknylund commented on issue "test: 999 of 999 multisig":
(https://github.com/bitcoin/bitcoin/issues/28179#issuecomment-1849012075)
> Is someone working on it? Otherwise, I would like to work on it. This is the first time I will work on Bitcoin code base. I see, this is the only first-time not active issue.

I have a PR https://github.com/bitcoin/bitcoin/pull/28212 open for it, so please review if you have a chance. 🙏

👋 ishaanam's pull request is ready for review: "wallet, rpc: document and update `sendall` behavior around unconfirmed inputs"
(https://github.com/bitcoin/bitcoin/pull/28979)

💬 hugomenezes85 commented on issue "Bitcoin Core - Transaction without permition":
(https://github.com/bitcoin/bitcoin/issues/29049#issuecomment-1849019922)

💬 Cryptomaster001 commented on issue "Bitcoin Core - Transaction without permition":
(https://github.com/bitcoin/bitcoin/issues/29049#issuecomment-1849020345)
Hello @hugomenezes85,
can you post the transaction hash?

💬 hugomenezes85 commented on issue "Bitcoin Core - Transaction without permition":
(https://github.com/bitcoin/bitcoin/issues/29049#issuecomment-1849020706)
Hi,YesCumprimentosHugo MenezesNo dia 10/12/2023, às 16:58, Cryptomaster001 ***@***.***> escreveu:
Hello @hugomenezes85,
can you post the transaction hash?

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>

💬 hugomenezes85 commented on issue "Bitcoin Core - Transaction without permition":
(https://github.com/bitcoin/bitcoin/issues/29049#issuecomment-1849021340)
> Hello @hugomenezes85, can you post the transaction hash?

Hi, i think its this picture.

💬 TheCharlatan commented on pull request "kernel: Streamline util library":
(https://github.com/bitcoin/bitcoin/pull/29015#issuecomment-1849026409)
Re https://github.com/bitcoin/bitcoin/pull/29015#issuecomment-1848935768

> Does it make sense to improve https://github.com/bitcoin/bitcoin/blob/master/doc/design/libraries.md by expressing the idea from the quotes above more clearly? As for now, it reads:

This seems like the right place to talk about the relationship between the util and kernel library. My work on the kernel library has been focusing on reducing its essence to validation code, pruning external dependencies, and stripping
...

💬 kashifs commented on pull request "wallet: Add CoinGrinder coin selection algorithm":
(https://github.com/bitcoin/bitcoin/pull/27877#discussion_r1421789507)
This should read:

`@param std::vector<OutputGroup>& utxo_pool The UTXO groups that we are choosing from.`

💬 kashifs commented on pull request "wallet: Add CoinGrinder coin selection algorithm":
(https://github.com/bitcoin/bitcoin/pull/27877#discussion_r1421790528)
this should read:

`@param CAmount change_target The minimum budget for creating a change output that we add to the selection_target.`

👍 hebasto approved a pull request: "test: detect OS in functional tests consistently using `platform.system()`"
(https://github.com/bitcoin/bitcoin/pull/29034#pullrequestreview-1774073057)
ACK 878d914777a03a04ecb84217152e8b7fd73a5062, I have reviewed the code and it looks OK.

💬 ariard commented on pull request "[WIP] BIP300 (Drivechains) consensus-level logic":
(https://github.com/bitcoin/bitcoin/pull/28311#issuecomment-1849045560)
> > My invitation to discuss in person about the topic of Bitcoin consensus change at a conference during the coming years stays open, or on the mailing list if it’s a communication medium you think it’s better suited.

Held my words here. A twitter space did happen end of last week between one of the PR author and myself, which was pleasant overall.

I made it clear I didn’t have any strong thoughts on drivechain, though I took time to express 2 generic concerns I think affecting all bitcoi
...

💬 ariard commented on pull request "Ephemeral Anchors":
(https://github.com/bitcoin/bitcoin/pull/29001#issuecomment-1849051771)
> BIP text here: https://github.com/instagibbs/bips/blob/ephemeral_anchor/bip-ephemeralanchors.mediawiki

"Be 0-fee”

This is uncertain to me how this rule works with trimmed HTLCs on LN commitment transactions making their fees non-zero, even assuming anchor outputs where second-stage txn are signed with 0-feerate.

Beyond, I think it should add an information section at destination of use-cases developers discouraging the usage of anyone-can-spend ephemeral anchor. Otherwise a time-sensi
...

💬 instagibbs commented on pull request "Ephemeral Anchors":
(https://github.com/bitcoin/bitcoin/pull/29001#issuecomment-1849066824)
@ariard I'd rather talk downstream details over here https://github.com/bitcoin/bips/pull/1524

⚠️ sinetek opened an issue: "The logo icon doesn't show properly under Wayland"
(https://github.com/bitcoin-core/gui/issues/781)
### Is there an existing issue for this?

- [X] I have searched the existing issues

### Current behaviour

There should be a bitcoin logo icon when running the application under a wayland session.
Right now it looks like this on my machine.




### Expected behaviour

It should look like this (run on the same machine, same everything, but with platform xcb):

![image](https://github.com/bitc
...

👍 TheCharlatan approved a pull request: "Add a note to msvc readme re building Qt for Bitcoin Core."
(https://github.com/bitcoin/bitcoin/pull/29048#pullrequestreview-1774091824)
ACK d08e820abf5da2be09b8a84b5bd3450d1a55a039