📝 TheCharlatan converted_to_draft a pull request: "build: Introduce internal kernel library"
(https://github.com/bitcoin/bitcoin/pull/28690)
This PR introduces a new `libbitcoin_kernel` internal library. It completes the internal library design as laid out in [doc/design/libraries.md](https://github.com/bitcoin/bitcoin/blob/master/doc/design/libraries.md). The external `libbitcoinkernel` library now uses the source lists of the internal library for its compilation.

Should also address https://github.com/bitcoin/bitcoin/issues/28548.

💬 hebasto commented on pull request "test: detect OS in functional tests consistently using `platform.system()`":
(https://github.com/bitcoin/bitcoin/pull/29034#issuecomment-1848986424)
Concept ACK.

💬 kashifs commented on pull request "Add multiplication operator to CFeeRate":
(https://github.com/bitcoin/bitcoin/pull/29037#issuecomment-1848986657)
tACK [1553c80](https://github.com/bitcoin/bitcoin/pull/29037/commits/1553c8078698df1058b62e8fdadaf74160977b30)

I compiled from source, ran the test suite, and added some additional BOOST_CHECK tests on my local machine that all passed

⚠️ hugomenezes85 opened an issue: "Bitcoin Core - Transaction without permition"
(https://github.com/bitcoin/bitcoin/issues/29049)
Hi,
I open my Wallet Bitcoin Core and i notice a transaction with my total amount without any my permition.
Any one can help?


💬 sipsorcery commented on pull request "Add a note to msvc readme re building Qt for Bitcoin Core.":
(https://github.com/bitcoin/bitcoin/pull/29048#issuecomment-1848996936)
> @sipsorcery
>
> There is a linter error in CI:

Even after I manually checked for whitespace violations on that single line addition :(.

Although it does seem like the linter culprit may be elsewhere? Or, am I missing something?

```
src/test/fuzz/package_eval.cpp:214: non-existant ==> non-existent
src/test/span_tests.cpp:56: memeber ==> member
^ Warning: codespell identified likely spelling errors. Any false positives? Add them to the list of ignored words in test/lint/spelling.
...

💬 hugomenezes85 commented on issue "Bitcoin Core - Transaction without permition":
(https://github.com/bitcoin/bitcoin/issues/29049#issuecomment-1848998093)

💬 hebasto commented on pull request "Add a note to msvc readme re building Qt for Bitcoin Core.":
(https://github.com/bitcoin/bitcoin/pull/29048#issuecomment-1848998396)
> Or, am I missing something?

Just [rewording](https://github.com/bitcoin/bitcoin/pull/29048#issuecomment-1848977484) the linter:

The problem is:
```
$ stat build_msvc/README.md
File: build_msvc/README.md
Size: 5650 Blocks: 16 IO Block: 4096 regular file
Device: 10303h/66307d Inode: 14949723 Links: 1
Access: (0755/-rwxr-xr-x) Uid: ( 1001/ hebasto) Gid: ( 1001/ hebasto)
Access: 2023-12-10 15:34:07.780145234 +0000
Modify: 2023-12-10 15:34:06.520175365 +0000
...

💬 hebasto commented on pull request "Add a note to msvc readme re building Qt for Bitcoin Core.":
(https://github.com/bitcoin/bitcoin/pull/29048#issuecomment-1849000383)
@sipsorcery

We make such changes in a single commit usually :)

Mind [squashing](https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits) your commits?

👍 hebasto approved a pull request: "Add a note to msvc readme re building Qt for Bitcoin Core."
(https://github.com/bitcoin/bitcoin/pull/29048#pullrequestreview-1774057604)
ACK d08e820abf5da2be09b8a84b5bd3450d1a55a039.

💬 kashifs commented on pull request "wallet: Add CoinGrinder coin selection algorithm":
(https://github.com/bitcoin/bitcoin/pull/27877#discussion_r1421777389)
For consistency, I think this should read:

`the 4th is deselected, the 2nd is deselected and the 3rd is selected`

💬 hebasto commented on pull request "test: detect OS in functional tests consistently using `platform.system()`":
(https://github.com/bitcoin/bitcoin/pull/29034#issuecomment-1849009261)
> The following table shows values for common operating systems, found via
>
> ```
> $ python3 -c "import os; import sys; import platform; print(os.name, sys.platform, platform.system())"
> ```
>
> | OS | os.name | sys.platform | platform.system() |
> |---|---|---|---|
> | MacOS* | posix | darwin | Darwin |
> | Windows* | nt | win32 | Windows |
>
> * = I neither have a MacOS nor a Windows machine available, so I extracted the values from documentation and our current code. Also I'm
...

💬 subhakundu commented on issue "test: 999 of 999 multisig":
(https://github.com/bitcoin/bitcoin/issues/28179#issuecomment-1849010214)
Is someone working on it? Otherwise, I would like to work on it. This is the first time I will work on Bitcoin code base. I see, this is the only first-time not active issue.

💬 eriknylund commented on issue "test: 999 of 999 multisig":
(https://github.com/bitcoin/bitcoin/issues/28179#issuecomment-1849012075)
> Is someone working on it? Otherwise, I would like to work on it. This is the first time I will work on Bitcoin code base. I see, this is the only first-time not active issue.

I have a PR https://github.com/bitcoin/bitcoin/pull/28212 open for it, so please review if you have a chance. 🙏

👋 ishaanam's pull request is ready for review: "wallet, rpc: document and update `sendall` behavior around unconfirmed inputs"
(https://github.com/bitcoin/bitcoin/pull/28979)

💬 hugomenezes85 commented on issue "Bitcoin Core - Transaction without permition":
(https://github.com/bitcoin/bitcoin/issues/29049#issuecomment-1849019922)

💬 Cryptomaster001 commented on issue "Bitcoin Core - Transaction without permition":
(https://github.com/bitcoin/bitcoin/issues/29049#issuecomment-1849020345)
Hello @hugomenezes85,
can you post the transaction hash?

💬 hugomenezes85 commented on issue "Bitcoin Core - Transaction without permition":
(https://github.com/bitcoin/bitcoin/issues/29049#issuecomment-1849020706)
Hi,YesCumprimentosHugo MenezesNo dia 10/12/2023, às 16:58, Cryptomaster001 ***@***.***> escreveu:
Hello @hugomenezes85,
can you post the transaction hash?

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>

💬 hugomenezes85 commented on issue "Bitcoin Core - Transaction without permition":
(https://github.com/bitcoin/bitcoin/issues/29049#issuecomment-1849021340)
> Hello @hugomenezes85, can you post the transaction hash?

Hi, i think its this picture.

💬 TheCharlatan commented on pull request "kernel: Streamline util library":
(https://github.com/bitcoin/bitcoin/pull/29015#issuecomment-1849026409)
Re https://github.com/bitcoin/bitcoin/pull/29015#issuecomment-1848935768

> Does it make sense to improve https://github.com/bitcoin/bitcoin/blob/master/doc/design/libraries.md by expressing the idea from the quotes above more clearly? As for now, it reads:

This seems like the right place to talk about the relationship between the util and kernel library. My work on the kernel library has been focusing on reducing its essence to validation code, pruning external dependencies, and stripping
...

💬 kashifs commented on pull request "wallet: Add CoinGrinder coin selection algorithm":
(https://github.com/bitcoin/bitcoin/pull/27877#discussion_r1421789507)
This should read:

`@param std::vector<OutputGroup>& utxo_pool The UTXO groups that we are choosing from.`

💬 kashifs commented on pull request "wallet: Add CoinGrinder coin selection algorithm":
(https://github.com/bitcoin/bitcoin/pull/27877#discussion_r1421790528)
this should read:

`@param CAmount change_target The minimum budget for creating a change output that we add to the selection_target.`