✅ adamjonas closed an issue: "Versionbits should have an ignore button"
(https://github.com/bitcoin/bitcoin/issues/8266)

💬 adamjonas commented on issue "[Linux] Add wayland support":
(https://github.com/bitcoin/bitcoin/issues/19950#issuecomment-1462705087)
Closing for reasons stated by hebasto above.

✅ adamjonas closed an issue: "[Linux] Add wayland support"
(https://github.com/bitcoin/bitcoin/issues/19950)

💬 adamjonas commented on issue "ops: Enable DNSSEC on all Bitcoin DNS Seed domain names":
(https://github.com/bitcoin/bitcoin/issues/19714#issuecomment-1462709723)
Closing since the rest of the seeders have said they are not going to implement or have not addressed for multiple years.

✅ adamjonas closed an issue: "ops: Enable DNSSEC on all Bitcoin DNS Seed domain names"
(https://github.com/bitcoin/bitcoin/issues/19714)

💬 adamjonas commented on issue "Cannot do HTTP JSON RPC request on wallet":
(https://github.com/bitcoin/bitcoin/issues/25635#issuecomment-1462721626)
Closing based on the above solution by @pinheadmz. Please ping if this doesn't resolve it.

✅ adamjonas closed an issue: "Cannot do HTTP JSON RPC request on wallet"
(https://github.com/bitcoin/bitcoin/issues/25635)

💬 adamjonas commented on issue "RPC `getblock` resulted in 500 and ReadBlockFromDisk: OpenBlockFile failed for FlatFilePos(nFile=-1, nPos=0)":
(https://github.com/bitcoin/bitcoin/issues/20978#issuecomment-1462728376)
@arcivanov any chance you'd be willing to attempt to reproduce with an updated release?

💬 adamjonas commented on issue "RPC field to indicate which of the conflicted wallet transactions is in the mempool":
(https://github.com/bitcoin/bitcoin/issues/21018#issuecomment-1462745565)
This hasn't seen any activity for a few years and doesn't seem to be making forward progress. Closing for now.

✅ adamjonas closed an issue: "RPC field to indicate which of the conflicted wallet transactions is in the mempool"
(https://github.com/bitcoin/bitcoin/issues/21018)

💬 adamjonas commented on issue "How to convert dumptxoutset rpc result to human readable JSON":
(https://github.com/bitcoin/bitcoin/issues/21670#issuecomment-1462753761)
There doesn't seem to be a lot of interest for the feature based on this issue but https://github.com/bitcoin/bitcoin/pull/24202 was pretty close.

💬 adamjonas commented on issue "Incorrect balance reported in getwalletinfo/getbalance":
(https://github.com/bitcoin/bitcoin/issues/21768#issuecomment-1462756998)
@Crypto2 can you attempt to reproduce with a updated version, please?

💬 Crypto2 commented on issue "Incorrect balance reported in getwalletinfo/getbalance":
(https://github.com/bitcoin/bitcoin/issues/21768#issuecomment-1462833684)
Yep I'll keep an eye on it if/when the network gets backed up like that again.

💬 furszy commented on pull request "Implement Mini version of BlockAssembler to calculate mining scores":
(https://github.com/bitcoin/bitcoin/pull/27021#discussion_r1131024834)
This can be a `CTransactionRef` (aka shared_ptr) and not a plain tx copy. Transaction data never changes.

Just need to adapt the constructor to call `GetSharedTx` instead.

💬 furszy commented on pull request "Implement Mini version of BlockAssembler to calculate mining scores":
(https://github.com/bitcoin/bitcoin/pull/27021#discussion_r1131070331)
In a0d54e6b:

`mempool.CalculateDescendants` returns the base parent transaction. So you could remove this line and add a comment to remember it.

💬 furszy commented on pull request "Implement Mini version of BlockAssembler to calculate mining scores":
(https://github.com/bitcoin/bitcoin/pull/27021#discussion_r1131091527)
In https://github.com/bitcoin/bitcoin/commit/a0d54e6b8f8afab070de48911f3b11d4cdf289ff:

nano nit:
Could prevent extra `GetConflictTx` calls by moving the conflicting tx block of code inside the `mempool.exists` block.
e.g.

```c++
for (const auto& outpoint : outpoints) {
if (!mempool.exists(GenTxid::Txid(outpoint.hash))) {
// This UTXO is either confirmed or not yet submitted to mempool.
// If it's confirmed, no bump fee is required.
// If it's not yet
...

💬 furszy commented on pull request "Implement Mini version of BlockAssembler to calculate mining scores":
(https://github.com/bitcoin/bitcoin/pull/27021#discussion_r1131618449)
This has been puzzling me for a while.

It is not clear to me why need to calculate the descendants once more if they are all in the cluster.
Couldn't return from `GatherCluster` a map of tx id and descendants instead?
Would need to first go up, to the outpoints first parents, and then start going down (basically the DAG in map format).

Another point is why continue traversing the children when the parent was marked to be removed? To double assert that the previous loop worked as expected
...

💬 adamjonas commented on issue "Incorrect balance reported in getwalletinfo/getbalance":
(https://github.com/bitcoin/bitcoin/issues/21768#issuecomment-1462853559)
Mind if we close since we don't have any reports from others? Can reopen if you can isolate it again.

💬 mzumsande commented on pull request "Implement Mini version of BlockAssembler to calculate mining scores":
(https://github.com/bitcoin/bitcoin/pull/27021#discussion_r1126752055)
I think that it would be good to mention the 500 entries DoS limit here, plus the fact that we also return an empty vector if that is limit is breached - since that's something possible future users of this function would want to know about.

💬 mzumsande commented on pull request "Implement Mini version of BlockAssembler to calculate mining scores":
(https://github.com/bitcoin/bitcoin/pull/27021#discussion_r1128592892)
Indentation is broken, here and below (I initially thought the for loop ended here).

💬 pablomartin4btc commented on pull request "cli: add validation to cli side commands besides when it's used with -rpcwallet":
(https://github.com/bitcoin/bitcoin/pull/26990#discussion_r1131669863)
I've updated the test with the full error message, also I've changed the text a bit:

`Multiple wallets are loaded. Please specify a wallet by requesting the RPC through the /wallet/<filename> URI path. Using "bitcoin-cli", add the "-rpcwallet=<filename>" option before the command (run "bitcoin-cli -h" for help or "bitcoin-cli listwallets" to see which wallets are currently loaded).`