💬 1440000bytes commented on pull request "p2p, validation: Don't download witnesses for assumed-valid blocks when running in prune mode":
(https://github.com/bitcoin/bitcoin/pull/27050#issuecomment-1462547782)
> It's important to recognize that this is a security reduction, even though it only applies to assumed-valid blocks: one of the reasons why assume-valid is acceptable, is because the data that we're assuming is valid is widely available for independent auditing and our peers can't distinguish between nodes that are and are not actually checking it. Skipping the downloading of witnesses negates that security by making it possible to sync a pruned node without anyone having that data available.

...

💬 achow101 commented on pull request "wallet: Filter-out "send" addresses from `listreceivedby*`":
(https://github.com/bitcoin/bitcoin/pull/25973#issuecomment-1462547795)
ACK 62880a9bb167bc0569175d597a865e6baccce71b

📝 dergoegge converted_to_draft a pull request: "Avoid integer overflow in CheckDiskSpace"
(https://github.com/bitcoin/bitcoin/pull/27235)
Starting a fresh node with `-prune=1` causes an integer overflow to happen in `CheckDiskSpace` (e.g. https://cirrus-ci.com/task/5059018708746240) because `nPruneTarget` is to the max `uint64_t` value.
https://github.com/bitcoin/bitcoin/blob/f7bdcfc83f5753349018be3b5a663c8923d1a5eb/src/init.cpp#L1633-L1648

I think side stepping the overflow for this specific case, is better than adding an exception to the UB suppresions file. Alternatively we could use our overflow utils (e.g. `CheckedAdd`).

💬 jonatack commented on pull request "rpc: fix logging RPC when "none" values are passed, add test coverage, improve docs":
(https://github.com/bitcoin/bitcoin/pull/27231#issuecomment-1462594692)
The behavior was intended to be added in https://github.com/bitcoin/bitcoin/pull/11191.

I downloaded and tested v23.1 and the behavior wasn't functional: passing `0` or `none` had no effect.

In v24, f1379aeca9d3a8c4d3528de4d0af8298cb42fee4 made `none` not be recognized, but the logic for the intended behavior remained absent anyway.

I've added this information to the PR description.

💬 jonatack commented on pull request "rpc: fix logging RPC when "none" values are passed, add test coverage, improve docs":
(https://github.com/bitcoin/bitcoin/pull/27231#discussion_r1131465027)
Thanks @MarcoFalke, done as follows.

```cpp
static void EnableOrDisableLogCategories(const UniValue& categories, bool enable)
{
const std::vector<UniValue>& category_values{categories.get_array().getValues()};
for (const auto& category : category_values) {
const std::string& c{category.get_str()};
if (c == "0" || c == "none") return; // no-op if one of these logging categories is passed
}
for (const auto& category : category_values) {
const std
...

💬 jonatack commented on pull request "rpc: fix logging RPC when "none" values are passed, add test coverage, improve docs":
(https://github.com/bitcoin/bitcoin/pull/27231#discussion_r1131469401)
(Noting that this logic is similar to that in `SetLoggingCategories()` in `src/init/common.cpp`).

💬 amitiuttarwar commented on pull request "rpc: Add test-only RPC getaddrmaninfo for new/tried table address count":
(https://github.com/bitcoin/bitcoin/pull/26988#issuecomment-1462609621)
light code review ACK 7c34c35b47. tested that the RPC and cli endpoints make sense & handle errors reasonably. these changes will require release notes, which can be done here or in a separate PR.

💬 amitiuttarwar commented on pull request "rpc: Add test-only RPC getaddrmaninfo for new/tried table address count":
(https://github.com/bitcoin/bitcoin/pull/26988#discussion_r1131449772)
you could add coverage for `getaddrmaninfo` with a network arg passed through

💬 willcl-ark commented on pull request "Improve address decoding errors":
(https://github.com/bitcoin/bitcoin/pull/26514#issuecomment-1462666899)
Concept ACK

💬 adamjonas commented on issue "Versionbits should have an ignore button":
(https://github.com/bitcoin/bitcoin/issues/8266#issuecomment-1462703683)
> I think this issue can be closed since the warnings were removed in https://github.com/bitcoin/bitcoin/pull/15471

Closing.

✅ adamjonas closed an issue: "Versionbits should have an ignore button"
(https://github.com/bitcoin/bitcoin/issues/8266)

💬 adamjonas commented on issue "[Linux] Add wayland support":
(https://github.com/bitcoin/bitcoin/issues/19950#issuecomment-1462705087)
Closing for reasons stated by hebasto above.

✅ adamjonas closed an issue: "[Linux] Add wayland support"
(https://github.com/bitcoin/bitcoin/issues/19950)

💬 adamjonas commented on issue "ops: Enable DNSSEC on all Bitcoin DNS Seed domain names":
(https://github.com/bitcoin/bitcoin/issues/19714#issuecomment-1462709723)
Closing since the rest of the seeders have said they are not going to implement or have not addressed for multiple years.

✅ adamjonas closed an issue: "ops: Enable DNSSEC on all Bitcoin DNS Seed domain names"
(https://github.com/bitcoin/bitcoin/issues/19714)

💬 adamjonas commented on issue "Cannot do HTTP JSON RPC request on wallet":
(https://github.com/bitcoin/bitcoin/issues/25635#issuecomment-1462721626)
Closing based on the above solution by @pinheadmz. Please ping if this doesn't resolve it.

✅ adamjonas closed an issue: "Cannot do HTTP JSON RPC request on wallet"
(https://github.com/bitcoin/bitcoin/issues/25635)

💬 adamjonas commented on issue "RPC `getblock` resulted in 500 and ReadBlockFromDisk: OpenBlockFile failed for FlatFilePos(nFile=-1, nPos=0)":
(https://github.com/bitcoin/bitcoin/issues/20978#issuecomment-1462728376)
@arcivanov any chance you'd be willing to attempt to reproduce with an updated release?

💬 adamjonas commented on issue "RPC field to indicate which of the conflicted wallet transactions is in the mempool":
(https://github.com/bitcoin/bitcoin/issues/21018#issuecomment-1462745565)
This hasn't seen any activity for a few years and doesn't seem to be making forward progress. Closing for now.

✅ adamjonas closed an issue: "RPC field to indicate which of the conflicted wallet transactions is in the mempool"
(https://github.com/bitcoin/bitcoin/issues/21018)

💬 adamjonas commented on issue "How to convert dumptxoutset rpc result to human readable JSON":
(https://github.com/bitcoin/bitcoin/issues/21670#issuecomment-1462753761)
There doesn't seem to be a lot of interest for the feature based on this issue but https://github.com/bitcoin/bitcoin/pull/24202 was pretty close.