💬 andrewtoth commented on pull request "cli: improve error message on multiwallet and add validation to cli-side commands":
(https://github.com/bitcoin/bitcoin/pull/26990#discussion_r1413159420)
nit: This parameter is not a reference. It is being passed by value. This comment could be more descriptive eg:
```
@param[in] cli_command The string to check if it is a cli-command that needs to run exclusively.
```

💬 andrewtoth commented on pull request "cli: improve error message on multiwallet and add validation to cli-side commands":
(https://github.com/bitcoin/bitcoin/pull/26990#discussion_r1413160472)
nit: `2. multiple bitcoin-cli commands that need to run exclusively`

👍 andrewtoth approved a pull request: "p2p: make block download logic aware of limited peers threshold"
(https://github.com/bitcoin/bitcoin/pull/28120#pullrequestreview-1761328425)
ACK a0687ffd568b0984a8b1e51fd0061f87f25e95d7

💬 andrewtoth commented on pull request "p2p: make block download logic aware of limited peers threshold":
(https://github.com/bitcoin/bitcoin/pull/28120#discussion_r1413170635)
nit: Could add a comment on why number 12 is chosen here?

💬 andrewtoth commented on pull request "Don't empty dbcache on prune flushes: >30% faster IBD":
(https://github.com/bitcoin/bitcoin/pull/28280#issuecomment-1837561632)
Rebased, ran the following benchmark using hyperfine. Sync to block 800k 3 times on master commit and the last commit of this branch (I updated the commit recently, but no code changes only commit order changes to satisfy CI), dbcache=4000 and prune=550:

```
hyperfine \
--export-markdown ~/bench.md \
--show-output --parameter-list commit 498994b6f55d04a7940f832e7fbd17e5acdaff15,216bd93138a46cdfa66523878a36d0e634476079 \
--prepare 'git checkout {commit} && make -j$(nproc) src/bitcoind; syn
...

💬 hebasto commented on pull request "POC: Replace Boost.Process with cpp-subprocess":
(https://github.com/bitcoin/bitcoin/pull/28981#issuecomment-1837570291)
Rebased on top of the #28989.

💬 mzumsande commented on issue "getrawtransaction xxxxxx.... 2 causes a segfault":
(https://github.com/bitcoin/bitcoin/issues/28986#issuecomment-1837588656)
Are you using txindex or was the transaction in your mempool at the time of querying?

📝 NoviX-Labs opened a pull request: "Novix Plus"
(https://github.com/bitcoin/bitcoin/pull/28990)
What is Novix-Plus Core?
---------------------

Novix-Plus Core connects to the Novix-Plus peer-to-peer network to download and fully
validate blocks and transactions. It also includes a wallet and graphical user
interface, which can be optionally built.

Further information about Novix-Plus Core is available in the [doc folder](/doc).

License
-------

Novix-Plus Core is released under the terms of the MIT license. See [COPYING](COPYING) for more
information or see https://opensour
...

✅ hebasto closed a pull request: "Novix Plus"
(https://github.com/bitcoin/bitcoin/pull/28990)

📝 hebasto locked a pull request: "."
(https://github.com/bitcoin/bitcoin/pull/28990)
What is Novix-Plus Core?
---------------------

Novix-Plus Core connects to the Novix-Plus peer-to-peer network to download and fully
validate blocks and transactions. It also includes a wallet and graphical user
interface, which can be optionally built.

Further information about Novix-Plus Core is available in the [doc folder](/doc).

License
-------

Novix-Plus Core is released under the terms of the MIT license. See [COPYING](COPYING) for more
information or see https://opensour
...

💬 pablomartin4btc commented on pull request "cli: improve error message on multiwallet and add validation to cli-side commands":
(https://github.com/bitcoin/bitcoin/pull/26990#discussion_r1413211901)
Thanks, there was an extra space as well.

💬 pablomartin4btc commented on pull request "cli: improve error message on multiwallet and add validation to cli-side commands":
(https://github.com/bitcoin/bitcoin/pull/26990#discussion_r1413211918)
Right, thanks!

💬 pablomartin4btc commented on pull request "cli: improve error message on multiwallet and add validation to cli-side commands":
(https://github.com/bitcoin/bitcoin/pull/26990#discussion_r1413211927)
I'd prefer to keep the definition as is since the function is called only once, thanks for the suggestion.

💬 pablomartin4btc commented on pull request "cli: improve error message on multiwallet and add validation to cli-side commands":
(https://github.com/bitcoin/bitcoin/pull/26990#discussion_r1413211937)
Yeah, your version is clearer. Thanks!

💬 pablomartin4btc commented on pull request "cli: improve error message on multiwallet and add validation to cli-side commands":
(https://github.com/bitcoin/bitcoin/pull/26990#discussion_r1413211947)
Thanks, also removed the following line and tweaked the return statement.

📝 BoyManWamen opened a pull request: "Create bitcoin.txt"
(https://github.com/bitcoin/bitcoin/pull/28991)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

✅ BoyManWamen closed a pull request: "Create bitcoin.txt"
(https://github.com/bitcoin/bitcoin/pull/28991)

📝 fanquake locked a pull request: "Create bitcoin.txt"
(https://github.com/bitcoin/bitcoin/pull/28991)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

💬 pablomartin4btc commented on pull request "cli: improve error message on multiwallet and add validation to cli-side commands":
(https://github.com/bitcoin/bitcoin/pull/26990#issuecomment-1837610357)
Updates: addressed @andrewtoth's feedback, thanks again!

💬 andrewtoth commented on pull request "cli: improve error message on multiwallet and add validation to cli-side commands":
(https://github.com/bitcoin/bitcoin/pull/26990#discussion_r1413214496)
Sorry, not sure what you mean here. It looks to me like this function is called for every argument passed to bitcoin-cli, and therefore this set will be initialized for every argument instead of just once.

💬 pablomartin4btc commented on pull request "cli: improve error message on multiwallet and add validation to cli-side commands":
(https://github.com/bitcoin/bitcoin/pull/26990#discussion_r1413216635)
Right, sorry, I haven't expressed myself correctly, I meant that the validation was only "used" once but you are right, the `IsExclusivelyCliCommand` function is called for every argument passed to `bitcoin-cli`, still, `static` would keep the set throughout the lifetime of the program.