:lock: fanquake locked an issue: "> In file included from ../dist/./../cxx/cxx_db.cpp:13:"
(https://github.com/bitcoin/bitcoin/issues/28982)

💬 fanquake commented on pull request "build: disable external-signer for Windows":
(https://github.com/bitcoin/bitcoin/pull/28967#issuecomment-1835873829)
> and drop boost-process from vcpkg.json.

Added.

👍 hebasto approved a pull request: "build: disable external-signer for Windows"
(https://github.com/bitcoin/bitcoin/pull/28967#pullrequestreview-1759532758)
re-ACK 308aec3e5655327d98e0428d8205d246f24d6af5.

💬 willcl-ark commented on pull request "rpc: keep `.cookie` file if it was not generated":
(https://github.com/bitcoin/bitcoin/pull/28784#issuecomment-1835934522)
re-ACK 7cb9367157eb42ee06bc6fa024522cc14a80138d

💬 maflcko commented on pull request "bugfix: Make `CCheckQueue` RAII-styled (attempt 2)":
(https://github.com/bitcoin/bitcoin/pull/26762#discussion_r1411992509)
This is a change in behavior for the test in 9cf89f7a5b81197e38f58b24be0793b28fe41477?

💬 maflcko commented on pull request "bugfix: Make `CCheckQueue` RAII-styled (attempt 2)":
(https://github.com/bitcoin/bitcoin/pull/26762#discussion_r1411998596)
5b3ea5fa2e7f6dc1c9161ed8b74c9be4bd1e92dd: Comment is now wrong, no?

🤔 maflcko reviewed a pull request: "bugfix: Make `CCheckQueue` RAII-styled (attempt 2)"
(https://github.com/bitcoin/bitcoin/pull/26762#pullrequestreview-1759638398)
lgtm

📝 Sjors opened a pull request: "Stratum v2 Template Provider (take 2)"
(https://github.com/bitcoin/bitcoin/pull/28983)
Based on on @Fi3's https://github.com/bitcoin/bitcoin/compare/master...Fi3:bitcoin:PatchTemplates which is based on @ccdle12's #27854. I rebased it and re-wrote the commit history. See the original branch for the evolution of the spec.

The Stratum v2 [spec](https://github.com/stratum-mining/sv2-spec) describes various roles, but for Bitcoin Core the role of the [Template Provider](https://github.com/stratum-mining/sv2-spec/blob/main/07-Template-Distribution-Protocol.md) is the most interestin
...

💬 Sjors commented on pull request "[WIP] add a stratum v2 template provider":
(https://github.com/bitcoin/bitcoin/pull/27854#issuecomment-1835979687)
Happy to leave this open for a bit, but here's my PR: #28983

🤔 BrandonOdiwuor reviewed a pull request: "wallet: Fix migration of blank wallets"
(https://github.com/bitcoin/bitcoin/pull/28976#pullrequestreview-1759651852)
Concept ACK

Evaluating descriptor wallets using descriptor wallet flag instead of the presence of LegacyScriptPubKeyMan when migrating wallets

👍 TheCharlatan approved a pull request: "build: disable external-signer for Windows"
(https://github.com/bitcoin/bitcoin/pull/28967#pullrequestreview-1759657432)
ACK 308aec3e5655327d98e0428d8205d246f24d6af5

💬 willcl-ark commented on pull request "init: don't delete PID file if it was not generated":
(https://github.com/bitcoin/bitcoin/pull/28946#issuecomment-1835990929)
@stickies-v took most of your suggestions in 82f18e907a2af5a47e805861234de4672ed6d801

🤔 maflcko reviewed a pull request: "POC: Replace Boost.Process with cpp-subprocess"
(https://github.com/bitcoin/bitcoin/pull/28981#pullrequestreview-1759731506)
I guess the compile error is due to subprocess requiring C++17 and not allowing C++20 (or later)?

💬 maflcko commented on pull request "POC: Replace Boost.Process with cpp-subprocess":
(https://github.com/bitcoin/bitcoin/pull/28981#discussion_r1412055174)
nit: Could split this into one-per-line to avoid overly long lines, diffs and reduce merge conflicts?

💬 vasild commented on pull request "test: add end-to-end tests for CConnman and PeerManager":
(https://github.com/bitcoin/bitcoin/pull/26812#issuecomment-1836094254)
`0858b0c084...8b10990aa0`: rebase due to conflicts

💬 kashifs commented on pull request "rpc,rest,zmq: faster getblock, NotifyBlock and rest_block by reading raw block":
(https://github.com/bitcoin/bitcoin/pull/26415#issuecomment-1836097643)
@andrewtoth, that worked! It was an issue with RPC credentials. Now all my testing leads to results similar to yours. Thanks again, for all of your help with this.

💬 vasild commented on pull request "ci: run test_bitcoin with DEBUG_LOG_OUT in RUN_UNIT_TESTS_SEQUENTIAL":
(https://github.com/bitcoin/bitcoin/pull/28736#issuecomment-1836105479)
`e3ade1fbc1...2b7888ec3e`: rebase due to conflicts and add the `ed` package to `CI_BASE_PACKAGES` (see https://github.com/bitcoin/bitcoin/pull/28736#discussion_r1409360652).

💬 vasild commented on pull request "ci: run test_bitcoin with DEBUG_LOG_OUT in RUN_UNIT_TESTS_SEQUENTIAL":
(https://github.com/bitcoin/bitcoin/pull/28736#discussion_r1412093722)
Dropped `TEST_RUNNER_ENV` now that https://github.com/bitcoin/bitcoin/pull/28954 removed it from everywhere.

💬 vasild commented on pull request "ci: run test_bitcoin with DEBUG_LOG_OUT in RUN_UNIT_TESTS_SEQUENTIAL":
(https://github.com/bitcoin/bitcoin/pull/28736#discussion_r1412094023)
Added to `CI_BASE_PACKAGES` in latest push.

💬 fanquake commented on pull request "POC: Replace Boost.Process with cpp-subprocess":
(https://github.com/bitcoin/bitcoin/pull/28981#discussion_r1412108239)
Probably easier to just fix the typos, than add more things for linters to exclude? No new ones should be introduced.

💬 fanquake commented on pull request "POC: Replace Boost.Process with cpp-subprocess":
(https://github.com/bitcoin/bitcoin/pull/28981#issuecomment-1836129909)
Concept ACK on removing Boost Process. Is the plan to also delete any unused code from this header? I don't think copy-pasting dead/untested code into this repository is a good idea, and only serves to complicate review, and potentially cause issues in future (it maybe already doesn't work with c++20?)