💬 ismaelsadeeq commented on pull request "Fee Estimator updates from Validation Interface/CScheduler thread":
(https://github.com/bitcoin/bitcoin/pull/28368#discussion_r1401835680)
Fixed Thanks

🚀 hebasto merged a pull request: "ci: Update apt cache"
(https://github.com/bitcoin/bitcoin/pull/28925)

💬 ismaelsadeeq commented on pull request "Fee Estimator updates from Validation Interface/CScheduler thread":
(https://github.com/bitcoin/bitcoin/pull/28368#issuecomment-1822539544)
Thanks for your review @TheCharlatan
Update from 969f5ec to 91504cb
[Compare 969f5ec to 91504cb](https://github.com/bitcoin/bitcoin/compare/969f5ec4a8f823e593bb71cf59c523c49774f069..91504cbe0de2b74ef1aa2709761aaf0597ec66a2)
* Using explicit constructors and list initialization for `NewMempoolTransactionInfo` and `RemovedMempoolTransactionInfo` struct
* Removed redundant `boolean` argument in `CBlockPolicyEstimator::removeTx`
* Removed unused argument names in the overridden interface `CVa
...

💬 fanquake commented on pull request "ci: Avoid toolset ambiguity that MSVC can't handle":
(https://github.com/bitcoin/bitcoin/pull/28905#issuecomment-1822571419)
Do we know why this broke again? I guess this is something we'll just have to maintain forever? That's a shame, because it also adds ~30% runtime to this CI job.

💬 fanquake commented on pull request "ci: Update apt cache":
(https://github.com/bitcoin/bitcoin/pull/28925#issuecomment-1822573088)
Would have been good to link-to/explain the failures here. Nothing in the PR description or commit messages about what broke, or why this is the fix.

✅ fanquake closed an issue: "RAM usage regression in 26.x and master on ARM 32-bit"
(https://github.com/bitcoin/bitcoin/issues/28906)

🚀 fanquake merged a pull request: "coins: make sure PoolAllocator uses the correct alignment"
(https://github.com/bitcoin/bitcoin/pull/28913)

🚀 fanquake merged a pull request: "test: fix `AddNode` unit test failure on OpenBSD"
(https://github.com/bitcoin/bitcoin/pull/28891)

💬 hebasto commented on pull request "ci: Update apt cache":
(https://github.com/bitcoin/bitcoin/pull/28925#issuecomment-1822586677)
> Would have been good to link-to/explain the failures here. Nothing in the PR description or commit messages about what broke, or why this is the fix.

A self-explaining excerpt from a build log has been added to the PR description.

🚀 fanquake merged a pull request: "Drop CAutoFile"
(https://github.com/bitcoin/bitcoin/pull/28904)

💬 hebasto commented on pull request "ci: Avoid toolset ambiguity that MSVC can't handle":
(https://github.com/bitcoin/bitcoin/pull/28905#issuecomment-1822593954)
> Do we know why this broke again?

The underlying [issue](https://developercommunity.visualstudio.com/t/MicrosoftVCToolsVersionv143defaulttx/10041951) is labeled "Under Investigation".

> I guess this is something we'll just have to maintain forever?

Or until Microsoft fixes the issue.

> That's a shame, because it also adds ~30% runtime to this CI job.

I agree with you.

💬 fanquake commented on pull request "test: fix `AddNode` unit test failure on OpenBSD":
(https://github.com/bitcoin/bitcoin/pull/28891#issuecomment-1822597668)
This code isn't in 26.x. So removed the backport label and milestone for now.

💬 fanquake commented on pull request "coins: make sure PoolAllocator uses the correct alignment":
(https://github.com/bitcoin/bitcoin/pull/28913#issuecomment-1822601800)
Will be backported in #28872.

💬 fanquake commented on pull request "ci: Update apt cache":
(https://github.com/bitcoin/bitcoin/pull/28925#issuecomment-1822604793)
Will be backported in #28872.

💬 fanquake commented on pull request "[26.x] Final Changes":
(https://github.com/bitcoin/bitcoin/pull/28872#discussion_r1401916649)
Sure. Added to the next push.

💬 hebasto commented on pull request "[26.x] Changes for rc3":
(https://github.com/bitcoin/bitcoin/pull/28872#issuecomment-1822617995)
Suggesting to backport https://github.com/bitcoin/bitcoin/pull/28905 as well to ensure CI pass.

🚀 fanquake merged a pull request: "p2p: do not make automatic outbound connections to addnode peers"
(https://github.com/bitcoin/bitcoin/pull/28895)

🚀 fanquake merged a pull request: "depends: bump libmultiprocess to fix capnproto deprecation warnings"
(https://github.com/bitcoin/bitcoin/pull/28907)

💬 ajtowns commented on pull request "Use serialization parameters for CTransaction":
(https://github.com/bitcoin/bitcoin/pull/28438#discussion_r1401931286)
If the issue is the separation between the `CNetAddr::SerParams` declaration and the `MultiSerParams(..,CNetAddr::V2,..)` use, could instead make it:

```c++
class MultiSerParam
{
public:
template<typename T>
operator T&() const { return T::GetIPCSerParams(); }
};
constexpr MultiSerParam INTERNAL_SER_PARAMS;

class CNetAddr {
struct SerParams {
const Encoding enc;
static SerParams GetIPCSerParams() { return {Encoding::V2}; }
SER_PARAMS_OPFUNC

...

💬 fanquake commented on pull request "ci: Avoid toolset ambiguity that MSVC can't handle":
(https://github.com/bitcoin/bitcoin/pull/28905#issuecomment-1822634582)
Added to #28872 for backporting.

💬 fanquake commented on pull request "p2p: do not make automatic outbound connections to addnode peers":
(https://github.com/bitcoin/bitcoin/pull/28895#issuecomment-1822635615)
Added the fix to #28872 for backporting.