💬 toolsopen commented on issue "sendrawtransaction takes too long":
(https://github.com/bitcoin/bitcoin/issues/28745#issuecomment-1820860736)
This proves that it would be a very good way if bitcoind can self-isolate expired transactions.

💬 dergoegge commented on pull request "multiprocess: Add basic type conversion hooks":
(https://github.com/bitcoin/bitcoin/pull/28921#discussion_r1400551468)
This type of interface where we pass serialized objects (using our serialization) via capnp data obviously fits in quite well with our code base, but I am wondering if this is a nice design for external use? since now anybody using it needs capnp and our serialization format.

I might have missed prior discussion on this, is the plan to gradually convert more of the interface to native capnp types?

---

I really like this conversion glue by the way (i.e. `$Proxy.wrap`, etc.)! I've been wo
...

💬 willcl-ark commented on issue "sendrawtransaction takes too long":
(https://github.com/bitcoin/bitcoin/issues/28745#issuecomment-1820870785)
Thanks for the update. Wallet performance is something that's being continually worked on.

Did you end up upgrading versions (too), or still running on V22?

💬 maflcko commented on pull request "Use Txid in COutpoint":
(https://github.com/bitcoin/bitcoin/pull/28922#discussion_r1400560913)
Not sure about using those casts here. Why not use the safe `UCharCast` wrapper?

💬 maflcko commented on pull request "Use Txid in COutpoint":
(https://github.com/bitcoin/bitcoin/pull/28922#discussion_r1400558256)
```suggestion
return std::tie(a.hash, a.n) < std::tie(b.hash, b.n);
```

nit: This should compile, is shorter, and is recommended in https://en.cppreference.com/w/cpp/language/operators#Comparison_operators

💬 maflcko commented on pull request "Use Txid in COutpoint":
(https://github.com/bitcoin/bitcoin/pull/28922#discussion_r1400564594)
Could just use `Finalize(UCharCast(outpoints[i].hash.data())`?

💬 maflcko commented on pull request "Use Txid in COutpoint":
(https://github.com/bitcoin/bitcoin/pull/28922#discussion_r1400566592)
Why not string_view?

💬 dergoegge commented on pull request "Use Txid in COutpoint":
(https://github.com/bitcoin/bitcoin/pull/28922#discussion_r1400573342)
I think I'd prefer to keep `data` const. I don't think there is any good reason to support mutating a txid.

💬 maflcko commented on pull request "Use Txid in COutpoint":
(https://github.com/bitcoin/bitcoin/pull/28922#discussion_r1400575685)
Ah yes, I missed that it was `const`.

💬 maflcko commented on issue "sendrawtransaction takes too long":
(https://github.com/bitcoin/bitcoin/issues/28745#issuecomment-1820902220)
Assuming this is a bdb wallet (can be checked via `getwalletinfo()[format]`), I don't think it is worth to spend time on optimizing the code, given that it will be removed in the future.

💬 dergoegge commented on pull request "Use Txid in COutpoint":
(https://github.com/bitcoin/bitcoin/pull/28922#discussion_r1400584787)
This is great, thanks!

💬 dergoegge commented on pull request "Use Txid in COutpoint":
(https://github.com/bitcoin/bitcoin/pull/28922#discussion_r1400585133)
Done

💬 dergoegge commented on pull request "Use Txid in COutpoint":
(https://github.com/bitcoin/bitcoin/pull/28922#discussion_r1400585160)
Done

👍 Sjors approved a pull request: "Use Txid in COutpoint"
(https://github.com/bitcoin/bitcoin/pull/28922#pullrequestreview-1741957469)
ACK 9e58c5bcd96e7ff2062274868814ccae0626589e

💬 Sjors commented on pull request "Use Txid in COutpoint":
(https://github.com/bitcoin/bitcoin/pull/28922#discussion_r1400576119)
(Followup) should check that the hex string is of the correct length

💬 Sjors commented on pull request "Use Txid in COutpoint":
(https://github.com/bitcoin/bitcoin/pull/28922#discussion_r1400582914)
(Followup) should check length

💬 Sjors commented on pull request "Use Txid in COutpoint":
(https://github.com/bitcoin/bitcoin/pull/28922#discussion_r1400588522)
This seems unrelated?

💬 Sjors commented on pull request "Use Txid in COutpoint":
(https://github.com/bitcoin/bitcoin/pull/28922#discussion_r1400590151)
(Followup) should check length

💬 Sjors commented on pull request "Use Txid in COutpoint":
(https://github.com/bitcoin/bitcoin/pull/28922#discussion_r1400589011)
(Followup) should check length

💬 Sjors commented on pull request "Use Txid in COutpoint":
(https://github.com/bitcoin/bitcoin/pull/28922#discussion_r1400595687)
(Followup) should check length

💬 Sjors commented on pull request "Use Txid in COutpoint":
(https://github.com/bitcoin/bitcoin/pull/28922#discussion_r1400597309)
(Followup) should check length