💬 fanquake commented on pull request "RPC/Wallet: Add "use_txids" to output of getaddressinfo":
(https://github.com/bitcoin/bitcoin/pull/22693#issuecomment-1447943334)
Drafted for now. Feedback/comments needs addressing, needs rebase, PR description needs updating to mention the new related PR (#15987 is closed).

💬 fanquake commented on pull request "util: improve FindByte() performance":
(https://github.com/bitcoin/bitcoin/pull/19690#issuecomment-1447948999)
What are the next steps here? Anyone want to look into why this is apparently a performance degredation for ARM macOS? Maybe @john-moffett?

🚀 fanquake merged a pull request: "init: Return ChainstateLoadStatus::INTERRUPTED when verification was interrupted."
(https://github.com/bitcoin/bitcoin/pull/27157)

📝 fanquake opened a pull request: "valgrind: remove libsecp256k1 suppression"
(https://github.com/bitcoin/bitcoin/pull/27173)
I am no-longer been able to recreate this issue, atleast after the most recent libsecp256k1 changes. Can someone else confirm?

👍 willcl-ark approved a pull request: "refactor: Stop using gArgs global in system.cpp"
(https://github.com/bitcoin/bitcoin/pull/27170)
tACK 9a9d5da11

Tidy changes to remove the last references to global `gArgs` from util/system.cpp (besides the global declaration).

📝 glozow opened a pull request: "[ci] bump lint task to lunar for git v2.38"
(https://github.com/bitcoin/bitcoin/pull/27174)
Since 5497c14, verify-commits.py uses `git merge-tree` which requires git v2.38 or later. Fix the lint jobs on master (e.g. https://cirrus-ci.com/task/4971007513985024).

🤔 furszy requested changes to a pull request: "Mask values on Transactions View"
(https://github.com/bitcoin-core/gui/pull/708)
Need to adapt `BitcoinUnits::formatWithPrivacy` function to accept negative amounts. Otherwise, when the wallet make a send, the assertion crashes the software.

💬 fanquake commented on pull request "build: Pointer Authentication and Branch Target Identification for aarch64 Linux (Guix)":
(https://github.com/bitcoin/bitcoin/pull/24123#issuecomment-1448075642)
Rebased past #27118.

👍 stickies-v approved a pull request: "refactor: Stop using gArgs global in system.cpp"
(https://github.com/bitcoin/bitcoin/pull/27170)
ACK 9a9d5da11

💬 stickies-v commented on pull request "refactor: Stop using gArgs global in system.cpp":
(https://github.com/bitcoin/bitcoin/pull/27170#discussion_r1119971107)
nit: Looks like this shouldn't have been called on `gArgs` regardless of this PR, perhaps useful to split out in separate commit? In the 3 callsites of `ArgsManager::ReadConfigFiles` I see, it is only called on `gArgs` anyway, so I don't see any actual behaviour change/potential bug because of it.

👍 hebasto approved a pull request: "[ci] bump lint task to lunar for git v2.38"
(https://github.com/bitcoin/bitcoin/pull/27174)
ACK 836720e366f61f23c7a56775e11d58890b002d75

💬 fanquake commented on pull request "guix: switch to some `minimal` versions of packages in our manifest":
(https://github.com/bitcoin/bitcoin/pull/27172#issuecomment-1448088251)
Updated to also switch to `cmake-minimal` in the macOS builds.

💬 MarcoFalke commented on pull request "[ci] bump lint task to lunar for git v2.38":
(https://github.com/bitcoin/bitcoin/pull/27174#discussion_r1119990351)
This will reach EOL in less than a year and thus fail CI tasks when the tag is deleted. What about using https://packages.debian.org/bookworm/git ?

💬 willcl-ark commented on pull request "Support JSON-RPC 2.0 when requested by client":
(https://github.com/bitcoin/bitcoin/pull/27101#issuecomment-1448101737)
Concept ACK.

Might be worth updating a few other things at the same time if you continue to move ahead:

* This comment: https://github.com/bitcoin/bitcoin/pull/27101/files#diff-188b88992c9e08a108e852e7f69a2c2c6569d4b1212c9d05c46fdfd7fcb778d7R21-R27
* [HelpExampleRPC()](https://github.com/bitcoin/bitcoin/blob/master/src/rpc/util.cpp#L157-L161) to json 2.0
* Could warrant a release note to document new behaviours when using json 2.0

💬 MarcoFalke commented on pull request "valgrind: remove libsecp256k1 suppression":
(https://github.com/bitcoin/bitcoin/pull/27173#issuecomment-1448107067)
Which OS did you try on? See also the header:

```
# Note that suppressions may depend on OS and/or library versions.
# Tested on:
# * aarch64 (Ubuntu 22.04 system libs, clang, without gui)
# * x86_64 (Ubuntu 22.04 system libs, clang, without gui)

💬 fanquake commented on pull request "valgrind: remove libsecp256k1 suppression":
(https://github.com/bitcoin/bitcoin/pull/27173#issuecomment-1448109053)
> Which OS did you try on?

x86_64 (Ubuntu 22.04

💬 furszy commented on pull request "index: blockfilter initial sync speedup, parallelize process":
(https://github.com/bitcoin/bitcoin/pull/26966#issuecomment-1448113513)
PR updated, most of it implementation has changed.

The news are:
1) Decreased ThreadSync `cs_main` lock contention.
2) Removed `CBlockIndex` access from the child indexes internals.
3) Implemented generic workers pool.
4) Introduced a last header cache for the Block Filter index. Avoiding disk reads on every new processed block.
5) Enabled parallel sync on the tx index.

Important Note:
The introduced workers pool spawned by the `-indexworkers` init arg is shared among all the enabled
...

📝 stickies-v opened a pull request: "docs: GetDataDirNet and GetDataDirBase don't create datadir"
(https://github.com/bitcoin/bitcoin/pull/27176)
Since #27073, the behaviour of GetDataDir changed to only return the datadir path, but not create it. This also changed the behaviour of GetDataDirNet and GetDataDirBase but the docs do not yet reflect that.

📝 brunoerg opened a pull request: "test: fix intermittent issue in `feature_bip68_sequence`"
(https://github.com/bitcoin/bitcoin/pull/27177)
Fixes #27129

Call `send_self_transfer` passing, in case of coinbase tx, a surely mature one to avoid `bad-txns-premature-spend-of-coinbase`.

💬 MarcoFalke commented on pull request "test: fix intermittent issue in `feature_bip68_sequence`":
(https://github.com/bitcoin/bitcoin/pull/27177#discussion_r1120032517)
I wonder if this can instead be fixed by making `get_utxo` not return immature coinbases by default?

💬 brunoerg commented on pull request "test: fix intermittent issue in `feature_bip68_sequence`":
(https://github.com/bitcoin/bitcoin/pull/27177#discussion_r1120034162)
It's a good idea, going to do it.