💬 dhruv commented on pull request "BIP324: Enable v2 P2P encrypted transport":
(https://github.com/bitcoin/bitcoin/pull/24545#issuecomment-1437814663)
Rebased.

💬 ishaanam commented on pull request "wallet: be able to specify a wallet name and passphrase to migratewallet":
(https://github.com/bitcoin/bitcoin/pull/26595#issuecomment-1437958492)
reACK 3e521b2eb13799e11866562cfda4dc0bd3f7d6b9

💬 TheCharlatan commented on pull request "depends: harden libevent":
(https://github.com/bitcoin/bitcoin/pull/27118#issuecomment-1437992443)
ACK ff4a73aea2b8346f48f75e1130a36749f70e9049

💬 hebasto commented on pull request "ci: A few fixes of `ccache` issues":
(https://github.com/bitcoin/bitcoin/pull/27084#issuecomment-1438041890)
@fanquake @MarcoFalke

> ... but this is blocked on at least an answer to this question: [#27084 (comment)](https://github.com/bitcoin/bitcoin/pull/27084#discussion_r1104757809).

I've dropped the first commit and faced some weird issues which I saw in #27083 before. Going to provide steps to reproduce that unwanted behavior.

Making this PR a draft for now.

📝 hebasto converted_to_draft a pull request: "ci: A few fixes of `ccache` issues"
(https://github.com/bitcoin/bitcoin/pull/27084)
Combined https://github.com/bitcoin/bitcoin/pull/27077 and https://github.com/bitcoin/bitcoin/pull/27083 for the sake of more representative testing.

The [second](https://cirrus-ci.com/build/5852404411793408) run looks promising:
- ["MSan"](https://cirrus-ci.com/task/4583485717872640) task -- 98.74 %
- ["ASan + LSan + UBSan + integer"](https://cirrus-ci.com/task/5146435671293952) task -- 100.0 %
- ["multiprocess"](https://cirrus-ci.com/task/4864960694583296) task -- 99.35 %
- ["macOS 13 n
...

💬 hebasto commented on pull request "ci: A few fixes of `ccache` issues":
(https://github.com/bitcoin/bitcoin/pull/27084#discussion_r1112720365)
https://github.com/bitcoin/bitcoin/pull/27084#issuecomment-1438041890

💬 S3RK commented on pull request "wallet: group outputs only once, decouple it from Coin Selection":
(https://github.com/bitcoin/bitcoin/pull/25806#issuecomment-1438070020)
Concept ACK. started review

💬 GregTonoski commented on issue "signrawtransactionwithkey command shouldn't output the "Witness program was passed an empty witness" error for a TapRoot transaction":
(https://github.com/bitcoin/bitcoin/issues/27017#issuecomment-1438085755)
> I could not replicate your success behaviour after importing the descriptor:

The success behaviour is different from the not-replicated one:

> Hint: **signrawtransactionwithwallet** works fine if preceded with the importdescriptors '[{"desc": "tr(cUTFbLPUaBAPmTKwjcDs4rWHUSEUbUBfkPMogrbTmQFnJA3vgrLE)#tdkpah70", "timestamp": "now"}]'

💬 MarcoFalke commented on issue "Bitcoin Core very slow sync":
(https://github.com/bitcoin/bitcoin/issues/27134#issuecomment-1438098095)
You may be hitting a stalling peer timeout.

Please check your debug.log for possible causes; Alternatively you can upload it here.

You can find the debug.log in your [data dir](https://github.com/bitcoin/bitcoin/blob/master/doc/files.md#data-directory-location).

Please be aware that the debug log might contain personally identifying information.

💬 MarcoFalke commented on pull request "ci: Cache more stuff in the ci images: msan, iwyu, pip, sdks":
(https://github.com/bitcoin/bitcoin/pull/27028#discussion_r1112775788)
Yes, they do the same thing, which is the same as `bash -c "..."` does. I think they should be removed eventually, but for now they aid reviewability (diff moved dimmed zebra)

💬 kouloumos commented on pull request "github: Switch to yaml issue templates":
(https://github.com/bitcoin/bitcoin/pull/27025#discussion_r1112770341)
I think that a good addition here could be some of the usual hints posted in bug investigation comments such as https://github.com/bitcoin/bitcoin/issues/27134#issuecomment-1438098095, which are:
> You can find the debug.log in your [data dir](https://github.com/bitcoin/bitcoin/blob/master/doc/files.md#data-directory-location).
Please be aware that the debug log might contain personally identifying information.

💬 kouloumos commented on pull request "github: Switch to yaml issue templates":
(https://github.com/bitcoin/bitcoin/pull/27025#discussion_r1112784698)
This could also help to avoid scenarios where thousands of lines of pasted logs make the issue harder to read.

💬 MarcoFalke commented on pull request "ci: Cache more stuff in the ci images: msan, iwyu, pip, sdks":
(https://github.com/bitcoin/bitcoin/pull/27028#discussion_r1112784966)
Added comment

💬 TheCharlatan commented on issue "`libbitcoinkernel`: Building `mingw-w64` dll's broken":
(https://github.com/bitcoin/bitcoin/issues/25008#issuecomment-1438134641)
> I believe that https://github.com/theuni/bitcoin/commit/9612f5f0f1e3295065dbd8a0e0f472f8f020bbd9 is the clean/proper fix for us for the issue. We don't want pthreads symbols exported, and that fixes the specific issue.

Also tested this. Has this been PR'ed?

💬 Sjors commented on pull request "doc: recommend brew install python@3.7 (minimum version)":
(https://github.com/bitcoin/bitcoin/pull/27130#issuecomment-1438172307)
@RandyMcMillan maybe make a separate issue about M1 not supporting Python 3.8 (I don't have one, so can't confirm). It's just one of many operating systems we support, but a lot of devs use it so it seems worth looking into.

💬 fanquake commented on pull request "doc: recommend brew install python@3.7 (minimum version)":
(https://github.com/bitcoin/bitcoin/pull/27130#issuecomment-1438183845)
Thanks, but there is no need to make an issue. There is nothing here that needs to be solved.

💬 glozow commented on pull request "github: Switch to yaml issue templates":
(https://github.com/bitcoin/bitcoin/pull/27025#discussion_r1112834694)
Agree this could be an optional "additional info about env or machine" as it could be irrelevant to the issue / confusing. (feel free to ignore as this is just me bikeshedding)

💬 glozow commented on pull request "rpc: Add a parameter to sendrawtransaction which sets a maximum value for unspendable outputs.":
(https://github.com/bitcoin/bitcoin/pull/25943#issuecomment-1438205837)
reACK 7013da07fbcddb04abae9759767a9419ab90444c

🤔 Sjors requested changes to a pull request: "rpc: make importaddress compatible with descriptors wallet"
(https://github.com/bitcoin/bitcoin/pull/27034)
> the legacy spkm creation only happens on blank non-descriptors wallets

I don't think this is true, but maybe I'm reading the code wrong.

💬 Sjors commented on pull request "rpc: make importaddress compatible with descriptors wallet":
(https://github.com/bitcoin/bitcoin/pull/27034#discussion_r1112863513)
Suggested alternative wording that avoids "scriptPubKey manager".

```
For descriptor wallets, this command only works if it has private keys disabled.
It will create a new descriptor/s. Otherwise, use \"importdescriptors\" instead.
```

💬 Sjors commented on pull request "rpc: make importaddress compatible with descriptors wallet":
(https://github.com/bitcoin/bitcoin/pull/27034#discussion_r1112863805)
This sentence can be dropped with my suggestion.