Bitcoin Core Github
43 subscribers
123K links
Download Telegram
💬 MarcoFalke commented on issue "error: timeout on transient error: Could not connect to the server 127.0.0.1:8333 (error code 1 - "EOF reached")":
(https://github.com/bitcoin/bitcoin/issues/27121#issuecomment-1437212818)
How reliably can you reproduce the issue, what are the steps to do so?
💬 RandyMcMillan commented on pull request "docs: add ramdisk guide for running tests on OSX":
(https://github.com/bitcoin/bitcoin/pull/27124#issuecomment-1437222729)
Concept ACK
💬 RandyMcMillan commented on pull request "script: add description for the functionality of each opcode":
(https://github.com/bitcoin/bitcoin/pull/27109#issuecomment-1437246550)
NIT

```bash
cd src/ && clang-format --lines 68:148 -i script/script.h
```

```c
diff --git a/src/script/script.h b/src/script/script.h
index 35211ff376..5143593029 100644
--- a/src/script/script.h
+++ b/src/script/script.h
@@ -66,17 +66,16 @@ std::vector<unsigned char> ToByteVector(const T& in)
}

/** Script opcodes */
-enum opcodetype
-{
-/**
- * Opcodes that take a true/false value will evaluate the following as false:
- * an empty vector
- * a vector (of any le
...
💬 pablomartin4btc commented on pull request "refactor: wallet, remove global 'ArgsManager' dependency":
(https://github.com/bitcoin/bitcoin/pull/26889#issuecomment-1437255798)
Found an [issue](https://github.com/bitcoin/bitcoin/issues/21005) where @MarcoFalke mentioned the need of removing gArgs from dfferent places and @ryanofsky's [comment](https://github.com/bitcoin-core/gui/pull/75#issuecomment-689675368) regarding the GUI specifically, which seem very interesting so I wanted to add the links here.
💬 Sjors commented on pull request "rpc: Use a FlatSigningProvider in decodescript to allow inferring descriptors for scripts larger than 520 bytes":
(https://github.com/bitcoin/bitcoin/pull/27113#issuecomment-1437266967)
Tested that the new test fails without this change.
🚀 fanquake merged a pull request: "test: fix test abort for high timeout values (and `--timeout-factor 0`)"
(https://github.com/bitcoin/bitcoin/pull/25950)
fanquake closed an issue: "p2p_disconnect_ban intermittent issue"
(https://github.com/bitcoin/bitcoin/issues/26808)
🚀 fanquake merged a pull request: "test: fix intermittent issue in `p2p_disconnect_ban`"
(https://github.com/bitcoin/bitcoin/pull/27128)
💬 RandyMcMillan commented on pull request "docs: add ramdisk guide for running tests on OSX":
(https://github.com/bitcoin/bitcoin/pull/27124#discussion_r1112159104)
agree with Sjors
⚠️ fanquake opened an issue: "failure in feature_bip68_sequence.py"
(https://github.com/bitcoin/bitcoin/issues/27129)
https://cirrus-ci.com/task/5552802257174528?logs=ci#L3998
```bash
node0 2023-02-16T16:55:28.505405Z [httpworker.3] [rpc/request.cpp:179] [parse] [rpc] ThreadRPCServer method=sendrawtransaction user=__cookie__
node0 2023-02-16T16:55:28.506156Z [httpworker.3] [txmempool.cpp:644] [check] [mempool] Checking mempool with 58 transactions and 123 inputs
test 2023-02-16T16:55:28.513000Z TestFramework (ERROR): JSONRPC error
Traceback (most recent call last):
...
🚀 fanquake merged a pull request: "build: use _FORTIFY_SOURCE=3"
(https://github.com/bitcoin/bitcoin/pull/27027)
💬 fanquake commented on pull request "depends: harden libevent":
(https://github.com/bitcoin/bitcoin/pull/27118#issuecomment-1437292856)
Rebased on top of #27027.
fanquake closed an issue: "decodescript miniscript functionality tops out at 520 bytes"
(https://github.com/bitcoin/bitcoin/issues/27111)
🚀 fanquake merged a pull request: "rpc: Use a FlatSigningProvider in decodescript to allow inferring descriptors for scripts larger than 520 bytes"
(https://github.com/bitcoin/bitcoin/pull/27113)
💬 MarcoFalke commented on issue "failure in feature_bip68_sequence.py":
(https://github.com/bitcoin/bitcoin/issues/27129#issuecomment-1437297559)
Maybe due to the miniwallet change?
💬 TheCharlatan commented on pull request "compat: move (win) S_* defines into bdb":
(https://github.com/bitcoin/bitcoin/pull/26832#issuecomment-1437302293)
I feel like I'm missing some context here. Why move these out of compat? There are also other symbols like `WSAEAGAIN` that are only used in one other file.
🚀 fanquake merged a pull request: "rpc: fix successful broadcast count in `submitpackage` error msg"
(https://github.com/bitcoin/bitcoin/pull/27127)
💬 fanquake commented on pull request "ci: A few fixes of `ccache` issues":
(https://github.com/bitcoin/bitcoin/pull/27084#issuecomment-1437320675)
Most of the changes here look straight forward enough, and clearly improve `ccache` usage, but this is blocked on at least an answer to this question: https://github.com/bitcoin/bitcoin/pull/27084#discussion_r1104757809.
📝 fanquake review_request_removed a pull request: "wallet: be able to specify a wallet name and passphrase to migratewallet"
(https://github.com/bitcoin/bitcoin/pull/26595)
`migratewallet` currently operates on wallets that are already loaded, however this is not necessarily required, and in the future, not possible once the legacy wallet is removed. So we need to also be able to give the wallet name to migrate.

Additionally, the passphrase is required when migrating a wallet. Since a wallet may not be loaded when we migrate, and as we currently unload wallets when migrating, we need the passphrase to be given to `migratewallet` in order to migrate encrypted wal
...
💬 fanquake commented on pull request "wallet: be able to specify a wallet name and passphrase to migratewallet":
(https://github.com/bitcoin/bitcoin/pull/26595#issuecomment-1437342993)
@pinheadmz review?
fanquake closed an issue: "every other change address is unused"
(https://github.com/bitcoin/bitcoin/issues/27051)