💬 S3RK commented on pull request "wallet, tests: Expand and test when the blank wallet flag should be un/set":
(https://github.com/bitcoin/bitcoin/pull/25634#issuecomment-1590636794)
reACK cdba23db353a1beff831ff4fc83d01ed64e8c2a9

Appreciate the perseverance in addressing all the comments and arriving at consensus. Thank for working on this.

💬 MarcoFalke commented on pull request "Raise on invalid -debug and -loglevel config options":
(https://github.com/bitcoin/bitcoin/pull/27632#discussion_r1229151830)
Any reason to remove the trailing dot? This will invalidate the translations and is inconsistent with the other Error messages in this pull?

📝 hebasto opened a pull request: "ci: Use latest `macos-ventura-xcode:14.3.1` image"
(https://github.com/bitcoin/bitcoin/pull/27881)
As documented: https://github.com/bitcoin/bitcoin/blob/427853ab49f610e971b73ea4cc1d5366747e52b1/.cirrus.yml#L339

Last time, the image was updated in https://github.com/bitcoin/bitcoin/pull/26388.

The `check_clang` script diff:
```diff
--- master
+++ pr
@@ -1,5 +1,5 @@
clang --version
-Apple clang version 14.0.0 (clang-1400.0.29.202)
-Target: arm64-apple-darwin22.1.0
+Apple clang version 14.0.3 (clang-1403.0.22.14.1)
+Target: arm64-apple-darwin22.5.0
Thread model: posix
-Instal
...

📝 MarcoFalke opened a pull request: "ci: Bump ARM task to debian:bookworm"
(https://github.com/bitcoin/bitcoin/pull/27882)
The task currently uses Debian 11 Bullseye, which will be EOL in ~2024-07, according to https://wiki.debian.org/DebianReleases#Production_Releases

So it would be good to bump either now or latest in 6 months.

Ideally the ARM CI task uses the version of GCC that guix uses to cross compile, which is currently GCC 10 and Debian Bookworm ships with GCC 12, so I'll leave this in draft for now. See also https://packages.debian.org/bookworm/gcc-arm-linux-gnueabihf

📝 MarcoFalke opened a pull request: "ci: Bump macOS cross task to ubuntu:jammy"
(https://github.com/bitcoin/bitcoin/pull/27883)
It shouldn't matter what underlying image is used for the task, because the compiler is fully provided by `./depends/`.

So just use the latest Ubuntu LTS, which is also most likely the OS that is used by people cross-compiling, if there are any at all.

💬 hebasto commented on pull request "ci: Bump macOS cross task to ubuntu:jammy":
(https://github.com/bitcoin/bitcoin/pull/27883#issuecomment-1590773020)
Concept ACK. I see no compelling reasons for _"Check that Focal can cross-compile to macos"_.

💬 MarcoFalke commented on issue "arm64 CI failure":
(https://github.com/bitcoin/bitcoin/issues/27879#issuecomment-1590773880)
Aparently AWS was down yesterday? Maybe someone needs to turn a server off and on again to fix it?

💬 MarcoFalke commented on pull request "ci: Bump macOS cross task to ubuntu:jammy":
(https://github.com/bitcoin/bitcoin/pull/27883#issuecomment-1590779213)
> Concept ACK. I see no compelling reasons for "Check that Focal can cross-compile to macos".

It may have been a leftover from Gitian, before it was removed? See 5baff2b31840bdbc465f55b875aa6e9480288215

💬 hebasto commented on pull request "Disable and uncheck blank when private keys are disabled":
(https://github.com/bitcoin-core/gui/pull/739#issuecomment-1590829482)
Concept ACK.

💬 hebasto commented on pull request "Disable and uncheck blank when private keys are disabled":
(https://github.com/bitcoin-core/gui/pull/739#issuecomment-1590830348)
cc @furszy @ryanofsky @S3RK

💬 hebasto commented on pull request "Add menu option to migrate a wallet":
(https://github.com/bitcoin-core/gui/pull/738#issuecomment-1590837892)
Usually, we submit changes to non-`qt` subdirectory, i.e., the first commit of this PR, to the main repo, no?

💬 hebasto commented on pull request "Debug Console implementation of generate method":
(https://github.com/bitcoin-core/gui/pull/692#issuecomment-1590840776)
@hernanmarino Are you still working on this PR?

💬 MarcoFalke commented on pull request "Add menu option to migrate a wallet":
(https://github.com/bitcoin-core/gui/pull/738#issuecomment-1590849795)
> Usually, we submit changes to non-qt subdirectory, i.e., the first commit of this PR, to the main repo, no?

I don't think this rule applies to interface changes that only affect the gui. Otherwise, it just seems like extra work for reviewers and authors to artificially rip stuff apart for no good reason, with the extra risk of ending up merging just one ripped-off half, but not the other?

💬 hebasto commented on pull request "Add menu option to migrate a wallet":
(https://github.com/bitcoin-core/gui/pull/738#issuecomment-1590853447)
> > Usually, we submit changes to non-qt subdirectory, i.e., the first commit of this PR, to the main repo, no?
>
> I don't think this rule applies to interface changes that only affect the gui. Otherwise, it just seems like extra work for reviewers and authors to artificially rip stuff apart for no good reason, with the extra risk of ending up merging just one ripped-off half, but not the other?

I agree. It would be better to just document this case for further references.

💬 hebasto commented on pull request "Add menu option to migrate a wallet":
(https://github.com/bitcoin-core/gui/pull/738#issuecomment-1590853884)
Concept ACK.

💬 hebasto commented on pull request "Add menu option to migrate a wallet":
(https://github.com/bitcoin-core/gui/pull/738#issuecomment-1590855116)
cc @furszy @ryanofsky @S3RK

💬 darosior commented on pull request "descriptors: Be able to specify change and receiving in a single descriptor string":
(https://github.com/bitcoin/bitcoin/pull/22838#discussion_r1229363976)
Then let's at least document in `importdescriptors` and `importmulti` that for any multipath descriptor with 2 paths, the second will be imported as internal?

💬 darosior commented on pull request "descriptors: Be able to specify change and receiving in a single descriptor string":
(https://github.com/bitcoin/bitcoin/pull/22838#issuecomment-1590914023)
ACK 15db5e0c1c03a65db4ed5b9a400817bf96237590

CI jobs that are failing seem spurious ("Failed to start an instance! Failed to pull null image! Repository does not exist or may require authentication."), or https://github.com/bitcoin/bitcoin/issues/27879.

📝 MarcoFalke opened a pull request: " test: Use TestNode datadir_path or chain_path where possible"
(https://github.com/bitcoin/bitcoin/pull/27884)
It seems inconsistent, fragile and verbose to:

* Call `get_datadir_path` to recreate the path that already exists as field in TestNode
* Call `os.path.join` with the hardcoded chain name or `self.chain` to recreate the TestNode `chain_path` property
* Sometimes even use the hardcoded node dir name (`"node0"`)

Fix all issues by using the TestNode properties.

💬 fanquake commented on pull request "lint: suppress pip spam":
(https://github.com/bitcoin/bitcoin/pull/27871#discussion_r1229385348)
Just dropped the second commit for now.

💬 MarcoFalke commented on pull request "lint: suppress pip spam":
(https://github.com/bitcoin/bitcoin/pull/27871#discussion_r1229391879)
I don't think the warning is worth it to be ignored. There are hundreds of lines printed anyway for installing packages so removing one line, which is a warning doesn't seem too useful?

Again, if you want to print less lines, I think you can just combine the pip calls into one instead of doing this change.