💬 ariard commented on issue "Proposal for a new mempool design":
(https://github.com/bitcoin/bitcoin/issues/27677#issuecomment-1590309442)
> If I'm understanding your post correctly, you're asking whether the mempool design I'm proposing is consistent with having some sort of external-to-the-mempool cache of transactions? That really sounds like a p2p optimization and not a mempool issue, and I think there are a lot of questions you'd have to answer in designing such a cache, including how to make it DoS resistant so that an adversary can't overrun it, but fundamentally I don't think anything I'm proposing would make designing such
...

💬 ajtowns commented on pull request "Mempool: persist mempoolminfee accross restarts":
(https://github.com/bitcoin/bitcoin/pull/27859#discussion_r1228876400)
I guess as long as it's only set shortly after startup (while the mempool is still loading?), it's probably fine?

💬 ariard commented on pull request "[WIP] add a stratum v2 template provider":
(https://github.com/bitcoin/bitcoin/pull/27854#issuecomment-1590322328)
Over-turning my comment from https://github.com/bitcoin/bitcoin/pull/23049#issuecomment-925446441. After studying more Stratum V2 and the inner details of mining operations, and in light of more “reactive" block template construction in future in function of the processed mempool content, I think this more valuable to have Stratum V2 TP integrated in Bitcoin Core to enhance decentralization of the mining ecosystem. From a maintenance viewpoint, the changes are very “peripheral” from other subsys
...

⚠️ ajtowns opened an issue: "arm64 CI failure"
(https://github.com/bitcoin/bitcoin/issues/27879)
arm64 CI is failing with:

```
FAIL: minisketch/test
=====================

../build-aux/test-driver: line 109: ./minisketch/test: cannot execute binary file: Exec format error
FAIL minisketch/test (exit status: 126)

FAIL: univalue/test/object
==========================

../build-aux/test-driver: line 109: ./univalue/test/object: cannot execute binary file: Exec format error
FAIL univalue/test/object (exit status: 126)

FAIL: univalue/test/unitester
=============================
...

💬 ajtowns commented on issue "arm64 CI failure":
(https://github.com/bitcoin/bitcoin/issues/27879#issuecomment-1590348547)
Maybe worth adding `git show FETCH_HEAD` at the end of `base_template:` in `.cirrus.yml` so it's easier to see which version of master a CI run was merged against?

💬 jonatack commented on pull request "test: move remaining rand code from util/setup_common to util/random":
(https://github.com/bitcoin/bitcoin/pull/27425#issuecomment-1590352334)
Rebased for #27783 🐶

💬 jonatack commented on issue "arm64 CI failure":
(https://github.com/bitcoin/bitcoin/issues/27879#issuecomment-1590379661)
Saw this issue today on two pushes as well, #27425 and #27632.

💬 S3RK commented on pull request "wallet: Give deprecation warning when loading a legacy wallet":
(https://github.com/bitcoin/bitcoin/pull/27869#issuecomment-1590547815)
ACK 2bf7183ea9b42a9edf76bccdf00708341a1d2c0a

💬 MarcoFalke commented on issue "arm64 CI failure":
(https://github.com/bitcoin/bitcoin/issues/27879#issuecomment-1590596043)
> Maybe worth adding git show FETCH_HEAD at the end of base_template: in .cirrus.yml so it's easier to see which version of master a CI run was merged against?

I think you can check the output of `merge_base` to see what was used? For example, https://cirrus-ci.com/task/6628961686388736?logs=merge_base#L18


> or is an infrastructure issue (bad cache or bad hardware?).

Seems likely. Let's poke a bit...

📝 MarcoFalke opened a pull request: "ci: New ccache and docker image for arm task"
(https://github.com/bitcoin/bitcoin/pull/27880)
https://github.com/bitcoin/bitcoin/issues/27879

💬 ajtowns commented on issue "arm64 CI failure":
(https://github.com/bitcoin/bitcoin/issues/27879#issuecomment-1590608062)
> I think you can check the output of `merge_base` to see what was used? For example, https://cirrus-ci.com/task/6628961686388736?logs=merge_base#L18

I looked at that and somehow didn't see it. Weird.

💬 MarcoFalke commented on issue "arm64 CI failure":
(https://github.com/bitcoin/bitcoin/issues/27879#issuecomment-1590612318)
There is certainly something sketchy going on with the upstream hardware/software. I've had to reset the pre-build of the image thrice: https://cirrus-ci.com/task/4729934984249344. Also, once that passes, the actual build fails half the time with `curl: (35) OpenSSL SSL_connect: Connection reset by peer in connection to raw.githubusercontent.com:443 ` https://cirrus-ci.com/task/5920692756021248?logs=ci#L208

💬 hebasto commented on issue "arm64 CI failure":
(https://github.com/bitcoin/bitcoin/issues/27879#issuecomment-1590618772)
> There is certainly something sketchy going on with the upstream hardware/software. I've had to reset the pre-build of the image thrice: https://cirrus-ci.com/task/4729934984249344. Also, once that passes, the actual build fails half the time with `curl: (35) OpenSSL SSL_connect: Connection reset by peer in connection to raw.githubusercontent.com:443 ` https://cirrus-ci.com/task/5920692756021248?logs=ci#L208
>
>
>
>

@fkorotkov What do you think?

💬 S3RK commented on pull request "wallet: Have the wallet store the key for automatically generated descriptors":
(https://github.com/bitcoin/bitcoin/pull/26728#discussion_r1229134617)
Great catch! Should we also set if for watch only wallets? On line 4190?

💬 S3RK commented on pull request "wallet: Have the wallet store the key for automatically generated descriptors":
(https://github.com/bitcoin/bitcoin/pull/26728#issuecomment-1590624734)
reACK 24b3ee7ee9b4fd1fb6f07bb03676379b5e58d3ad

Two new commits added since last review to ensure `WALLET_FLAG_GLOBAL_HD_KEY` is set for all new and migrated descriptor wallets.

💬 S3RK commented on pull request "wallet, tests: Expand and test when the blank wallet flag should be un/set":
(https://github.com/bitcoin/bitcoin/pull/25634#issuecomment-1590636794)
reACK cdba23db353a1beff831ff4fc83d01ed64e8c2a9

Appreciate the perseverance in addressing all the comments and arriving at consensus. Thank for working on this.

💬 MarcoFalke commented on pull request "Raise on invalid -debug and -loglevel config options":
(https://github.com/bitcoin/bitcoin/pull/27632#discussion_r1229151830)
Any reason to remove the trailing dot? This will invalidate the translations and is inconsistent with the other Error messages in this pull?

📝 hebasto opened a pull request: "ci: Use latest `macos-ventura-xcode:14.3.1` image"
(https://github.com/bitcoin/bitcoin/pull/27881)
As documented: https://github.com/bitcoin/bitcoin/blob/427853ab49f610e971b73ea4cc1d5366747e52b1/.cirrus.yml#L339

Last time, the image was updated in https://github.com/bitcoin/bitcoin/pull/26388.

The `check_clang` script diff:
```diff
--- master
+++ pr
@@ -1,5 +1,5 @@
clang --version
-Apple clang version 14.0.0 (clang-1400.0.29.202)
-Target: arm64-apple-darwin22.1.0
+Apple clang version 14.0.3 (clang-1403.0.22.14.1)
+Target: arm64-apple-darwin22.5.0
Thread model: posix
-Instal
...

📝 MarcoFalke opened a pull request: "ci: Bump ARM task to debian:bookworm"
(https://github.com/bitcoin/bitcoin/pull/27882)
The task currently uses Debian 11 Bullseye, which will be EOL in ~2024-07, according to https://wiki.debian.org/DebianReleases#Production_Releases

So it would be good to bump either now or latest in 6 months.

Ideally the ARM CI task uses the version of GCC that guix uses to cross compile, which is currently GCC 10 and Debian Bookworm ships with GCC 12, so I'll leave this in draft for now. See also https://packages.debian.org/bookworm/gcc-arm-linux-gnueabihf

📝 MarcoFalke opened a pull request: "ci: Bump macOS cross task to ubuntu:jammy"
(https://github.com/bitcoin/bitcoin/pull/27883)
It shouldn't matter what underlying image is used for the task, because the compiler is fully provided by `./depends/`.

So just use the latest Ubuntu LTS, which is also most likely the OS that is used by people cross-compiling, if there are any at all.

💬 hebasto commented on pull request "ci: Bump macOS cross task to ubuntu:jammy":
(https://github.com/bitcoin/bitcoin/pull/27883#issuecomment-1590773020)
Concept ACK. I see no compelling reasons for _"Check that Focal can cross-compile to macos"_.