💬 TheCharlatan commented on pull request "build: make sure we can overwrite config.{guess,sub} before doing so":
(https://github.com/bitcoin/bitcoin/pull/27875#issuecomment-1589993008)
Concept ACK

💬 MarcoFalke commented on pull request "Add menu option to migrate a wallet":
(https://github.com/bitcoin-core/gui/pull/738#discussion_r1228705790)
```suggestion
return {std::move(out)}; // std::move to work around clang bug
```

No idea if this compiles or works around the clang bug, but I left a comment

💬 MarcoFalke commented on pull request "Deniability - a tool to automatically improve coin ownership privacy":
(https://github.com/bitcoin-core/gui/pull/733#issuecomment-1590038670)
Maybe mark as draft as long as it depends on the upstream changes?

💬 MarcoFalke commented on pull request "test: Add unit & functional test coverage for blockstore":
(https://github.com/bitcoin/bitcoin/pull/27850#discussion_r1228708244)
Ah ok, then maybe check `Error: A fatal internal error occurred, see debug.log for details` as error message to provide context for test readers?

💬 hebasto commented on pull request "test: handle failed `assert_equal()` assertions in bcc callback functions":
(https://github.com/bitcoin/bitcoin/pull/27831#issuecomment-1590058200)
I've tested this PR on the old [broken](https://github.com/bitcoin/bitcoin/commit/65e8adf80eaf9fd821793e00fed5a5c76845c8d5) variant of the #23962 using `TEST_RUNNER_EXTRA="--filter interface_usdt_mempool"`:

- w/o this PR:
```
stdout:
2023-06-12T14:55:58.610000Z TestFramework (INFO): PRNG seed is: 7368400044812499558
2023-06-12T14:55:58.611000Z TestFramework (INFO): Initializing test directory /tmp/cirrus-ci-build/ci/scratch/test_runner/test_runner_₿_🏃_20230612_145556/interface_usdt_mempo
...

💬 jonatack commented on pull request "Raise on invalid -debug and -loglevel config options":
(https://github.com/bitcoin/bitcoin/pull/27632#issuecomment-1590068863)
Updated with @ryanofsky's review feedback (thanks!) -- the CI failures look unrelated and perhaps require rebasing to current master.

💬 jonatack commented on pull request "Raise on invalid -debug and -loglevel config options":
(https://github.com/bitcoin/bitcoin/pull/27632#discussion_r1228733414)
The unit tests were touched for the `nodiscard` attribute. End-to-end functional tests seem to be the usual way we test for raising on an invalid config. I didn't look if they can be replaced by faster unit tests. Might be a follow-up if you're interested?

📝 denavila converted_to_draft a pull request: "Deniability - a tool to automatically improve coin ownership privacy"
(https://github.com/bitcoin-core/gui/pull/733)
This new feature is an implementation of the ideas in Paul Sztorc's blog post "Deniability - Unilateral Transaction Meta-Privacy"(https://www.truthcoin.info/blog/deniability/).

In short, the idea is to periodically split coins and send them to yourself, making it look like common "spend" transactions, such that blockchain ownership analysis becomes more difficult, and thus improving the user's privacy.

This is the GUI portion of the PR (bitcoin-core/gui). The core functionality PR ( https:
...

💬 fjahr commented on issue "Creating too many wallets exhausts file descriptor limit and leads to crash":
(https://github.com/bitcoin/bitcoin/issues/27732#issuecomment-1590076625)
> I can take this if still available.

Feel free to investigate, i am not working on this currently.

💬 denavila commented on pull request "Deniability - a tool to automatically improve coin ownership privacy":
(https://github.com/bitcoin-core/gui/pull/733#issuecomment-1590079466)
> Maybe mark as draft as long as it depends on the upstream changes?

I converted the PR to a draft. Thanks!

📝 Xekyo opened a pull request: "Add CoinGrinder coin selection algorithm"
(https://github.com/bitcoin/bitcoin/pull/27877)
Adds a coin selection algorithm that will deterministically search for the input set with minimum waste that produces a change output.

In the recent months we have seen some extreme feerates. So far, Bitcoin Core used a moderate approach to coin selection, where it would generate multiple input set candidates and pick the least wasteful, but not minimize the input set weight. We want to avoid always minimizing transaction weights as this causes a wallet’s UTXO pool to be ground to dust (pun i
...

💬 Dadudidas commented on pull request "test: (refactor) Use datadir from options in chainstatemanager test":
(https://github.com/bitcoin/bitcoin/pull/27876#issuecomment-1590141732)
Danke

💬 achow101 commented on pull request "Add menu option to migrate a wallet":
(https://github.com/bitcoin-core/gui/pull/738#discussion_r1228789796)
Done as suggested

💬 pinheadmz commented on pull request "test: Add unit & functional test coverage for blockstore":
(https://github.com/bitcoin/bitcoin/pull/27850#discussion_r1228823625)
done, thanks

📝 kevkevinpal opened a pull request: "test: refactoring test in rpc_generate.py"
(https://github.com/bitcoin/bitcoin/pull/27878)
There was a rpc assertation that only asserted part of the message. The
additional untested text (". Make sure the tx has at least one
input.") has been added

Line of code that this refactor is testing
https://github.com/bitcoin/bitcoin/blob/427853ab49f610e971b73ea4cc1d5366747e52b1/src/rpc/mining.cpp#L350

<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull reques
...

👍 furszy approved a pull request: "wallet: Migrate wallets that are not in a wallet dir"
(https://github.com/bitcoin/bitcoin/pull/26740#pullrequestreview-1478267729)
ACK a1e65382

💬 ariard commented on issue "Proposal for a new mempool design":
(https://github.com/bitcoin/bitcoin/issues/27677#issuecomment-1590309442)
> If I'm understanding your post correctly, you're asking whether the mempool design I'm proposing is consistent with having some sort of external-to-the-mempool cache of transactions? That really sounds like a p2p optimization and not a mempool issue, and I think there are a lot of questions you'd have to answer in designing such a cache, including how to make it DoS resistant so that an adversary can't overrun it, but fundamentally I don't think anything I'm proposing would make designing such
...

💬 ajtowns commented on pull request "Mempool: persist mempoolminfee accross restarts":
(https://github.com/bitcoin/bitcoin/pull/27859#discussion_r1228876400)
I guess as long as it's only set shortly after startup (while the mempool is still loading?), it's probably fine?

💬 ariard commented on pull request "[WIP] add a stratum v2 template provider":
(https://github.com/bitcoin/bitcoin/pull/27854#issuecomment-1590322328)
Over-turning my comment from https://github.com/bitcoin/bitcoin/pull/23049#issuecomment-925446441. After studying more Stratum V2 and the inner details of mining operations, and in light of more “reactive" block template construction in future in function of the processed mempool content, I think this more valuable to have Stratum V2 TP integrated in Bitcoin Core to enhance decentralization of the mining ecosystem. From a maintenance viewpoint, the changes are very “peripheral” from other subsys
...

⚠️ ajtowns opened an issue: "arm64 CI failure"
(https://github.com/bitcoin/bitcoin/issues/27879)
arm64 CI is failing with:

```
FAIL: minisketch/test
=====================

../build-aux/test-driver: line 109: ./minisketch/test: cannot execute binary file: Exec format error
FAIL minisketch/test (exit status: 126)

FAIL: univalue/test/object
==========================

../build-aux/test-driver: line 109: ./univalue/test/object: cannot execute binary file: Exec format error
FAIL univalue/test/object (exit status: 126)

FAIL: univalue/test/unitester
=============================
...

💬 ajtowns commented on issue "arm64 CI failure":
(https://github.com/bitcoin/bitcoin/issues/27879#issuecomment-1590348547)
Maybe worth adding `git show FETCH_HEAD` at the end of `base_template:` in `.cirrus.yml` so it's easier to see which version of master a CI run was merged against?