💬 glozow commented on pull request "Fee estimation: avoid serving stale fee estimate":
(https://github.com/bitcoin/bitcoin/pull/27622#discussion_r1225924258)
29814149f29ce1858ee3f6ea2fbd37ec411070d6
The comment from L33 seems to belong better above here. Also, please make doxygen compatible.

```suggestion
/** Whether to allow importing a fee_estimates file older than MAX_FILE_AGE */
const bool m_read_stale_estimates;
```

💬 glozow commented on pull request "Fee estimation: avoid serving stale fee estimate":
(https://github.com/bitcoin/bitcoin/pull/27622#discussion_r1225926128)
in efe5f373e12329104f1c706145eee75c2d2079a7

Is this 61 hours? Or 1 second past the 60hour mark?

👍 TheCharlatan approved a pull request: "validation: Stricter assumeutxo error handling when renaming chainstates"
(https://github.com/bitcoin/bitcoin/pull/27862#pullrequestreview-1477986292)
ACK 1ac09b93cdb41eb7dbc1a62364363e59507da1af

That windows build failure is weird though. How can there be a conflict between `std::format` and `tfm::format`, if we are only in the latter's namespace? Why is this only popping up now?

💬 achow101 commented on pull request "test: (refactor) Use datadir from options in chainstatemanager test":
(https://github.com/bitcoin/bitcoin/pull/27876#issuecomment-1589975135)
ACK d54819d74e04e6105c1f0362755f5bcfa845eefd

🚀 achow101 merged a pull request: "test: (refactor) Use datadir from options in chainstatemanager test"
(https://github.com/bitcoin/bitcoin/pull/27876)

💬 TheCharlatan commented on pull request "kernel: Add interrupt class":
(https://github.com/bitcoin/bitcoin/pull/27861#issuecomment-1589979443)
Updated 39d9b5144410c15385ee48bc886e0dea36f34b6a -> 315915b43082a4c43bec3ba8e826abc7280b6cbc ([kernelInterrupt_2](https://github.com/TheCharlatan/bitcoin/commits/kernelInterrupt_2) -> [kernelInterrupt_3](https://github.com/TheCharlatan/bitcoin/commits/kernelInterrupt_3), [compare](https://github.com/TheCharlatan/bitcoin/compare/kernelInterrupt_2..kernelInterrupt_3)).
* Adopted @ryanofsky's [suggestion](https://github.com/bitcoin/bitcoin/pull/27861#discussion_r1228439282), making `FatalErrorf` a
...

💬 TheCharlatan commented on pull request "build: make sure we can overwrite config.{guess,sub} before doing so":
(https://github.com/bitcoin/bitcoin/pull/27875#issuecomment-1589993008)
Concept ACK

💬 MarcoFalke commented on pull request "Add menu option to migrate a wallet":
(https://github.com/bitcoin-core/gui/pull/738#discussion_r1228705790)
```suggestion
return {std::move(out)}; // std::move to work around clang bug
```

No idea if this compiles or works around the clang bug, but I left a comment

💬 MarcoFalke commented on pull request "Deniability - a tool to automatically improve coin ownership privacy":
(https://github.com/bitcoin-core/gui/pull/733#issuecomment-1590038670)
Maybe mark as draft as long as it depends on the upstream changes?

💬 MarcoFalke commented on pull request "test: Add unit & functional test coverage for blockstore":
(https://github.com/bitcoin/bitcoin/pull/27850#discussion_r1228708244)
Ah ok, then maybe check `Error: A fatal internal error occurred, see debug.log for details` as error message to provide context for test readers?

💬 hebasto commented on pull request "test: handle failed `assert_equal()` assertions in bcc callback functions":
(https://github.com/bitcoin/bitcoin/pull/27831#issuecomment-1590058200)
I've tested this PR on the old [broken](https://github.com/bitcoin/bitcoin/commit/65e8adf80eaf9fd821793e00fed5a5c76845c8d5) variant of the #23962 using `TEST_RUNNER_EXTRA="--filter interface_usdt_mempool"`:

- w/o this PR:
```
stdout:
2023-06-12T14:55:58.610000Z TestFramework (INFO): PRNG seed is: 7368400044812499558
2023-06-12T14:55:58.611000Z TestFramework (INFO): Initializing test directory /tmp/cirrus-ci-build/ci/scratch/test_runner/test_runner_₿_🏃_20230612_145556/interface_usdt_mempo
...

💬 jonatack commented on pull request "Raise on invalid -debug and -loglevel config options":
(https://github.com/bitcoin/bitcoin/pull/27632#issuecomment-1590068863)
Updated with @ryanofsky's review feedback (thanks!) -- the CI failures look unrelated and perhaps require rebasing to current master.

💬 jonatack commented on pull request "Raise on invalid -debug and -loglevel config options":
(https://github.com/bitcoin/bitcoin/pull/27632#discussion_r1228733414)
The unit tests were touched for the `nodiscard` attribute. End-to-end functional tests seem to be the usual way we test for raising on an invalid config. I didn't look if they can be replaced by faster unit tests. Might be a follow-up if you're interested?

📝 denavila converted_to_draft a pull request: "Deniability - a tool to automatically improve coin ownership privacy"
(https://github.com/bitcoin-core/gui/pull/733)
This new feature is an implementation of the ideas in Paul Sztorc's blog post "Deniability - Unilateral Transaction Meta-Privacy"(https://www.truthcoin.info/blog/deniability/).

In short, the idea is to periodically split coins and send them to yourself, making it look like common "spend" transactions, such that blockchain ownership analysis becomes more difficult, and thus improving the user's privacy.

This is the GUI portion of the PR (bitcoin-core/gui). The core functionality PR ( https:
...

💬 fjahr commented on issue "Creating too many wallets exhausts file descriptor limit and leads to crash":
(https://github.com/bitcoin/bitcoin/issues/27732#issuecomment-1590076625)
> I can take this if still available.

Feel free to investigate, i am not working on this currently.

💬 denavila commented on pull request "Deniability - a tool to automatically improve coin ownership privacy":
(https://github.com/bitcoin-core/gui/pull/733#issuecomment-1590079466)
> Maybe mark as draft as long as it depends on the upstream changes?

I converted the PR to a draft. Thanks!

📝 Xekyo opened a pull request: "Add CoinGrinder coin selection algorithm"
(https://github.com/bitcoin/bitcoin/pull/27877)
Adds a coin selection algorithm that will deterministically search for the input set with minimum waste that produces a change output.

In the recent months we have seen some extreme feerates. So far, Bitcoin Core used a moderate approach to coin selection, where it would generate multiple input set candidates and pick the least wasteful, but not minimize the input set weight. We want to avoid always minimizing transaction weights as this causes a wallet’s UTXO pool to be ground to dust (pun i
...

💬 Dadudidas commented on pull request "test: (refactor) Use datadir from options in chainstatemanager test":
(https://github.com/bitcoin/bitcoin/pull/27876#issuecomment-1590141732)
Danke

💬 achow101 commented on pull request "Add menu option to migrate a wallet":
(https://github.com/bitcoin-core/gui/pull/738#discussion_r1228789796)
Done as suggested

💬 pinheadmz commented on pull request "test: Add unit & functional test coverage for blockstore":
(https://github.com/bitcoin/bitcoin/pull/27850#discussion_r1228823625)
done, thanks

📝 kevkevinpal opened a pull request: "test: refactoring test in rpc_generate.py"
(https://github.com/bitcoin/bitcoin/pull/27878)
There was a rpc assertation that only asserted part of the message. The
additional untested text (". Make sure the tx has at least one
input.") has been added

Line of code that this refactor is testing
https://github.com/bitcoin/bitcoin/blob/427853ab49f610e971b73ea4cc1d5366747e52b1/src/rpc/mining.cpp#L350

<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull reques
...