💬 codo1 commented on pull request "Modernize rpcauth.py":
(https://github.com/bitcoin/bitcoin/pull/27081#issuecomment-1430354052)
> @codo1 If this comment can be helpful

It is. Thank you. Part of the docs you link to deserve a re-read by me.

💬 willcl-ark commented on issue "Stop the GPG verification madness":
(https://github.com/bitcoin/bitcoin/issues/25395#issuecomment-1430357235)
@AdmiralNeo did you already try following the instructions found on https://bitcoincore.org/en/download/ if so, where abouts did you get stuck?

If your question is specifically about how to find a key to import into GPG (to use for trust), then the answer is a little less clear, but there is still some guidance on the website:

> You can find many developer keys listed in the [bitcoin/bitcoin repository](https://github.com/bitcoin/bitcoin/tree/master/contrib/builder-keys), which you can the
...

💬 RandyMcMillan commented on pull request "build: produce a .zip for macOS distribution":
(https://github.com/bitcoin/bitcoin/pull/27099#issuecomment-1430371140)
Concept ACK

tested on macOS 12.6.1 (21G217)

💬 AdmiralNeo commented on issue "Stop the GPG verification madness":
(https://github.com/bitcoin/bitcoin/issues/25395#issuecomment-1430376573)
THX for your answer. I could load that key and somehow I guess he signed my downloaded Bitcoin Core program. But I am not able to start the program with the name "bitcoin-24.0.1-x86_64-apple-darwin.dmg". Must be a basic error of me as I am not a dev and using a terminal is already a big achievement for me, lol <img width="908" alt="Bildschirmfoto 2023-02-14 um 22 01 41" src="https://user-images.githubusercontent.com/125405780/218862325-81145c83-21f9-4d67-a712-1a18ce5f3537.png">

💬 willcl-ark commented on issue "Stop the GPG verification madness":
(https://github.com/bitcoin/bitcoin/issues/25395#issuecomment-1430379485)
Hmm, I wonder if this is the same issue as https://github.com/bitcoin/bitcoin/issues/26176 where the .dmg is being silently mounted?

After you double click the dmg file, is it mounted to the left pane of your Finder window for you to click on to open?

💬 fanquake commented on pull request "build: Add CMake-based build system (1 of N)":
(https://github.com/bitcoin/bitcoin/pull/27060#issuecomment-1430380701)
> seem to mostly be pushing back on this portion:

There are multiple reasons to push back on this. For example:

1. The parent PR (#25797) suffers from a lack of high-level review. While there are lots of "CMake good, Autotools bad" type comments, along with some developers checking out the branch and seeing if it works on their machine, there is very little review in regards to the actual implementation; which I think still has room for improvement, for example:
* Re-implementing a la
...

💬 AdmiralNeo commented on issue "Stop the GPG verification madness":
(https://github.com/bitcoin/bitcoin/issues/25395#issuecomment-1430386726)
My God - Apple says "can't open cause it can not check for malware. Software has to be updated."


<img width="911" alt="Bildschirmfoto 2023-02-14 um 22 11 09" src="https://user-images.githubusercontent.com/125405780/218863910-407471e4-bd8c-4973-aef7-3221716382aa.png">

💬 jonatack commented on pull request "Handle CJDNS from LookupSubNet()":
(https://github.com/bitcoin/bitcoin/pull/27071#discussion_r1106373444)
nit, it may be nice to hoist `0xfc` used here and in `src/test/fuzz/util/net.cpp#L40-41` to a constexpr/constant, as grepping the codebase for it returns many unrelated false positives.

💬 jonatack commented on pull request "Handle CJDNS from LookupSubNet()":
(https://github.com/bitcoin/bitcoin/pull/27071#discussion_r1106360822)
nit, while touching this it may be good to add the missing brackets to `if (net == NET_UNROUTABLE)`, feel free to ignore

💬 jonatack commented on pull request "Handle CJDNS from LookupSubNet()":
(https://github.com/bitcoin/bitcoin/pull/27071#discussion_r1106381226)
As BIP155 networks are added or removed over time, `m_reachable` could go out of sync with `enum Network` in `netaddress.h` ... perhaps construct it programmatically (maybe in a follow-up)?

💬 jonatack commented on pull request "Handle CJDNS from LookupSubNet()":
(https://github.com/bitcoin/bitcoin/pull/27071#discussion_r1106375231)
Add `AssertLockNotHeld(m_mutex);` to the `RemoveAll()` and both the `Contains()` class methods?

💬 AdmiralNeo commented on issue "Stop the GPG verification madness":
(https://github.com/bitcoin/bitcoin/issues/25395#issuecomment-1430388543)
And I guess it is mounted?

💬 willcl-ark commented on issue "Stop the GPG verification madness":
(https://github.com/bitcoin/bitcoin/issues/25395#issuecomment-1430388997)
Yes it's mounted.

@AdmiralNeo Perhaps you could try this workaround: https://github.com/bitcoin/bitcoin/issues/24140#issuecomment-1021062326

💬 jonatack commented on pull request "fuzz: extend ConsumeNetAddr() to return I2P and CJDNS addresses":
(https://github.com/bitcoin/bitcoin/pull/26859#issuecomment-1430397018)
Concept ACK. Reviewed prerequisite PR #27071.

💬 AdmiralNeo commented on issue "Stop the GPG verification madness":
(https://github.com/bitcoin/bitcoin/issues/25395#issuecomment-1430401991)
Wow! Somehow I started a process of Bitcoin Core loading. THX a lot and let's see of a Dummy like me is really able to run a node. Ordinals brought me to this. THX bro a lot! Let's see if it works.

💬 achow101 commented on pull request "Signing support for Miniscript Descriptors":
(https://github.com/bitcoin/bitcoin/pull/24149#issuecomment-1430404755)
ACK 6c7a17a8e0eec377f83ed1399f003ae70b898270

Reviewed code and non-fuzz tests.

💬 AdmiralNeo commented on issue "Stop the GPG verification madness":
(https://github.com/bitcoin/bitcoin/issues/25395#issuecomment-1430410700)
<img width="815" alt="Bildschirmfoto 2023-02-14 um 22 37 12" src="https://user-images.githubusercontent.com/125405780/218868760-4e6dd03d-c849-4b41-85d2-e66524802876.png">

💬 achow101 commented on pull request "wallet: SecureString to allow null characters":
(https://github.com/bitcoin/bitcoin/pull/27068#issuecomment-1430493423)
ACK d73721b2be27afd9906ed362e286dd3d0a414413

💬 achow101 commented on pull request "test: p2p: check that headers message with invalid proof-of-work disconnects peer":
(https://github.com/bitcoin/bitcoin/pull/26184#issuecomment-1430533462)
ACK 772671245d50d94fd5087deb2542854604eba174

✳️ achow101 pushed commits to a branch: bitcoin/bitcoin:master
(https://github.com/bitcoin/bitcoin/compare/fb2f0934799a...576e16e7026f)
Merge bitcoin/bitcoin#26184: test: p2p: check that headers message with invalid proof-of-work disconnects peer

772671245d50d94fd5087deb2542854604eba174 test: p2p: check that headers message with invalid proof-of-work disconnects peer (Sebastian Falbesoner)

Pull request description:

One of the earliest anti-DoS checks done after receiving and deserializing a `headers` message from a peer is verifying whether the proof-of-work is valid (called in method `PeerManagerImpl::ProcessHeadersMessage`):
https://github.com/bitcoin/bitcoin/blob/f227e153e80c8c50c30d76e1ac638d7206c7ff61/src/net_processing.cpp#L2752-L2762
The called method `PeerManagerImpl::CheckHeadersPoW` calls `Misbehaving` with a score of 100, i.e. leading to an immediate disconnect of the peer:
https://github.com/bitcoin/bitcoin/blob/f227e153e80c8c50c30d76e1ac638d7206c7ff61/src/net_processing.cpp#L2368-L2372

This PR adds a simple test for both the misbehaving log and the resulting disconnect. For creating a block header with invalid proof-of-work, we first create one that is accepted by the node (the difficulty field `nBits` is copied from the genesis block) and based on that the nonce is modified until we have block header hash prefix that is too high to fulfill even the minimum difficulty.

ACKs for top commit:
Sjors:
ACK 772671245d50d94fd5087deb2542854604eba174
achow101:
ACK 772671245d50d94fd5087deb2542854604eba174
brunoerg:
crACK 772671245d50d94fd5087deb2542854604eba174
furszy:
Code review ACK 77267124 with a non-blocking speedup.

Tree-SHA512: 680aa7939158d1dc672b90aa6554ba2b3a92584b6d3bcb0227776035858429feb8bc66eed18b47de0fe56df7d9b3ddaee231aaeaa360136603b9ad4b19e6ac11

🚀 achow101 merged a pull request: "test: p2p: check that headers message with invalid proof-of-work disconnects peer"
(https://github.com/bitcoin/bitcoin/pull/26184)