💬 jotapea commented on issue "Decouple datacarrier size and count limits (Draft PR)":
(https://github.com/bitcoin/bitcoin/issues/33595#issuecomment-3387998723)
The **motivation** is respect the consensus. `-datacarriersize=83` isn't even the default any more.
The **usefulness** is control of the number of inputs separated from the size per input. Having both be one is sloppy. This is a new feature, which should be configurable.
The new config would be simple, seen from v30.1:
For same policy as v30.0 / Libre Relay
```conf
datacarrier=1
datacarriersize=0
datacarrierlimit=0
```
Defaults proposed for v30.1 (same result as historical consensus)
```con
...
(https://github.com/bitcoin/bitcoin/issues/33595#issuecomment-3387998723)
The **motivation** is respect the consensus. `-datacarriersize=83` isn't even the default any more.
The **usefulness** is control of the number of inputs separated from the size per input. Having both be one is sloppy. This is a new feature, which should be configurable.
The new config would be simple, seen from v30.1:
For same policy as v30.0 / Libre Relay
```conf
datacarrier=1
datacarriersize=0
datacarrierlimit=0
```
Defaults proposed for v30.1 (same result as historical consensus)
```con
...
💬 luke-jr commented on pull request "node: change a tx-relay on/off flag to enum":
(https://github.com/bitcoin/bitcoin/pull/33567#discussion_r2418346583)
Probably should use class enums for new things?
(https://github.com/bitcoin/bitcoin/pull/33567#discussion_r2418346583)
Probably should use class enums for new things?
💬 GrayHatGuy commented on pull request "node: change a tx-relay on/off flag to enum":
(https://github.com/bitcoin/bitcoin/pull/33567#discussion_r2418418837)
Keep your pron outta my money
(https://github.com/bitcoin/bitcoin/pull/33567#discussion_r2418418837)
Keep your pron outta my money
💬 GrayHatGuy commented on issue "Decouple datacarrier size and count limits (Draft PR)":
(https://github.com/bitcoin/bitcoin/issues/33595#issuecomment-3388173535)
This is a perfect paper trail for the litigious
(https://github.com/bitcoin/bitcoin/issues/33595#issuecomment-3388173535)
This is a perfect paper trail for the litigious
💬 GrayHatGuy commented on pull request "policy: uncap datacarrier by default":
(https://github.com/bitcoin/bitcoin/pull/32406#issuecomment-3388175078)
> @earonesty
>
> That’s a valid perspective, and I agree that decentralization and censorship resistance are core to Bitcoin. My point is that restricting block size alone doesn’t necessarily strengthen those properties it just limits access and scalability. Sidechains like CoreDAO aren’t “ecosystems of tokens,” but extensions that maintain Bitcoin’s security assumptions while enabling additional functionality off-chain. This separation keeps Bitcoin lean as a settlement layer while allowing i
...
(https://github.com/bitcoin/bitcoin/pull/32406#issuecomment-3388175078)
> @earonesty
>
> That’s a valid perspective, and I agree that decentralization and censorship resistance are core to Bitcoin. My point is that restricting block size alone doesn’t necessarily strengthen those properties it just limits access and scalability. Sidechains like CoreDAO aren’t “ecosystems of tokens,” but extensions that maintain Bitcoin’s security assumptions while enabling additional functionality off-chain. This separation keeps Bitcoin lean as a settlement layer while allowing i
...
📝 sivamurugan90428 opened a pull request: "Change in argh.h"
(https://github.com/bitcoin/bitcoin/pull/33597)
<!--
*** Please remove the following help text before submitting: ***
Pull requests without a rationale and clear improvement may be closed
immediately.
GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->
<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:
* Any test improvements or new tests that improv
...
(https://github.com/bitcoin/bitcoin/pull/33597)
<!--
*** Please remove the following help text before submitting: ***
Pull requests without a rationale and clear improvement may be closed
immediately.
GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->
<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:
* Any test improvements or new tests that improv
...
📝 HARISHVIJAY006 opened a pull request: "notes"
(https://github.com/bitcoin/bitcoin/pull/33598)
<!--
*** Please remove the following help text before submitting: ***
Pull requests without a rationale and clear improvement may be closed
immediately.
GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->
<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:
* Any test improvements or new tests that improv
...
(https://github.com/bitcoin/bitcoin/pull/33598)
<!--
*** Please remove the following help text before submitting: ***
Pull requests without a rationale and clear improvement may be closed
immediately.
GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->
<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:
* Any test improvements or new tests that improv
...
✅ achow101 closed a pull request: "Change in argh.h"
(https://github.com/bitcoin/bitcoin/pull/33597)
(https://github.com/bitcoin/bitcoin/pull/33597)
✅ maflcko closed a pull request: "Add warning and documentation for -bind with Tor hidden services (#33…"
(https://github.com/bitcoin/bitcoin/pull/33596)
(https://github.com/bitcoin/bitcoin/pull/33596)
💬 maflcko commented on pull request "Add warning and documentation for -bind with Tor hidden services (#33…":
(https://github.com/bitcoin/bitcoin/pull/33596#issuecomment-3388399645)
Closing as a low-quality (and obviously wrong) LLM generated bot/spam patch, with an (obviously wrong) hallucinated explanation, without any test coverage or otherwise steps to test, and finally test failures in the existing tests.
If you wish to contribute in the future, please focus on creating high-quality, original content that demonstrates a clear understanding of the project's requirements and goals. Also, see the [contributing guidelines](https://github.com/bitcoin/bitcoin/blob/master/
...
(https://github.com/bitcoin/bitcoin/pull/33596#issuecomment-3388399645)
Closing as a low-quality (and obviously wrong) LLM generated bot/spam patch, with an (obviously wrong) hallucinated explanation, without any test coverage or otherwise steps to test, and finally test failures in the existing tests.
If you wish to contribute in the future, please focus on creating high-quality, original content that demonstrates a clear understanding of the project's requirements and goals. Also, see the [contributing guidelines](https://github.com/bitcoin/bitcoin/blob/master/
...
💬 maflcko commented on pull request "guix: Use UCRT runtime for Windows release binaries":
(https://github.com/bitcoin/bitcoin/pull/33593#discussion_r2418596746)
Is there a rationale why upstream guix does not offer ucrt?
(https://github.com/bitcoin/bitcoin/pull/33593#discussion_r2418596746)
Is there a rationale why upstream guix does not offer ucrt?
⚠️ maflcko opened an issue: "Intermittent CI network issue downloading assets.json from GitHub"
(https://github.com/bitcoin/bitcoin/issues/33599)
CI frequently fails lately intermittently due to a network issue: https://github.com/bitcoin/bitcoin/actions/runs/18389269290/job/52395485037?pr=33592#step:9:518
As the infra was changed to run on someone else's sever, I don't know how to debug this or how to fix it.
(https://github.com/bitcoin/bitcoin/issues/33599)
CI frequently fails lately intermittently due to a network issue: https://github.com/bitcoin/bitcoin/actions/runs/18389269290/job/52395485037?pr=33592#step:9:518
As the infra was changed to run on someone else's sever, I don't know how to debug this or how to fix it.
💬 maflcko commented on pull request "[WIP] doc: update Guix install instructions":
(https://github.com/bitcoin/bitcoin/pull/33574#issuecomment-3388445684)
> that this might be a bad indicator for the guix project overall?
The LWN article concludes that "Regular releases" are planned, so it is likely that the situation will improve and possibly make backporting bugfixes easier in the future. So in theory, the guix package could make its way back into Debian/Ubuntu.
(https://github.com/bitcoin/bitcoin/pull/33574#issuecomment-3388445684)
> that this might be a bad indicator for the guix project overall?
The LWN article concludes that "Regular releases" are planned, so it is likely that the situation will improve and possibly make backporting bugfixes easier in the future. So in theory, the guix package could make its way back into Debian/Ubuntu.
💬 Dorex45 commented on pull request "[30.x] Finalise v30.0":
(https://github.com/bitcoin/bitcoin/pull/33559#issuecomment-3388453300)
ACK Reviewed the release notes.
> Finalise `v30.0`. Imports the release notes from https://github.com/bitcoin-core/bitcoin-devwiki/wiki/v30.0-Release-Notes-Draft.
(https://github.com/bitcoin/bitcoin/pull/33559#issuecomment-3388453300)
ACK Reviewed the release notes.
> Finalise `v30.0`. Imports the release notes from https://github.com/bitcoin-core/bitcoin-devwiki/wiki/v30.0-Release-Notes-Draft.
💬 maflcko commented on issue "Intermittent CI network issue downloading assets.json from GitHub":
(https://github.com/bitcoin/bitcoin/issues/33599#issuecomment-3388471886)
https://github.com/bitcoin/bitcoin/actions/runs/18383987889/job/52377590888?pr=33585#step:9:524, etc ...
(https://github.com/bitcoin/bitcoin/issues/33599#issuecomment-3388471886)
https://github.com/bitcoin/bitcoin/actions/runs/18383987889/job/52377590888?pr=33585#step:9:524, etc ...
💬 Dorex45 commented on pull request "refactor: throw `std::string_view` instead of `const char*` in constexpr/consteval functions":
(https://github.com/bitcoin/bitcoin/pull/33569#issuecomment-3388474342)
> Related to [#33550 (comment)](https://github.com/bitcoin/bitcoin/pull/33550#issuecomment-3378978210)
>
> Works around Clang code generation bug when targeting Windows where where catching `const char*` exceptions by reference is broken, see [mstorsjo/llvm-mingw#522](https://github.com/mstorsjo/llvm-mingw/issues/522)
>
> Following [C++ Core Guidelines E.15](https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#e15-throw-by-value-catch-exceptions-from-a-hierarchy-by-reference) "Thro
...
(https://github.com/bitcoin/bitcoin/pull/33569#issuecomment-3388474342)
> Related to [#33550 (comment)](https://github.com/bitcoin/bitcoin/pull/33550#issuecomment-3378978210)
>
> Works around Clang code generation bug when targeting Windows where where catching `const char*` exceptions by reference is broken, see [mstorsjo/llvm-mingw#522](https://github.com/mstorsjo/llvm-mingw/issues/522)
>
> Following [C++ Core Guidelines E.15](https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#e15-throw-by-value-catch-exceptions-from-a-hierarchy-by-reference) "Thro
...
💬 fanquake commented on issue "Intermittent CI network issue downloading assets.json from GitHub":
(https://github.com/bitcoin/bitcoin/issues/33599#issuecomment-3388532884)
Possibly related to Github API incidents yesterday: https://www.githubstatus.com/history ?
(https://github.com/bitcoin/bitcoin/issues/33599#issuecomment-3388532884)
Possibly related to Github API incidents yesterday: https://www.githubstatus.com/history ?
✅ fanquake closed an issue: "30.0 RC Testing Guide Feedback"
(https://github.com/bitcoin/bitcoin/issues/33369)
(https://github.com/bitcoin/bitcoin/issues/33369)
💬 fanquake commented on issue "30.0 RC Testing Guide Feedback":
(https://github.com/bitcoin/bitcoin/issues/33369#issuecomment-3388537850)
v30.0 has been tagged.
(https://github.com/bitcoin/bitcoin/issues/33369#issuecomment-3388537850)
v30.0 has been tagged.
⚠️ fanquake unpinned an issue: "30.0 RC Testing Guide Feedback"
(https://github.com/bitcoin/bitcoin/issues/33369)
This issue is to discuss the [30.0 Release Candidate Testing Guide](https://github.com/bitcoin-core/bitcoin-devwiki/wiki/30.0-Release-Candidate-Testing-Guide). If you have any feedback on the document, please leave a comment here.
Note: This is for feedback on the document, not on Bitcoin Core or on the 30.0 changes. Create a new issue or give feedback in the [v30.0 Testing issue](https://github.com/bitcoin/bitcoin/issues/33368)
Thank you for taking a look at the guide and leaving your feedbac
...
(https://github.com/bitcoin/bitcoin/issues/33369)
This issue is to discuss the [30.0 Release Candidate Testing Guide](https://github.com/bitcoin-core/bitcoin-devwiki/wiki/30.0-Release-Candidate-Testing-Guide). If you have any feedback on the document, please leave a comment here.
Note: This is for feedback on the document, not on Bitcoin Core or on the 30.0 changes. Create a new issue or give feedback in the [v30.0 Testing issue](https://github.com/bitcoin/bitcoin/issues/33368)
Thank you for taking a look at the guide and leaving your feedbac
...
⚠️ fanquake unpinned an issue: "v30.0 Testing"
(https://github.com/bitcoin/bitcoin/issues/33368)
Umbrella issue for 30.0 testing. Please help testing on a wide variety of supported platforms, as well as interaction with different software.
Let us know which version you tested on which operating system.
If you find an issue, please search Github for known issues first and then open a new Github issue.
This meta issue should not be used to report bugs, as a single thread makes it impossible to track more than one topic.
See [30.0 Release Notes Draft](https://github.com/bitcoin-core/bitcoi
...
(https://github.com/bitcoin/bitcoin/issues/33368)
Umbrella issue for 30.0 testing. Please help testing on a wide variety of supported platforms, as well as interaction with different software.
Let us know which version you tested on which operating system.
If you find an issue, please search Github for known issues first and then open a new Github issue.
This meta issue should not be used to report bugs, as a single thread makes it impossible to track more than one topic.
See [30.0 Release Notes Draft](https://github.com/bitcoin-core/bitcoi
...