💬 hebasto commented on pull request "build: Remove CMAKE_SKIP_BUILD_RPATH and SKIP_BUILD_RPATH settings":
(https://github.com/bitcoin/bitcoin/pull/33247#discussion_r2378918081)
This comment doesn't seem correct to me, since we check that installed binaries have no `RUNPATH` or `RPATH` set. Maybe drop this line?

📝 maflcko opened a pull request: "ci: Turn CentOS config into Alpine musl config"
(https://github.com/bitcoin/bitcoin/pull/33480)
Fixes https://github.com/bitcoin/bitcoin/issues/33437

Historically, the centos task was added to add CI coverage for centos-like distros. Also, to have coverage for 32-bit builds, but this is now covered by different tasks.

So basically, the centos task is similar to all the Ubuntu/Debian CI tasks, possibly with some packages named slightly differently. I am not aware of the task ever discovering a centos-related issue, so it seems fine to recycle it into an Alpine Linux task.

The main
...

💬 willcl-ark commented on pull request "ci: Turn CentOS config into Alpine musl config":
(https://github.com/bitcoin/bitcoin/pull/33480#issuecomment-3333712941)
Concept ACK

👍 willcl-ark approved a pull request: "[28.x] More backports"
(https://github.com/bitcoin/bitcoin/pull/33415#pullrequestreview-3267449488)
ACK a5e4fec4949f61ebbd7d6696f39da26df04515f9

This now only includes #33236, #33395 and #33340, with the other changes moving into #33476.

Backports look fine, 966666de was the only commit that appears to have needed resolution.

All backports are credited in the release notes.

🤔 hebasto reviewed a pull request: "build: Remove CMAKE_SKIP_BUILD_RPATH and SKIP_BUILD_RPATH settings"
(https://github.com/bitcoin/bitcoin/pull/33247#pullrequestreview-3267478272)
I've tested 9c13be9c45cad19d9db78e318b1e8376d56d6ec5, including running with [`V=1`](https://github.com/bitcoin/bitcoin/blob/master/contrib/guix/README.md#recognized-environment-variables). It looks good.

Please amend the comments in `contrib/guix/libexec/build.sh` as noted above.

🤔 rkrux reviewed a pull request: "key: use static context for libsecp256k1 calls where applicable"
(https://github.com/bitcoin/bitcoin/pull/33399#pullrequestreview-3267494219)
crACK 1ff9e929489e625a603e8755b8efe849feda1f16

I have limited exposure to this area. I agree with the intent of using the static context in more places where the non-static one is not really required.

I checked the implementation of the functions that have the static context passed now, and almost of them don't seem to use the passed context besides for the not-null checks. The `secp256k1_declassify` function internally called via `secp256k1_keypair_xonly_pub` does seem to use the context but
...

⚠️ asadr42 opened an issue: "Transaction"
(https://github.com/bitcoin/bitcoin/issues/33481)
Hello, dear supporter, on December 12, 2024, $1,609 was deducted from my Bitcoin wallet account, and I don't know why. When I go to my Bitcoin transaction history, it shows a page that I will send to you. Please guide me based on this explanation and the screenshot sent and tell me what I should do. Thank you for your response.

✅ pinheadmz closed an issue: "Transaction"
(https://github.com/bitcoin/bitcoin/issues/33481)

💬 maflcko commented on pull request "test: Replace legacy wallet with MiniWallet in rpc_getblockstats.py":
(https://github.com/bitcoin/bitcoin/pull/33184#issuecomment-3333824240)
> they weren't legacy wallet specific but rather configuration problems.

You'll have to adjust the pull description. Also, CI fails.

To ensure this is tested once, you can add `--gen-test-data` to one CI task config via TEST_RUNNER_EXTRA.

💬 janb84 commented on issue "30.0 RC Testing Guide Feedback":
(https://github.com/bitcoin/bitcoin/issues/33369#issuecomment-3333847560)
> I am running Arch Linux x86_64. Please let me know if there is anything I can do to help diagnose this issue.

I have changed the command to `ss -ax | grep node` that will fix this issue. Thank you for you patience.

💬 pinheadmz commented on issue "Transaction":
(https://github.com/bitcoin/bitcoin/issues/33481#issuecomment-3333923185)
The Bitcoin Core issue tracker is reserved for specific software issues like bug reports and feature requests. Individual help inquiries or general Bitcoin usage questions are more appropriate at https://bitcoin.stackexchange.com https://reddit.com/r/bitcoin or IRC channels such as `#bitcoin`

💬 amishhaa commented on pull request "contrib: fix for macOS deployment build failing on Qt translations even though it is optional.":
(https://github.com/bitcoin/bitcoin/pull/33358#issuecomment-3333923731)
@hebasto yes! So I was following the general steps to set up app on macos however I didn't download any qt translations presuming it was optional from the comment linkedin in PR, so to reproduce if you have translation directories in place ull need to delete them and then try to build the file, otherwise don't download it at all and try to build it. It should fail on that flag as translations dir was never downloaded.

💬 asadr42 commented on issue "Transaction":
(https://github.com/bitcoin/bitcoin/issues/33481#issuecomment-3333999619)
My transaction is 874359
1NvoSy1DKENhRo33aBCv2hnnvEd5arFUmL &


d9ecddec91d10d600d7ffa5460026c5b68d01a1899109c49a1f6c6792ee6a751

On Thu, Sep 25, 2025, 4:40 PM Matthew Zipkin ***@***.***>
wrote:

> *pinheadmz* left a comment (bitcoin/bitcoin#33481)
> <https://github.com/bitcoin/bitcoin/issues/33481#issuecomment-3333923185>
>
> The Bitcoin Core issue tracker is reserved for specific software issues
> like bug reports and feature requests. Individual help inquiries or general

...

💬 maflcko commented on pull request "help: enrich help text for `-loadblock`":
(https://github.com/bitcoin/bitcoin/pull/33343#issuecomment-3334246182)
> I think we should try it ourselves before recommending it in the documentation

It is already tested in `test/functional/feature_loadblock.py`, no?

🤔 janb84 reviewed a pull request: "doc: Add `INSTALL.md` to Linux release tarballs"
(https://github.com/bitcoin/bitcoin/pull/33451#pullrequestreview-3267865437)
ACK fc6d41d078656024cf9b3a8ef30b6cd2c79cfcf6

PR adds installation documentation for linux. The installation guide has an easy to copy section for installation of the QT dependencies.

Tested on clean Debian 13 install:
- KDE already has all the dependencies installed, works out of the box. Installing the suggested dependencies results in 0 new installs.
- XFCE is missing `libxcb-cursor` and the guide works as a charm in supplying that dependency.

Tested with binaries version V30.0r
...

💬 vasild commented on pull request "test: fix p2p_leak_tx.py":
(https://github.com/bitcoin/bitcoin/pull/33121#discussion_r2379224161)
In the first commit, it is possible to generate fake time passage without spending wall clock time of the test. That is, fix the problem and make the test faster:

```diff
def test_tx_in_block(self):
self.log.info("Check that a transaction in the last block is uploaded (beneficial for compact block relay)")
+ self.gen_node.setmocktime(int(time.time()) - 120) # pause time based activities
inbound_peer = self.gen_node.add_p2p_connection(P2PNode())

s
...

✅ maflcko closed a pull request: "rpc: Add validation for invalid taproot signatures in analyzepsbt"
(https://github.com/bitcoin/bitcoin/pull/33360)

💬 maflcko commented on pull request "rpc: Add validation for invalid taproot signatures in analyzepsbt":
(https://github.com/bitcoin/bitcoin/pull/33360#issuecomment-3334326637)
Closing for now. This is LLM generated and obviously wrong (the tests fail), and the author does not seem to be working on it (no activity since this was opened 2 weeks ago)

✅ maflcko closed a pull request: "Fix #25980: Validate transactions in combinerawtransaction"
(https://github.com/bitcoin/bitcoin/pull/33361)

💬 maflcko commented on pull request "Fix #25980: Validate transactions in combinerawtransaction":
(https://github.com/bitcoin/bitcoin/pull/33361#issuecomment-3334330381)
Closing for now. This is LLM generated and obviously wrong (the tests fail), and the author does not seem to be working on it (no activity since this was opened 2 weeks ago)

💬 maflcko commented on pull request "Fix #25980: Validate transactions in combinerawtransaction":
(https://github.com/bitcoin/bitcoin/pull/33361#issuecomment-3334346015)
In the future, instead of creating competing pull requests, it would be better to just review the existing pull request with any feedback you may have.