💬 parabitdev commented on pull request "docs: Undeprecate datacarrier and datacarriersize configuration options":
(https://github.com/bitcoin/bitcoin/pull/33453#issuecomment-3321715193)
Removal of `and are expected to be removed in a future version` for technical accuracy is an admirable objective. A complete removal of deprecation is a bit hasty unless someone plans to resolve the behavior changes this flag exhibits with regards to things like multiple op_returns in a single transaction.

I only support this change if someone plans to champion that work, otherwise this feature is deprecated in the truest sense and failing to mark it as such would be irresponsible.

Code is
...

💬 RandyMcMillan commented on issue "cli:passing non-integers to datacarriersize":
(https://github.com/bitcoin/bitcoin/issues/33460#issuecomment-3321760175)
@polespinasa - thanks for looking.

💬 RandyMcMillan commented on issue "cli:passing non-integers to datacarriersize":
(https://github.com/bitcoin/bitcoin/issues/33460#issuecomment-3321779375)
I will let a mod rename and categorize the issue.

💬 mzumsande commented on pull request "wallet: reduce unconditional logging during load":
(https://github.com/bitcoin/bitcoin/pull/33299#issuecomment-3321875750)
After talking to @furszy I'll push a slightly different approach, will put it in draft until then.

📝 mzumsande converted_to_draft a pull request: "wallet: reduce unconditional logging during load"
(https://github.com/bitcoin/bitcoin/pull/33299)
Currently the unconditional log during init with a default wallet happens three times:
```
2025-09-03T19:57:16Z init message: Verifying wallet(s)…
2025-09-03T19:57:16Z Using SQLite Version 3.45.1
2025-09-03T19:57:16Z Using wallet XXX/.bitcoin/regtest
2025-09-03T19:57:16Z Using SQLite Version 3.45.1
2025-09-03T19:57:16Z Using wallet XXX/.bitcoin/regtest
(...)
2025-09-03T19:57:16Z Using SQLite Version 3.45.1
2025-09-03T19:57:16Z Using wallet XXX/.bitcoin/regtest
2025-09-03T19:57:16Z init
...

💬 achow101 commented on pull request "wallet: Be able to receive and spend inputs involving MuSig2 aggregate keys":
(https://github.com/bitcoin/bitcoin/pull/29675#discussion_r2370693304)
The line it is commenting is always required, including in normal operation when a `musig()` is present, and when a `musig()` is now known but the keys are. The comment is there to inform future readers wondering why the secnonces are unconditionally added.

💬 achow101 commented on pull request "wallet: Be able to receive and spend inputs involving MuSig2 aggregate keys":
(https://github.com/bitcoin/bitcoin/pull/29675#discussion_r2370723203)
It must still have the correct parity bit. While it is the key must be found in the script, the script is not where the key is sourced from.

💬 l0rinc commented on pull request "log: always print initial script verification state":
(https://github.com/bitcoin/bitcoin/pull/33336#discussion_r2370760229)
That's what I had before, but this was specifically requested: https://github.com/bitcoin/bitcoin/pull/33336#discussion_r2362231753
It's not a very big difference in my opinion, I don't mind either.

📝 benthecarman opened a pull request: "qt: Fix dark mode detection on Linux"
(https://github.com/bitcoin-core/gui/pull/895)
Enable GTK3 platform theme integration on Linux to properly detect
system dark/light mode settings. Without this, Qt applications on
Linux don't automatically adapt to the system theme, unlike macOS
where it works out of the box.

The fix sets QT_QPA_PLATFORMTHEME to "gtk3" before QApplication
initialization, but only if the user hasn't already set a platform
theme. This respects existing user configurations while providing
better defaults for desktop environments using G
...

🤔 w0xlt reviewed a pull request: "log: always print initial script verification state"
(https://github.com/bitcoin/bitcoin/pull/33336#pullrequestreview-3255852704)
reACK https://github.com/bitcoin/bitcoin/pull/33336/commits/010cf81407c0df8de766fd2a116463d180f25f33

💬 ariard commented on pull request "docs: Undeprecate datacarrier and datacarriersize configuration options":
(https://github.com/bitcoin/bitcoin/pull/33453#issuecomment-3322176062)
Concept ACK.

To give a single data point, it took 3.5 years to go from an initial proposal about
`-mempoolfullrbf` during the release cycle of [v22.0](https://gnusha.org/pi/bitcoindev/CALZpt+F2b3tdu1+kLZiBPCH2O-pDzZytoRFtX6X0a8UX4OBrDQ@mail.gmail.com/) to a release completely deprecating
the ability for a full node operator to police its processed transactions with the opt-in
RBF policy (v[29.0](https://github.com/bitcoin/bitcoin/pull/30592)). If there is no consensus, it's wiser to take t
...

🤔 pablomartin4btc reviewed a pull request: "doc: remove unrelated `bitcoin-wallet` binary from `libbitcoin_ipc` description"
(https://github.com/bitcoin/bitcoin/pull/33459#pullrequestreview-3255954505)
ACK fbde8d9a81d82e53933fe45e36d3a70206a48e0e

I agree that the tool is unrelated to IPC/ multiprocess, so removing it from the list of binaries that use libbitcoin_ipc is appropriate. As an offline wallet utility, it doesn’t provide full “management” like a running wallet RPC (no sending, no RPC-based operations); its capabilities are basically limited to creating wallets, showing wallet details, and importing/exporting wallet data.

💬 ajtowns commented on pull request "docs: Undeprecate datacarrier and datacarriersize configuration options":
(https://github.com/bitcoin/bitcoin/pull/33453#issuecomment-3322333174)
> Is the argument that poor compact block reconstruction rates leads to miner centralization overblown then if the loss in revenue due to orphans is dwarfed by the increasing difficulty? I thought this argument was one of the reasons for both uncapping `OP_RETURN` limits and for allowing sub-1sat/vb relay?

The comparison is that losing $1.70 out of every $1000 in revenue is effectively just noise or a rounding error in an environment where you're getting $195 swings due to other factors, so i
...

💬 dergoegge commented on pull request "p2p: add `DifferenceFormatter` fuzz target and invariant check":
(https://github.com/bitcoin/bitcoin/pull/33252#issuecomment-3322339038)
@achow101 @fanquake @glozow @hebasto @ryanofsky This has two good ACKs and no outstanding review comments. Would be great to hear what's missing here.

👋 enirox001's pull request is ready for review: "rpc: Fix dumptxoutset rollback with competing forks"
(https://github.com/bitcoin/bitcoin/pull/33444)

💬 enirox001 commented on issue "`dumptxoutset` rollback feature does not take forks into account":
(https://github.com/bitcoin/bitcoin/issues/32817#issuecomment-3322397212)
Opened the PR #33444 to address this issue

💬 ajtowns commented on pull request "net/rpc: Report inv information for debugging":
(https://github.com/bitcoin/bitcoin/pull/33448#issuecomment-3322415437)
Added the test after slightly cleaning it up

💬 Eunovo commented on pull request "log: always print initial script verification state":
(https://github.com/bitcoin/bitcoin/pull/33336#discussion_r2371206072)
Alright

💬 Eunovo commented on pull request "log: always print initial script verification state":
(https://github.com/bitcoin/bitcoin/pull/33336#discussion_r2371206290)
Alright

🤔 ajtowns reviewed a pull request: "log: always print initial script verification state"
(https://github.com/bitcoin/bitcoin/pull/33336#pullrequestreview-3256339146)
Some possible nits

💬 ajtowns commented on pull request "log: always print initial script verification state":
(https://github.com/bitcoin/bitcoin/pull/33336#discussion_r2371245648)
switch the check to:

```c++
if (AssumedValidBlock().IsNull()) {
script_check_reason = "assumevalid=0";
} else {
// ... long code block ...
}
```

?