Bitcoin Core Github
44 subscribers
120K links
Download Telegram
⚠️ fanquake opened an issue: "ci: add an Alpine (musl libc) job"
(https://github.com/bitcoin/bitcoin/issues/33437)
This exists in some nightly repos alreaady, however we could have some libc diversity in the main CI, especially given static (musl based) binary discussion.
⚠️ fanquake opened an issue: "ci: add (atleast one) *BSD job to the CI"
(https://github.com/bitcoin/bitcoin/issues/33438)
See https://github.com/bitcoin/bitcoin/pull/33333#discussion_r2362493046 & #33435. BSDs are being tested in nightly repos, but merging code here, just to have it reported as broken after the fact, which then requires more changes to fix, isn't ideal. Issues should be caught in this repo, before merging.
🤔 hebasto reviewed a pull request: "build: Remove lingering Windows registry & shortcuts (#32132 follow-up)"
(https://github.com/bitcoin/bitcoin/pull/33422#pullrequestreview-3245114592)
I suggest the following patch:
```diff
--- a/share/setup.nsi.in
+++ b/share/setup.nsi.in
@@ -118,10 +118,12 @@ Section -post SEC0001
DeleteRegKey HKCU "SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\$(^Name) (64-bit)"
Delete /REBOOTOK "$SMPROGRAMS\$StartMenuGroup\Uninstall $(^Name) (64-bit).lnk"
Delete /REBOOTOK "$SMPROGRAMS\$StartMenuGroup\$(^Name) (64-bit).lnk"
+ Delete /REBOOTOK "$SMPROGRAMS\$StartMenuGroup\Bitcoin Core (testnet, 64-bit).lnk"
DeleteRegValu
...
💬 marcofleon commented on pull request "fuzz: reduce iterations in slow targets":
(https://github.com/bitcoin/bitcoin/pull/33429#issuecomment-3312448551)
I ran the MSan fuzz CI script on my machine with these changes and for single run through the qa-assets inputs:

- `mini_miner` 105 sec
- `txdownloadman` 115 sec
- `txdownloadman_impl` 165 sec
- `tx_pool_standard` 727 sec

Some previous times can be seen in https://github.com/bitcoin/bitcoin/pull/33425.
👋 marcofleon's pull request is ready for review: "fuzz: reduce iterations in slow targets"
(https://github.com/bitcoin/bitcoin/pull/33429)
💬 hebasto commented on pull request "msvc: Update vcpkg manifest":
(https://github.com/bitcoin/bitcoin/pull/33408#issuecomment-3312449574)
Friendly ping @sipsorcery @hodlinator @davidgumberg :)
💬 john-moffett commented on pull request "rpc: Always return per-wtxid entries in submitpackage tx-results":
(https://github.com/bitcoin/bitcoin/pull/33427#issuecomment-3312483030)
Updated with suggestions. Thanks @instagibbs & @glozow.
💬 hebasto commented on pull request "system: silence unused variable warning and make GetTotalRAM() work on FreeBSD":
(https://github.com/bitcoin/bitcoin/pull/33435#discussion_r2363141671)
Here are the relevant docs:
- [OpenBSD manpage](https://man.openbsd.org/sysconf.3)
- [NetBSD manpage](https://man.netbsd.org/sysconf.3)
- [illumos manpage](https://illumos.org/man/3C/sysconf)
💬 benthecarman commented on pull request "depends: static libxcb-cursor":
(https://github.com/bitcoin/bitcoin/pull/33434#issuecomment-3312489843)
> @benthecarman any chance you can test a Guix built binary?

I needed to install libxcb-cursor0 to get the guix built binary to work, that's when it fixed the window issue but removed dark mode
👍 dergoegge approved a pull request: "fuzz: reduce iterations in slow targets"
(https://github.com/bitcoin/bitcoin/pull/33429#pullrequestreview-3245267683)
utACK 6a33970fef1b7b4d634f28277607b882958c95ac
💬 hebasto commented on pull request "build: Remove lingering Windows registry & shortcuts (#32132 follow-up)":
(https://github.com/bitcoin/bitcoin/pull/33422#issuecomment-3312513869)
What about `RMDir /r /REBOOTOK $INSTDIR\doc` part I mentioned in https://github.com/bitcoin/bitcoin/pull/33422#pullrequestreview-3245114592?
💬 fanquake commented on pull request "depends: static libxcb-cursor":
(https://github.com/bitcoin/bitcoin/pull/33434#issuecomment-3312514980)
Just to be clear, I meant could you test a Guix build of this branch, as the `bitcoin-qt` produced no-longer has a `libxcb-cursor0` dependency.
💬 hodlinator commented on pull request "build: Remove lingering Windows registry & shortcuts (#32132 follow-up)":
(https://github.com/bitcoin/bitcoin/pull/33422#issuecomment-3312515677)
> Another alternative is to ask the user to uninstall any previous installation before installing a new one, but this is suboptimal.

Yup. I wish NSIS would keep exact track of previously installed files in the registry with checksums and allowed one to diff against the new files.

> I suggest the following patch:
> ...
> It additionally clears lingering artifacts from older versions and enables a clean uninstall on systems with a long upgrade history.
>
> See:
>
> * #25809
>

...
👍 hebasto approved a pull request: "build: Remove lingering Windows registry & shortcuts (#32132 follow-up)"
(https://github.com/bitcoin/bitcoin/pull/33422#pullrequestreview-3245308207)
ACK 79752b9c0b6bd9b2203ac98d28dd67734050c14a.
💬 willcl-ark commented on pull request "ci: run s390x job":
(https://github.com/bitcoin/bitcoin/pull/33436#issuecomment-3312527009)
I think this needs qemu:

```patch
commit 766b0b32361ae2eca3ee0b85caf1e27701fc0275
Author: will <will@256k1.dev>
Date: Fri Sep 19 15:47:01 2025 +0100

use qemu

diff --git a/.github/actions/configure-docker/action.yml b/.github/actions/configure-docker/action.yml
index c78df86b6cf..db5001c140d 100644
--- a/.github/actions/configure-docker/action.yml
+++ b/.github/actions/configure-docker/action.yml
@@ -4,9 +4,16 @@ inputs:
use-cirrus:
description: 'Use cirrus cache'
...
💬 willcl-ark commented on pull request "ci: run s390x job":
(https://github.com/bitcoin/bitcoin/pull/33436#issuecomment-3312546529)
Or we just enable qemu on all jobs (no downsides that I know of) with:

```patch
commit 6e7fba0b93d1dec0deafe7b7f87054c9a629134f
Author: will <will@256k1.dev>
Date: Fri Sep 19 15:47:01 2025 +0100

use qemu

diff --git a/.github/actions/configure-docker/action.yml b/.github/actions/configure-docker/action.yml
index c78df86b6cf..b5f3601a24b 100644
--- a/.github/actions/configure-docker/action.yml
+++ b/.github/actions/configure-docker/action.yml
@@ -7,6 +7,9 @@ inputs:
runs:

...
💬 instagibbs commented on pull request "rpc: Always return per-wtxid entries in submitpackage tx-results":
(https://github.com/bitcoin/bitcoin/pull/33427#discussion_r2363328883)
Do we want the RPC to return an error, or stumble through and try to return something?

Middle ground is adding an `Assume()` that gets compiled out in release builds

@glozow
💬 ajtowns commented on pull request "net: Provide block templates to peers on request":
(https://github.com/bitcoin/bitcoin/pull/33191#issuecomment-3312726054)
Patchset to also request templates from outbound peers is at https://github.com/ajtowns/bitcoin/commits/202508-sendtemplate3/
💬 benthecarman commented on pull request "depends: static libxcb-cursor":
(https://github.com/bitcoin/bitcoin/pull/33434#issuecomment-3312740332)
Sorry, that was for v30rc1

built guix binary for this PR. This fixes so I don't need `libxcb-cursor0` installed to run the binary and is the same where no dark mode but also no windowing bug
💬 hebasto commented on pull request "depends: static libxcb-cursor":
(https://github.com/bitcoin/bitcoin/pull/33434#discussion_r2363468002)
> Haven't tested this, or looked for potential side effects (i.e #33432 claims that installing the dep breaks dark mode). Also related to #32097.

I’m still not sure I understand this fix. Perhaps @benthecarman could provide [more details](https://github.com/bitcoin/bitcoin/issues/33432#issuecomment-3311581711) about the reported bug?
💬 glozow commented on pull request "rpc: Always return per-wtxid entries in submitpackage tx-results":
(https://github.com/bitcoin/bitcoin/pull/33427#discussion_r2363493462)
I think CHECK_NONFATAL is fine. `Assume` might make it seem like this API quirk is more important than it actually is, and then we'd have to explain why it's ok to delete it later.