Bitcoin Core Github
45 subscribers
118K links
Download Telegram
💬 vasild commented on pull request "rpc: provide per message stats for global traffic via new RPC 'getnetmsgstats'":
(https://github.com/bitcoin/bitcoin/pull/29418#issuecomment-3269416910)
`528b4d6b9c...87d3d640e6`: rebase due to conflicts and fix a typo in comment
💬 josibake commented on pull request "Silent Payments: Receiving":
(https://github.com/bitcoin/bitcoin/pull/32966#discussion_r2332480260)
FYI, I have a WIP commit that implements a `SilentPaymentsSign` function, I'll push the commit later today. Its a bit more code than what we have with `CKey::TweakAdd`, but I do like that its silent payments specific and can't be used as a footgun.
💬 fanquake commented on pull request "guix: strip binaries in libexec":
(https://github.com/bitcoin/bitcoin/pull/33342#issuecomment-3269550586)
Guix Build:
```bash
2042885891c2fdb6d3220da39e6f19b1a9852e3cca865db10f29e94fb2edc35d guix-build-3cceda9f4855/output/aarch64-linux-gnu/SHA256SUMS.part
f0e603d2a39bab4f4f81160584d6e27c90601c38e8302b813969214e797f16f8 guix-build-3cceda9f4855/output/aarch64-linux-gnu/bitcoin-3cceda9f4855-aarch64-linux-gnu-debug.tar.gz
410a706671693f8770474c797e35bb878961ff810e5a9bfb2bd19b4f069bfd0c guix-build-3cceda9f4855/output/aarch64-linux-gnu/bitcoin-3cceda9f4855-aarch64-linux-gnu.tar.gz
acc23910bac2c095
...
👍 vasild approved a pull request: "net: Fix Discover() not running when using -bind=0.0.0.0:port"
(https://github.com/bitcoin/bitcoin/pull/32757#pullrequestreview-3200165794)
ACK 210dd4061193f221a05c630ef5819f36dde9b15f

It suffices to prefix only the first line of the commit message with "test:".
💬 Sjors commented on pull request "multiprocess: Don't require bitcoin -m argument when IPC options are used":
(https://github.com/bitcoin/bitcoin/pull/33229#issuecomment-3269646261)
ACK f9685d6a1389938b0cceb31d9eef201ab3dd2e86

We could simplify the functional tests a bit with 148ced15c3c27da332985361cc2c83ae12c772eb which drops `BITCOIN_CMD` and simplifies the `_argv` logic.
fanquake closed an issue: "bench: broken CSV format, commas in benchmark names"
(https://github.com/bitcoin/bitcoin/issues/33331)
🚀 fanquake merged a pull request: "Fix benchmark CSV output"
(https://github.com/bitcoin/bitcoin/pull/33340)
🚀 fanquake merged a pull request: "ci: reduce runner sizes on various jobs"
(https://github.com/bitcoin/bitcoin/pull/33319)
🚀 fanquake merged a pull request: "ci: Checkout latest merged pulls"
(https://github.com/bitcoin/bitcoin/pull/33303)
💬 fanquake commented on pull request "Release: 30.0 translations update":
(https://github.com/bitcoin/bitcoin/pull/33275#issuecomment-3269692601)
ACK b320f5efa1753aead857d4cddd742af16e51d8d1
💬 willcl-ark commented on pull request "ci: reduce runner sizes on various jobs":
(https://github.com/bitcoin/bitcoin/pull/33319#issuecomment-3269693548)
WIP stats collection (forked from @0xB10C project) here: https://willcl-ark.github.io/bitcoin-core-ci-stats
📝 fanquake opened a pull request: "[29.x] Backports"
(https://github.com/bitcoin/bitcoin/pull/33344)
Backports:
* #33340
🚀 fanquake merged a pull request: "Release: 30.0 translations update"
(https://github.com/bitcoin/bitcoin/pull/33275)
💬 fanquake commented on pull request "draft: CMake Goals and Guidelines":
(https://github.com/bitcoin/bitcoin/pull/33317#issuecomment-3269723504)
> can you grant me write access to the Wiki?

You should have access now. Will close this in favour of the using wiki.
fanquake closed a pull request: "draft: CMake Goals and Guidelines"
(https://github.com/bitcoin/bitcoin/pull/33317)
💬 ajtowns commented on pull request "kernel: Separate UTXO set access from validation functions":
(https://github.com/bitcoin/bitcoin/pull/32317#issuecomment-3269734161)
> Pass a block's spent coins through the existing `CBlockUndo` data structure to `ConnectBlock`

I don't think this is really a good direction. We already have a generic interface for supplying info about unspent coins: `CCoinsView`; I think we should be using that, rather than requiring users to convert their utxo data store into our undo format?

The thing that gets in the way of that seems to be the `AccessCoin` function returning a `Coin` by reference rather than value, but that doesn't
...
💬 Sjors commented on issue "ci: Support running from a worktree":
(https://github.com/bitcoin/bitcoin/issues/30028#issuecomment-3269740880)
As mentioned in https://github.com/bitcoin/bitcoin/pull/32767 the linter still doesn't work in a worktree.
⚠️ fanquake opened an issue: "ci: derived LLVM version too new"
(https://github.com/bitcoin/bitcoin/issues/33345)
Running the native MSAN job, it will install `clang 21.1.1`, which will result in a failure to clone the LLVM repo, as there is no 21.1.1 tag:
```bash
time env -i HOME="$HOME" PATH="$PATH" USER="$USER" bash -c 'MAKEJOBS="-j17" FILE_ENV="./ci/test/00_setup_env_native_msan.sh" ./ci/test_run_all.sh'
<snip>
+ [[ -n MemoryWithOrigins ]]
+ '[' -n 21 ']'
++ sed --silent 's@.*clang version \([0-9.]*\).*@\1@p'
++ clang --version
+ retry -- git clone --depth=1 https://github.com/llvm/llvm-project -b llvmo
...
💬 fanquake commented on issue "ci: derived LLVM version too new":
(https://github.com/bitcoin/bitcoin/issues/33345#issuecomment-3269794728)
cc @maflcko
📝 fanquake opened a pull request: "doc: remove release note fragment"
(https://github.com/bitcoin/bitcoin/pull/33346)
I've added the content to https://github.com/bitcoin-core/bitcoin-devwiki/wiki/v30.0-Release-Notes-Draft.
👍 dergoegge approved a pull request: "doc: remove release note fragment"
(https://github.com/bitcoin/bitcoin/pull/33346#pullrequestreview-3200515279)
ACK 0f0e6fe7f5f467353704c3a4f51ceb9a4e2cf0a0