🤔 mzumsande reviewed a pull request: "net: check for empty header before calling FillBlock"
(https://github.com/bitcoin/bitcoin/pull/33296#pullrequestreview-3198359933)
Code Review ACK 8b6264768030db1840041abeeaeefd6c227a2644

👍 hebasto approved a pull request: "guix: strip binaries in libexec"
(https://github.com/bitcoin/bitcoin/pull/33342#pullrequestreview-3198383238)
ACK 3cceda9f4855ac1f5df349f42efdbf5058d08f48, I've checked Guix build outputs.

💬 sipa commented on pull request "Cluster mempool implementation":
(https://github.com/bitcoin/bitcoin/pull/28676#issuecomment-3268253082)
Should we make all the `main_only` arguments in TxGraph mandatory? Or even replace them with an enum like

```c++
enum class Level {
MAIN, //<! Always refers to level 0
STAGING, //<! Always refers to level 1 (fail if it doesn't exist)
TOP, //<! Refers to level 1 if it exists, 0 otherwise
};
```

?

🤔 l0rinc reviewed a pull request: "help: enrich help text for `-loadblock`"
(https://github.com/bitcoin/bitcoin/pull/33343#pullrequestreview-3198286952)
I'm not sure it's a documentation issue, I think we should rather fix it by adding the obfuscation key to the AutoFile instead.
I will investigate if adding a fix and updating `feature_loadblock.py` makes more sense and will push an alternative PR to see what people think is more appropriate here.
Thanks for jumping on this so quickly.

💬 l0rinc commented on pull request "help: enrich help text for `-loadblock`":
(https://github.com/bitcoin/bitcoin/pull/33343#discussion_r2331448834)
For context we could mention the discussions in https://github.com/bitcoin/bitcoin/issues/33280 that lead here.

nit: I'd personally would prefer calling it by it's function (obfuscation) instead of the implementation detail (xor)
```suggestion
argsman.AddArg("-loadblock=<file>", "Imports blocks from external file on startup (does not support obfuscated blocks)", ArgsManager::ALLOW_ANY, OptionsCategory::OPTIONS);
```

💬 l0rinc commented on pull request "help: enrich help text for `-loadblock`":
(https://github.com/bitcoin/bitcoin/pull/33343#issuecomment-3268288721)
I wasn't aware of this, it seems we have a dedicated tool to https://github.com/bitcoin/bitcoin/tree/master/contrib/linearize.
It's explicitly written to deobfuscate blocks from your node’s blk*.dat (handling XOR if present) and writes them plain to output_file or to an output/blkNNNNN.dat.

💬 l0rinc commented on issue "use -loadblock to load blk*****.dat files, but the blocks in it are not recognized":
(https://github.com/bitcoin/bitcoin/issues/33280#issuecomment-3268290183)
@mzumsande, are you familiar with `/contrib/linearize`? I wasn't, see https://github.com/bitcoin/bitcoin/pull/33343#issuecomment-3268288721

💬 fjahr commented on pull request "net: check for empty header before calling FillBlock":
(https://github.com/bitcoin/bitcoin/pull/33296#issuecomment-3268365319)
tACK 8b6264768030db1840041abeeaeefd6c227a2644

Reproduced the issue using the test and ensured the changes here make the test pass.

💬 achow101 commented on pull request "net: check for empty header before calling FillBlock":
(https://github.com/bitcoin/bitcoin/pull/33296#issuecomment-3268394161)
ACK 8b6264768030db1840041abeeaeefd6c227a2644

✅ achow101 closed an issue: "signed overflow in coinstats index"
(https://github.com/bitcoin/bitcoin/issues/26362)

🚀 achow101 merged a pull request: "index: Fix coinstats overflow"
(https://github.com/bitcoin/bitcoin/pull/30469)

💬 dhabmhmd27-ctrl commented on something "":
(https://github.com/bitcoin/bitcoin/commit/8ad100a55be07efd481641319efe70ba430e8d23#r165396506)
****

💬 dhabmhmd27-ctrl commented on something "":
(https://github.com/bitcoin/bitcoin/commit/8ad100a55be07efd481641319efe70ba430e8d23#r165396594)
****

💬 dhabmhmd27-ctrl commented on something "":
(https://github.com/bitcoin/bitcoin/commit/8ad100a55be07efd481641319efe70ba430e8d23#r165396772)
****

🚀 achow101 merged a pull request: "net: check for empty header before calling FillBlock"
(https://github.com/bitcoin/bitcoin/pull/33296)

💬 achow101 commented on pull request "guix: strip binaries in libexec":
(https://github.com/bitcoin/bitcoin/pull/33342#issuecomment-3268434902)
ACK 3cceda9f4855ac1f5df349f42efdbf5058d08f48

Verified that the binaries are all stripped now, and that the debug symbols are in the debug symbols tarball.

```
2042885891c2fdb6d3220da39e6f19b1a9852e3cca865db10f29e94fb2edc35d guix-build-3cceda9f4855/output/aarch64-linux-gnu/SHA256SUMS.part
f0e603d2a39bab4f4f81160584d6e27c90601c38e8302b813969214e797f16f8 guix-build-3cceda9f4855/output/aarch64-linux-gnu/bitcoin-3cceda9f4855-aarch64-linux-gnu-debug.tar.gz
410a706671693f8770474c797e35bb8789
...

🚀 achow101 merged a pull request: "guix: strip binaries in libexec"
(https://github.com/bitcoin/bitcoin/pull/33342)

✅ iajhff closed a pull request: "Mapping for Lockedpool"
(https://github.com/bitcoin/bitcoin/pull/33328)

💬 polespinasa commented on pull request "wallet: Add `exportwatchonlywallet` RPC to export a watchonly version of a wallet":
(https://github.com/bitcoin/bitcoin/pull/32489#issuecomment-3268580076)
tACK 0f547141487e3964a55102f6ae441233d7144aaf

The behaviour of this new RPC was tested to update the guide in commit 0f547141487e3964a55102f6ae441233d7144aaf and the behaviour is the expected.

💬 HowHsu commented on pull request "help: enrich help text for `-loadblock`":
(https://github.com/bitcoin/bitcoin/pull/33343#issuecomment-3268776353)
> I'm not sure it's a documentation issue, I think we should rather fix it by adding the obfuscation key to the AutoFile instead. I will investigate if adding a fix and updating `feature_loadblock.py` makes more sense and will push an alternative PR to see what people think is more appropriate here. Thanks for jumping on this so quickly.


> I'm not sure it's a documentation issue, I think we should rather fix it by adding the obfuscation key to the AutoFile instead. I will investigate if add
...

🤔 Eunovo reviewed a pull request: "test: Remove polling loop from test_runner (take 2)"
(https://github.com/bitcoin/bitcoin/pull/33141#pullrequestreview-3199158399)
ReACK https://github.com/bitcoin/bitcoin/pull/33141/commits/fa4885ef2fde2b9fd9eb7367564a2946a45f20ac