💬 ryanofsky commented on pull request "multiprocess: Don't require bitcoin -m argument when IPC options are used":
(https://github.com/bitcoin/bitcoin/pull/33229#issuecomment-3265524908)
> Looks like Windows CI is still unhappy:
>
> ```
> File "D:\a\bitcoin\bitcoin/test/functional/tool_bitcoin.py", line 62, in run_test
> self.test_args([], [], expect_exe="bitcoind")
> ```
>
> Maybe @hebasto has an idea?
>
> I would be nice to get this in v30 so we don't have to teach people to use `-m` only for that to become unnecessary in the next release. But it's not a huge deal.
Yes I'd like to include / backport it in v30.
The code
...
(https://github.com/bitcoin/bitcoin/pull/33229#issuecomment-3265524908)
> Looks like Windows CI is still unhappy:
>
> ```
> File "D:\a\bitcoin\bitcoin/test/functional/tool_bitcoin.py", line 62, in run_test
> self.test_args([], [], expect_exe="bitcoind")
> ```
>
> Maybe @hebasto has an idea?
>
> I would be nice to get this in v30 so we don't have to teach people to use `-m` only for that to become unnecessary in the next release. But it's not a huge deal.
Yes I'd like to include / backport it in v30.
The code
...
💬 77fdvarvam commented on something "":
(https://github.com/bitcoin/bitcoin/commit/c9b7a792e2d8cfe5be14829ee6108d24abf8fcf6#r165346850)
@sweatybridge @alaister @charislam @kiwicopple @vantezzenbot @ivan-dalmet @jeannegrenet @gregnr @gokhanarkan @ioitiki @berson86 @atol71 @ILIYANGERMANOV @mfkl @fregante hi followings, anyone wanna chat?
(https://github.com/bitcoin/bitcoin/commit/c9b7a792e2d8cfe5be14829ee6108d24abf8fcf6#r165346850)
@sweatybridge @alaister @charislam @kiwicopple @vantezzenbot @ivan-dalmet @jeannegrenet @gregnr @gokhanarkan @ioitiki @berson86 @atol71 @ILIYANGERMANOV @mfkl @fregante hi followings, anyone wanna chat?
💬 vasild commented on pull request "Broadcast own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/29415#issuecomment-3265576319)
> I tried sending a tx with fee rate 0.1 sat/vbyte
Added a note to "Further extensions" in PR description (see at the bottom) to consider checking the FEEFILTER message and retrying sooner than 10 minutes if the transaction is below their threshold.
> I finally received the tx back from another peer after 13 hours and 90 connection attempts.
I wonder how this compares to the current send-to-all-connected-peers approach. If it took 90 peers to find one to accept the transaction, and if w
...
(https://github.com/bitcoin/bitcoin/pull/29415#issuecomment-3265576319)
> I tried sending a tx with fee rate 0.1 sat/vbyte
Added a note to "Further extensions" in PR description (see at the bottom) to consider checking the FEEFILTER message and retrying sooner than 10 minutes if the transaction is below their threshold.
> I finally received the tx back from another peer after 13 hours and 90 connection attempts.
I wonder how this compares to the current send-to-all-connected-peers approach. If it took 90 peers to find one to accept the transaction, and if w
...
💬 vasild commented on pull request "ci: detect outbound internet traffic generated while running tests":
(https://github.com/bitcoin/bitcoin/pull/31349#issuecomment-3265599978)
`778675ac71...151edfaf78`: rebase due to conflicts
(https://github.com/bitcoin/bitcoin/pull/31349#issuecomment-3265599978)
`778675ac71...151edfaf78`: rebase due to conflicts
📝 TheCharlatan opened a pull request: "net: Add interrupt to pcp retry loop"
(https://github.com/bitcoin/bitcoin/pull/33338)
Without this interrupt bitcoind takes a long time to exit if requested to do so after a failed pcp lookup on startup.
(https://github.com/bitcoin/bitcoin/pull/33338)
Without this interrupt bitcoind takes a long time to exit if requested to do so after a failed pcp lookup on startup.
💬 TheCharlatan commented on pull request "net: Add interrupt to pcp retry loop":
(https://github.com/bitcoin/bitcoin/pull/33338#issuecomment-3265618371)
Logs:
<details>
<summary>Master logs when mapping fails (Click to expand)</summary>
```
2025-09-08T10:02:52Z msghand thread start
2025-09-08T10:02:52Z Imported mempool transactions from file: 3 succeeded, 0 failed, 0 expired, 0 already there, 0 waiting for initial broadcast
2025-09-08T10:02:52Z initload thread exit
2025-09-08T10:02:52Z [net:warning] pcp: Could not receive response: Connection refused (111)
2025-09-08T10:02:52Z [net] portmap: gateway [IPv6]: fe80::a6ce:daff:fe8f:12a0%
...
(https://github.com/bitcoin/bitcoin/pull/33338#issuecomment-3265618371)
Logs:
<details>
<summary>Master logs when mapping fails (Click to expand)</summary>
```
2025-09-08T10:02:52Z msghand thread start
2025-09-08T10:02:52Z Imported mempool transactions from file: 3 succeeded, 0 failed, 0 expired, 0 already there, 0 waiting for initial broadcast
2025-09-08T10:02:52Z initload thread exit
2025-09-08T10:02:52Z [net:warning] pcp: Could not receive response: Connection refused (111)
2025-09-08T10:02:52Z [net] portmap: gateway [IPv6]: fe80::a6ce:daff:fe8f:12a0%
...
💬 hebasto commented on pull request "Release: 30.0 translations update":
(https://github.com/bitcoin/bitcoin/pull/33275#issuecomment-3265676083)
@jesterhodl
> Hey @hebasto I'm curious why the 30.x resources have a lot of untranslated labels. I know I completed 29.x Could it be that they have been copied from 29.x to 30.x before I finished?
>
> In screenshot below, the first one is a 29.x resource, the lower one is 30.x <img alt="image" width="1152" height="478" src="https://private-user-images.githubusercontent.com/103882255/486711123-d2603008-d4af-4ab7-a444-4a47431a5802.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRod
...
(https://github.com/bitcoin/bitcoin/pull/33275#issuecomment-3265676083)
@jesterhodl
> Hey @hebasto I'm curious why the 30.x resources have a lot of untranslated labels. I know I completed 29.x Could it be that they have been copied from 29.x to 30.x before I finished?
>
> In screenshot below, the first one is a 29.x resource, the lower one is 30.x <img alt="image" width="1152" height="478" src="https://private-user-images.githubusercontent.com/103882255/486711123-d2603008-d4af-4ab7-a444-4a47431a5802.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRod
...
💬 chimeziewilling1-bot commented on issue "bench: broken CSV format, commas in benchmark names":
(https://github.com/bitcoin/bitcoin/issues/33331#issuecomment-3265679583)
15 ofuozu
(https://github.com/bitcoin/bitcoin/issues/33331#issuecomment-3265679583)
15 ofuozu
💬 hebasto commented on pull request "Release: 30.0 translations update":
(https://github.com/bitcoin/bitcoin/pull/33275#issuecomment-3265688565)
@jesterhodl
Do you want me to drop the update for `src/qt/locale/bitcoin_pl.ts` to keep the Polish translation at least as good as it was in v29.0?
(https://github.com/bitcoin/bitcoin/pull/33275#issuecomment-3265688565)
@jesterhodl
Do you want me to drop the update for `src/qt/locale/bitcoin_pl.ts` to keep the Polish translation at least as good as it was in v29.0?
📝 fanquake opened a pull request: "doc: move release notes to wiki pre branch off"
(https://github.com/bitcoin/bitcoin/pull/33339)
See https://github.com/bitcoin-core/bitcoin-devwiki/wiki/v30.0-Release-Notes-Draft.
(https://github.com/bitcoin/bitcoin/pull/33339)
See https://github.com/bitcoin-core/bitcoin-devwiki/wiki/v30.0-Release-Notes-Draft.
📝 hebasto opened a pull request: "Fix benchmark CSV output"
(https://github.com/bitcoin/bitcoin/pull/33340)
The `SHA256AutoDetect` return output is used, among other use cases, to name benchmarks. Using a comma breaks the `bench_bitcoin` CSV output.
This PR replaces the comma with a semicolon, which fixes https://github.com/bitcoin/bitcoin/issues/33331.
(https://github.com/bitcoin/bitcoin/pull/33340)
The `SHA256AutoDetect` return output is used, among other use cases, to name benchmarks. Using a comma breaks the `bench_bitcoin` CSV output.
This PR replaces the comma with a semicolon, which fixes https://github.com/bitcoin/bitcoin/issues/33331.
💬 jesterhodl commented on pull request "Release: 30.0 translations update":
(https://github.com/bitcoin/bitcoin/pull/33275#issuecomment-3265829027)
Yes, if you don't mind, please. There's more much more missing in 30, than the delta of new stuff between 29 and 30.
(https://github.com/bitcoin/bitcoin/pull/33275#issuecomment-3265829027)
Yes, if you don't mind, please. There's more much more missing in 30, than the delta of new stuff between 29 and 30.
💬 hebasto commented on pull request "Release: 30.0 translations update":
(https://github.com/bitcoin/bitcoin/pull/33275#issuecomment-3265850650)
> Yes, if you don't mind, please. There's more much more missing in 30, than the delta of new stuff between 29 and 30.
Done.
(https://github.com/bitcoin/bitcoin/pull/33275#issuecomment-3265850650)
> Yes, if you don't mind, please. There's more much more missing in 30, than the delta of new stuff between 29 and 30.
Done.
💬 fjahr commented on pull request "common: Make arith_uint256 trivially copyable":
(https://github.com/bitcoin/bitcoin/pull/33332#discussion_r2329965967)
Done, thanks!
(https://github.com/bitcoin/bitcoin/pull/33332#discussion_r2329965967)
Done, thanks!
👍 TheCharlatan approved a pull request: "common: Make arith_uint256 trivially copyable"
(https://github.com/bitcoin/bitcoin/pull/33332#pullrequestreview-3196130456)
ACK 6ffc6d1140a4660e3e2a8717128d567f5557e394
(https://github.com/bitcoin/bitcoin/pull/33332#pullrequestreview-3196130456)
ACK 6ffc6d1140a4660e3e2a8717128d567f5557e394
💬 Raimo33 commented on pull request "common: Make arith_uint256 trivially copyable":
(https://github.com/bitcoin/bitcoin/pull/33332#issuecomment-3265883248)
Approach ACK 6ffc6d1140a4660e3e2a8717128d567f5557e394
(https://github.com/bitcoin/bitcoin/pull/33332#issuecomment-3265883248)
Approach ACK 6ffc6d1140a4660e3e2a8717128d567f5557e394
💬 elonmusk31905 commented on something "":
(https://github.com/bitcoin/bitcoin/commit/6ffc6d1140a4660e3e2a8717128d567f5557e394#commitcomment-165351448)
0x3967ad2871e71d4bce27aeab90d2fc664ddb565c2ea5075f33eca2185364251a
(https://github.com/bitcoin/bitcoin/commit/6ffc6d1140a4660e3e2a8717128d567f5557e394#commitcomment-165351448)
0x3967ad2871e71d4bce27aeab90d2fc664ddb565c2ea5075f33eca2185364251a
💬 fridokus commented on pull request "doc: move release notes to wiki pre branch off":
(https://github.com/bitcoin/bitcoin/pull/33339#issuecomment-3265992578)
utACK
(https://github.com/bitcoin/bitcoin/pull/33339#issuecomment-3265992578)
utACK
🤔 janb84 reviewed a pull request: "doc: move release notes to wiki pre branch off"
(https://github.com/bitcoin/bitcoin/pull/33339#pullrequestreview-3196259513)
ACK 905c1a77f51c0b1b0d1880ad381d75194c52a12f
All cross-referenced 👍 (have added some PR numbers to the wiki)
(https://github.com/bitcoin/bitcoin/pull/33339#pullrequestreview-3196259513)
ACK 905c1a77f51c0b1b0d1880ad381d75194c52a12f
All cross-referenced 👍 (have added some PR numbers to the wiki)
👍 willcl-ark approved a pull request: "doc: move release notes to wiki pre branch off"
(https://github.com/bitcoin/bitcoin/pull/33339#pullrequestreview-3196263483)
ACK 905c1a77f51c0b1b0d1880ad381d75194c52a12f
(https://github.com/bitcoin/bitcoin/pull/33339#pullrequestreview-3196263483)
ACK 905c1a77f51c0b1b0d1880ad381d75194c52a12f
🤔 hodlinator reviewed a pull request: "index: store per-block transaction locations for efficient lookups"
(https://github.com/bitcoin/bitcoin/pull/32541#pullrequestreview-3189055673)
Higher level flow:
```mermaid
sequenceDiagram
actor User
participant C as Electrum<br/>Client
participant S as Electrum<br/>Server
participant R as bitcoind<br/>REST interface
participant L as LocationsIndex
participant B as blockstorage
User->>+C: View wallet history
C->>+S: blockchain.scripthash.get_history(scripthash) [1]
note over C,S: https://electrum-protocol.readthedocs.io<br/>/en/latest/protocol-methods.html#blockchain-scripthash-get-his
...
(https://github.com/bitcoin/bitcoin/pull/32541#pullrequestreview-3189055673)
Higher level flow:
```mermaid
sequenceDiagram
actor User
participant C as Electrum<br/>Client
participant S as Electrum<br/>Server
participant R as bitcoind<br/>REST interface
participant L as LocationsIndex
participant B as blockstorage
User->>+C: View wallet history
C->>+S: blockchain.scripthash.get_history(scripthash) [1]
note over C,S: https://electrum-protocol.readthedocs.io<br/>/en/latest/protocol-methods.html#blockchain-scripthash-get-his
...