✅ fanquake closed an issue: "build: clang build broken on Debian Bookworm"
(https://github.com/bitcoin/bitcoin/issues/33279)
(https://github.com/bitcoin/bitcoin/issues/33279)
💬 fanquake commented on issue "build: clang build broken on Debian Bookworm":
(https://github.com/bitcoin/bitcoin/issues/33279#issuecomment-3265439112)
Going to close this for now, based on https://github.com/bitcoin-core/libmultiprocess/pull/205 (which was pulled in via #33322). We can followup further if any similar issues surface while testing `30.x`.
(https://github.com/bitcoin/bitcoin/issues/33279#issuecomment-3265439112)
Going to close this for now, based on https://github.com/bitcoin-core/libmultiprocess/pull/205 (which was pulled in via #33322). We can followup further if any similar issues surface while testing `30.x`.
💬 ryanofsky commented on issue "build: indefinite mpgen hang on Ubuntu 22.04":
(https://github.com/bitcoin/bitcoin/issues/33176#issuecomment-3265458641)
Makes sense to close. Since #33241 which includes https://github.com/bitcoin-core/libmultiprocess/pull/194, the build hang using old versions of GCC with v0.8.0 and v0.8.1 was fixed, but a cmake error was added warning about a CVE in v0.8.0, which means that Ubuntu 22.04 triggers this error. Ubuntu security team evaluated the CVE and opted not to fix it based on the severity and fact that is fix is in a library, so could cause other packages to need to be recompiled. #33322 improves the situatio
...
(https://github.com/bitcoin/bitcoin/issues/33176#issuecomment-3265458641)
Makes sense to close. Since #33241 which includes https://github.com/bitcoin-core/libmultiprocess/pull/194, the build hang using old versions of GCC with v0.8.0 and v0.8.1 was fixed, but a cmake error was added warning about a CVE in v0.8.0, which means that Ubuntu 22.04 triggers this error. Ubuntu security team evaluated the CVE and opted not to fix it based on the severity and fact that is fix is in a library, so could cause other packages to need to be recompiled. #33322 improves the situatio
...
💬 fanquake commented on pull request "ci: reduce runner sizes on various jobs":
(https://github.com/bitcoin/bitcoin/pull/33319#issuecomment-3265467783)
cc @maflcko
(https://github.com/bitcoin/bitcoin/pull/33319#issuecomment-3265467783)
cc @maflcko
💬 deyvid61 commented on pull request "Release: 30.0 translations update":
(https://github.com/bitcoin/bitcoin/pull/33275#discussion_r2329727735)
__
(https://github.com/bitcoin/bitcoin/pull/33275#discussion_r2329727735)
__
💬 TheCharlatan commented on pull request "Interfaces: Expose UTXO Snapshot Loading and Add Progress Notifications":
(https://github.com/bitcoin/bitcoin/pull/33117#issuecomment-3265507664)
Approach ACK
(https://github.com/bitcoin/bitcoin/pull/33117#issuecomment-3265507664)
Approach ACK
💬 jesterhodl commented on pull request "Release: 30.0 translations update":
(https://github.com/bitcoin/bitcoin/pull/33275#issuecomment-3265513185)
Hey @hebasto
I'm curious why the 30.x resources have a lot of untranslated labels. I know I completed 29.x
Could it be that they have been copied from 29.x to 30.x before I finished?
In screenshot below, the first one is a 29.x resource, the lower one is 30.x
<img width="1152" height="478" alt="image" src="https://github.com/user-attachments/assets/d2603008-d4af-4ab7-a444-4a47431a5802" />
Aside from the brand new labels, I can sync them up manually in Transifex, but just wanted to ask
...
(https://github.com/bitcoin/bitcoin/pull/33275#issuecomment-3265513185)
Hey @hebasto
I'm curious why the 30.x resources have a lot of untranslated labels. I know I completed 29.x
Could it be that they have been copied from 29.x to 30.x before I finished?
In screenshot below, the first one is a 29.x resource, the lower one is 30.x
<img width="1152" height="478" alt="image" src="https://github.com/user-attachments/assets/d2603008-d4af-4ab7-a444-4a47431a5802" />
Aside from the brand new labels, I can sync them up manually in Transifex, but just wanted to ask
...
💬 ryanofsky commented on pull request "multiprocess: Don't require bitcoin -m argument when IPC options are used":
(https://github.com/bitcoin/bitcoin/pull/33229#issuecomment-3265524908)
> Looks like Windows CI is still unhappy:
>
> ```
> File "D:\a\bitcoin\bitcoin/test/functional/tool_bitcoin.py", line 62, in run_test
> self.test_args([], [], expect_exe="bitcoind")
> ```
>
> Maybe @hebasto has an idea?
>
> I would be nice to get this in v30 so we don't have to teach people to use `-m` only for that to become unnecessary in the next release. But it's not a huge deal.
Yes I'd like to include / backport it in v30.
The code
...
(https://github.com/bitcoin/bitcoin/pull/33229#issuecomment-3265524908)
> Looks like Windows CI is still unhappy:
>
> ```
> File "D:\a\bitcoin\bitcoin/test/functional/tool_bitcoin.py", line 62, in run_test
> self.test_args([], [], expect_exe="bitcoind")
> ```
>
> Maybe @hebasto has an idea?
>
> I would be nice to get this in v30 so we don't have to teach people to use `-m` only for that to become unnecessary in the next release. But it's not a huge deal.
Yes I'd like to include / backport it in v30.
The code
...
💬 77fdvarvam commented on something "":
(https://github.com/bitcoin/bitcoin/commit/c9b7a792e2d8cfe5be14829ee6108d24abf8fcf6#r165346850)
@sweatybridge @alaister @charislam @kiwicopple @vantezzenbot @ivan-dalmet @jeannegrenet @gregnr @gokhanarkan @ioitiki @berson86 @atol71 @ILIYANGERMANOV @mfkl @fregante hi followings, anyone wanna chat?
(https://github.com/bitcoin/bitcoin/commit/c9b7a792e2d8cfe5be14829ee6108d24abf8fcf6#r165346850)
@sweatybridge @alaister @charislam @kiwicopple @vantezzenbot @ivan-dalmet @jeannegrenet @gregnr @gokhanarkan @ioitiki @berson86 @atol71 @ILIYANGERMANOV @mfkl @fregante hi followings, anyone wanna chat?
💬 vasild commented on pull request "Broadcast own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/29415#issuecomment-3265576319)
> I tried sending a tx with fee rate 0.1 sat/vbyte
Added a note to "Further extensions" in PR description (see at the bottom) to consider checking the FEEFILTER message and retrying sooner than 10 minutes if the transaction is below their threshold.
> I finally received the tx back from another peer after 13 hours and 90 connection attempts.
I wonder how this compares to the current send-to-all-connected-peers approach. If it took 90 peers to find one to accept the transaction, and if w
...
(https://github.com/bitcoin/bitcoin/pull/29415#issuecomment-3265576319)
> I tried sending a tx with fee rate 0.1 sat/vbyte
Added a note to "Further extensions" in PR description (see at the bottom) to consider checking the FEEFILTER message and retrying sooner than 10 minutes if the transaction is below their threshold.
> I finally received the tx back from another peer after 13 hours and 90 connection attempts.
I wonder how this compares to the current send-to-all-connected-peers approach. If it took 90 peers to find one to accept the transaction, and if w
...
💬 vasild commented on pull request "ci: detect outbound internet traffic generated while running tests":
(https://github.com/bitcoin/bitcoin/pull/31349#issuecomment-3265599978)
`778675ac71...151edfaf78`: rebase due to conflicts
(https://github.com/bitcoin/bitcoin/pull/31349#issuecomment-3265599978)
`778675ac71...151edfaf78`: rebase due to conflicts
📝 TheCharlatan opened a pull request: "net: Add interrupt to pcp retry loop"
(https://github.com/bitcoin/bitcoin/pull/33338)
Without this interrupt bitcoind takes a long time to exit if requested to do so after a failed pcp lookup on startup.
(https://github.com/bitcoin/bitcoin/pull/33338)
Without this interrupt bitcoind takes a long time to exit if requested to do so after a failed pcp lookup on startup.
💬 TheCharlatan commented on pull request "net: Add interrupt to pcp retry loop":
(https://github.com/bitcoin/bitcoin/pull/33338#issuecomment-3265618371)
Logs:
<details>
<summary>Master logs when mapping fails (Click to expand)</summary>
```
2025-09-08T10:02:52Z msghand thread start
2025-09-08T10:02:52Z Imported mempool transactions from file: 3 succeeded, 0 failed, 0 expired, 0 already there, 0 waiting for initial broadcast
2025-09-08T10:02:52Z initload thread exit
2025-09-08T10:02:52Z [net:warning] pcp: Could not receive response: Connection refused (111)
2025-09-08T10:02:52Z [net] portmap: gateway [IPv6]: fe80::a6ce:daff:fe8f:12a0%
...
(https://github.com/bitcoin/bitcoin/pull/33338#issuecomment-3265618371)
Logs:
<details>
<summary>Master logs when mapping fails (Click to expand)</summary>
```
2025-09-08T10:02:52Z msghand thread start
2025-09-08T10:02:52Z Imported mempool transactions from file: 3 succeeded, 0 failed, 0 expired, 0 already there, 0 waiting for initial broadcast
2025-09-08T10:02:52Z initload thread exit
2025-09-08T10:02:52Z [net:warning] pcp: Could not receive response: Connection refused (111)
2025-09-08T10:02:52Z [net] portmap: gateway [IPv6]: fe80::a6ce:daff:fe8f:12a0%
...
💬 hebasto commented on pull request "Release: 30.0 translations update":
(https://github.com/bitcoin/bitcoin/pull/33275#issuecomment-3265676083)
@jesterhodl
> Hey @hebasto I'm curious why the 30.x resources have a lot of untranslated labels. I know I completed 29.x Could it be that they have been copied from 29.x to 30.x before I finished?
>
> In screenshot below, the first one is a 29.x resource, the lower one is 30.x <img alt="image" width="1152" height="478" src="https://private-user-images.githubusercontent.com/103882255/486711123-d2603008-d4af-4ab7-a444-4a47431a5802.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRod
...
(https://github.com/bitcoin/bitcoin/pull/33275#issuecomment-3265676083)
@jesterhodl
> Hey @hebasto I'm curious why the 30.x resources have a lot of untranslated labels. I know I completed 29.x Could it be that they have been copied from 29.x to 30.x before I finished?
>
> In screenshot below, the first one is a 29.x resource, the lower one is 30.x <img alt="image" width="1152" height="478" src="https://private-user-images.githubusercontent.com/103882255/486711123-d2603008-d4af-4ab7-a444-4a47431a5802.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRod
...
💬 chimeziewilling1-bot commented on issue "bench: broken CSV format, commas in benchmark names":
(https://github.com/bitcoin/bitcoin/issues/33331#issuecomment-3265679583)
15 ofuozu
(https://github.com/bitcoin/bitcoin/issues/33331#issuecomment-3265679583)
15 ofuozu
💬 hebasto commented on pull request "Release: 30.0 translations update":
(https://github.com/bitcoin/bitcoin/pull/33275#issuecomment-3265688565)
@jesterhodl
Do you want me to drop the update for `src/qt/locale/bitcoin_pl.ts` to keep the Polish translation at least as good as it was in v29.0?
(https://github.com/bitcoin/bitcoin/pull/33275#issuecomment-3265688565)
@jesterhodl
Do you want me to drop the update for `src/qt/locale/bitcoin_pl.ts` to keep the Polish translation at least as good as it was in v29.0?
📝 fanquake opened a pull request: "doc: move release notes to wiki pre branch off"
(https://github.com/bitcoin/bitcoin/pull/33339)
See https://github.com/bitcoin-core/bitcoin-devwiki/wiki/v30.0-Release-Notes-Draft.
(https://github.com/bitcoin/bitcoin/pull/33339)
See https://github.com/bitcoin-core/bitcoin-devwiki/wiki/v30.0-Release-Notes-Draft.
📝 hebasto opened a pull request: "Fix benchmark CSV output"
(https://github.com/bitcoin/bitcoin/pull/33340)
The `SHA256AutoDetect` return output is used, among other use cases, to name benchmarks. Using a comma breaks the `bench_bitcoin` CSV output.
This PR replaces the comma with a semicolon, which fixes https://github.com/bitcoin/bitcoin/issues/33331.
(https://github.com/bitcoin/bitcoin/pull/33340)
The `SHA256AutoDetect` return output is used, among other use cases, to name benchmarks. Using a comma breaks the `bench_bitcoin` CSV output.
This PR replaces the comma with a semicolon, which fixes https://github.com/bitcoin/bitcoin/issues/33331.
💬 jesterhodl commented on pull request "Release: 30.0 translations update":
(https://github.com/bitcoin/bitcoin/pull/33275#issuecomment-3265829027)
Yes, if you don't mind, please. There's more much more missing in 30, than the delta of new stuff between 29 and 30.
(https://github.com/bitcoin/bitcoin/pull/33275#issuecomment-3265829027)
Yes, if you don't mind, please. There's more much more missing in 30, than the delta of new stuff between 29 and 30.
💬 hebasto commented on pull request "Release: 30.0 translations update":
(https://github.com/bitcoin/bitcoin/pull/33275#issuecomment-3265850650)
> Yes, if you don't mind, please. There's more much more missing in 30, than the delta of new stuff between 29 and 30.
Done.
(https://github.com/bitcoin/bitcoin/pull/33275#issuecomment-3265850650)
> Yes, if you don't mind, please. There's more much more missing in 30, than the delta of new stuff between 29 and 30.
Done.
💬 fjahr commented on pull request "common: Make arith_uint256 trivially copyable":
(https://github.com/bitcoin/bitcoin/pull/33332#discussion_r2329965967)
Done, thanks!
(https://github.com/bitcoin/bitcoin/pull/33332#discussion_r2329965967)
Done, thanks!