💬 maflcko commented on pull request "ci: Avoid cd into build dir":
(https://github.com/bitcoin/bitcoin/pull/32880#discussion_r2197882926)
nice catch, fixed. Also, removed the `bash -c`, because if it was needed, the fallback code would be broken

🤔 brunoerg reviewed a pull request: "fuzz: Make process_message(s) more deterministic"
(https://github.com/bitcoin/bitcoin/pull/32822#pullrequestreview-3006007306)
reACK fa501ea5ed874ffcba2b606806460e61a1204bd2

💬 maflcko commented on pull request "ci: Avoid cd into build dir":
(https://github.com/bitcoin/bitcoin/pull/32880#discussion_r2197928044)
yeah, the fallback was missing `-j1` (required after ninja) and had a wordsplitting bug, due to the use of Bash :(

Fixed those as well.

🤔 danielabrozzoni reviewed a pull request: "test: refactor: overhaul block hash determination for `CBlock{,Header}` objects"
(https://github.com/bitcoin/bitcoin/pull/32868#pullrequestreview-3006094747)
tACK 50b41bcfbfd93f103cf6e2af1999c43947bc3f40

Nice! Dropping `calc_sha256` and `rehash` makes the code cleaner and less error-prone. I also like the new `hash_int` and `hash_hex` names, they're easier to remember than the old `hash`/`sha256`, which always got me confused.

Thanks for separating the commits and adding TODOs in the intermediate ones, it really helped make the PR easier to follow.

I checked that the remaining `.sha256` and `.hash` usages are unrelated. To quickly grep for `
...

💬 glozow commented on pull request "p2p: stop special-casing witness-stripped error for unconfirmed transactions":
(https://github.com/bitcoin/bitcoin/pull/32379#issuecomment-3057802935)
Following up, this branch removes the logic to halt orphan-processing when there are rejected parents, and removes rejection cache checking by txid altogether. It also adds a new delay for peers that don't support BIP 339 (distinct from the delay for requests by txid): https://github.com/glozow/bitcoin/tree/2025-07-wtxid-only-rej It should be sufficient to address the 1p1c issue.

There is a theoretical bandwidth increase from redownloading transactions, but my guess is it's minimal. Nonsegwit
...

💬 hebasto commented on pull request "qa: Fix `wallet_multiwallet.py`":
(https://github.com/bitcoin/bitcoin/pull/31410#issuecomment-3057858120)
> Would be nice to rebase this to fix the code-merge-conflicts, even if it remains in draft and even if the test remains in a failing state.

Rebased.

📝 1BitcoinBoWP1FZ4xwTNkq6XksKidmgYYw opened a pull request: "New SVG, Icons, PNGs and X PixMaps"
(https://github.com/bitcoin-core/gui/pull/879)
This PR clean up the old SVG, Icons, PNGs and X PixMaps by providing optimized much smaller file size versions while at the same time keeping resolutions untouched. Shadows are removed from the files.

📝 hebasto opened a pull request: "cmake: Use newer signature of `qt6_add_lrelease` when available"
(https://github.com/bitcoin/bitcoin/pull/32940)
See Qt docs here: https://doc.qt.io/qt-6/qtlinguist-cmake-qt-add-lrelease.html.

Fixes https://github.com/bitcoin/bitcoin/issues/32710.

💬 rkrux commented on pull request "wallet: `addhdkey` RPC to add just keys to wallets via new `unused(KEY)` descriptor":
(https://github.com/bitcoin/bitcoin/pull/29136#issuecomment-3058030548)
Concept ACK 61001085941fd6d78f4cd46c9b3d65914b6e961e

I am looking forward to the PRs built on top of this one.

💬 hebasto commented on pull request "New SVG, Icons, PNGs and X PixMaps":
(https://github.com/bitcoin-core/gui/pull/879#issuecomment-3058046706)
> Shadows are removed from the files.

Why do you think this change is necessary?

Also, the size of the logo has been increased. Could you please mention this in the PR description as well, along with a justification for the change?

💬 glozow commented on pull request "p2p: improve TxOrphanage denial of service bounds":
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r2198139821)
Nice catch! Changed

💬 glozow commented on pull request "p2p: improve TxOrphanage denial of service bounds":
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r2198140129)
oops yes, added the `/10` !

💬 hebasto commented on issue "qt: translation related warnings":
(https://github.com/bitcoin/bitcoin/issues/32710#issuecomment-3058055918)
> [@hebasto](https://github.com/hebasto) If this is an actual issue can it be fixed up?

Fixed in https://github.com/bitcoin/bitcoin/pull/32940.

💬 Crypt-iQ commented on pull request "fuzz: Add fuzz target for block index tree and related validation events":
(https://github.com/bitcoin/bitcoin/pull/31533#issuecomment-3058062207)
Still looking into the above source of non-determinism, it points to `RecalculateBestHeader`.

A separate source of non-determinism is because `m_cached_finished_ibd` is not reset (if set) at the end of the run.

🤔 BrandonOdiwuor reviewed a pull request: "cmake: Move internal binaries from bin/ to libexec/"
(https://github.com/bitcoin/bitcoin/pull/31679#pullrequestreview-3006391049)
Tested ACK f49840dd902cd9b14b6aadb431b16a4aeb719c3f

Tested on macOS 15.5 that `bitcoin-node` and `test_bitcoin` have been correctly moved from `bin/` to `libexec/`

<img width="635" height="311" alt="Screenshot 2025-07-10 at 18 56 31" src="https://github.com/user-attachments/assets/7f0e6ae5-f06f-488f-b913-1494bd20c05a" />

📝 glozow opened a pull request: "TxOrphanage revamp cleanups"
(https://github.com/bitcoin/bitcoin/pull/32941)
Followup to #31829:
- Release notes
- Have the orphanage auto-trim itself whenever necessary (and test changes) https://github.com/bitcoin/bitcoin/pull/31829#discussion_r2169508690
- Reduce duplicate reconsiderations by keeping track of which txns are already reconsiderable so we only mark it for reconsideration for 1 peer at a time
- Rename `OrphanTxBase` to `OrphanInfo`
- Get rid of `Size()` method by replacing all calls with `CountUniqueOrphans`

💬 glozow commented on pull request "p2p: improve TxOrphanage denial of service bounds":
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r2198155263)
I added this to a followup PR: #32941

I think the tests added here are easier to reason about when `LimitOrphans` is an explicit call, so it feels better to do it in a separate step.

💬 glozow commented on pull request "p2p: improve TxOrphanage denial of service bounds":
(https://github.com/bitcoin/bitcoin/pull/31829#issuecomment-3058077194)
I've created a followup PR with some of the cleanups and optimizations: #32941

💬 sipa commented on pull request "p2p: improve TxOrphanage denial of service bounds":
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r2198159044)
This `std::floor` has no effect. `m_tx->vin.size() / 10` is an integer division, not floating point, and it already rounds towards 0.

💬 maflcko commented on pull request "fuzz: Add fuzz target for block index tree and related validation events":
(https://github.com/bitcoin/bitcoin/pull/31533#issuecomment-3058096115)
> A separate source of non-determinism is because `m_cached_finished_ibd` is not reset (if set) at the end of the run.

This could be fixed by calling `ResetIbd()`, if there is need to.

🤔 maflcko reviewed a pull request: "qa: Fix `wallet_multiwallet.py`"
(https://github.com/bitcoin/bitcoin/pull/31410#pullrequestreview-3006435253)
the rebase looks correct. (ci obviously still fails, as expected)

re-ACK 605593547aa196204b1e5b8f7857abacd36906b2 🏣

<details><summary>Show signature</summary>

Signature:

```
untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}"
RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A3Yux4bpwZ
...