💬 Sjors commented on pull request "wallet: `addhdkey` RPC to add just keys to wallets via new `unused(KEY)` descriptor":
(https://github.com/bitcoin/bitcoin/pull/29136#issuecomment-3031449845)
> Another thing I noticed is that createwalletdescriptor is not smart enough to just use the only available unused(KEY) descriptor.

I opened a followup PR for this #32861.

💬 rkrux commented on pull request "wallet: remove dead code in legacy wallet migration":
(https://github.com/bitcoin/bitcoin/pull/32758#issuecomment-3031518930)
Rebased over master to incorporate changes from #31423.

✅ fanquake closed an issue: "test: functional test failures under `--usecli`"
(https://github.com/bitcoin/bitcoin/issues/32264)

🚀 fanquake merged a pull request: "test: allow all functional tests to be run or skipped with --usecli"
(https://github.com/bitcoin/bitcoin/pull/32290)

👋 fanquake's pull request is ready for review: "[29.x] More backports"
(https://github.com/bitcoin/bitcoin/pull/32810)

🚀 fanquake merged a pull request: "cmake: Improve Python robustness and test usability"
(https://github.com/bitcoin/bitcoin/pull/31233)

💬 fanquake commented on pull request "depends: Override host compilers for FreeBSD and OpenBSD":
(https://github.com/bitcoin/bitcoin/pull/32716#issuecomment-3031623366)
> This also is related: https://codeberg.org/guix/guix/issues/556.

Reading the discussion there, it seems like the behaviour is intentional.

💬 fanquake commented on pull request "depends: Override host compilers for FreeBSD and OpenBSD":
(https://github.com/bitcoin/bitcoin/pull/32716#issuecomment-3031631149)
There are more improvements we could make here, but we can take, and backport, the (simpler) current change as-is. Anything more will at least require some Guix changes.

✅ fanquake closed an issue: "depends: OpenBSD (aarch64) needs gcc (instruction) for libevent"
(https://github.com/bitcoin/bitcoin/issues/32691)

🚀 fanquake merged a pull request: "depends: Override host compilers for FreeBSD and OpenBSD"
(https://github.com/bitcoin/bitcoin/pull/32716)

💬 Sjors commented on pull request "Add bitcoin-{node,gui} to release binaries for IPC":
(https://github.com/bitcoin/bitcoin/pull/31802#issuecomment-3031698536)
Rebased after trivial conflict with #32290 (it touches `ci/test/00_setup_env_i686_multiprocess.sh` which this PR renames).

💬 maflcko commented on pull request "cmake: Improve Python robustness and test usability":
(https://github.com/bitcoin/bitcoin/pull/31233#discussion_r2182425599)
i guess unrelated to the changes here, but i still don't think this is the correct fix. it seems odd to special-case a single python test and silently disable it when cmake fails to detect python (in the ci or otherwise). This is brittle, inconsistent and just adds maintenance overhead.

the correct fix would be to just remove the cmake stuff here and move this test to the python test runner, so that it is run like all other python unit/util/functional tests.

💬 fanquake commented on pull request "cmake: Improve Python robustness and test usability":
(https://github.com/bitcoin/bitcoin/pull/31233#discussion_r2182429044)
Yes I agree.

💬 hebasto commented on pull request "cmake: Improve Python robustness and test usability":
(https://github.com/bitcoin/bitcoin/pull/31233#discussion_r2182438636)
> ... and silently disable it...

`ctest` reports about disabled tests.

💬 fanquake commented on pull request "[29.x] More backports":
(https://github.com/bitcoin/bitcoin/pull/32810#issuecomment-3031762726)
@josibake / @hebasto want to re-review?

💬 fanquake commented on pull request "doc: Add workaround for vcpkg issue with paths with embedded spaces":
(https://github.com/bitcoin/bitcoin/pull/32858#issuecomment-3031763856)
cc @sipsorcery

💬 maflcko commented on pull request "cmake: Improve Python robustness and test usability":
(https://github.com/bitcoin/bitcoin/pull/31233#discussion_r2182461343)
> > ... and silently disable it...
>
> `ctest` reports about disabled tests.

I know. The warning is unchanged by this pull request. However, this doesn't help in the context of CI, see https://github.com/bitcoin/bitcoin/issues/31476

👍 hebasto approved a pull request: "[29.x] More backports"
(https://github.com/bitcoin/bitcoin/pull/32810#pullrequestreview-2982682093)
ACK ef2a013e31cf6fbded5735a998b4c992c176493d.

Missed credits to @darosior and @ryanofsky?

👍 willcl-ark approved a pull request: "[29.x] More backports"
(https://github.com/bitcoin/bitcoin/pull/32810#pullrequestreview-2982692779)
ACK ef2a013e31cf6fbded5735a998b4c992c176493d

...modulo hebasto's comments.

Backports all look correct.

💬 sipsorcery commented on pull request "doc: Add workaround for vcpkg issue with paths with embedded spaces":
(https://github.com/bitcoin/bitcoin/pull/32858#issuecomment-3031819388)
ACK 0a1af4418ed2a135001cc0e10f0af44cbd64e521.

💬 fanquake commented on pull request "[29.x] More backports":
(https://github.com/bitcoin/bitcoin/pull/32810#issuecomment-3031821752)
There's going to be another branch, so any credits can be fixed up there.