💬 l0rinc commented on pull request "miniscript refactor: Remove unique_ptr-indirection (#30866 follow-up)":
(https://github.com/bitcoin/bitcoin/pull/31713#discussion_r2165989320)
nit: I'm repeating myself a bit, but not sure why some getters have prefixes

💬 l0rinc commented on pull request "miniscript refactor: Remove unique_ptr-indirection (#30866 follow-up)":
(https://github.com/bitcoin/bitcoin/pull/31713#discussion_r2165978531)
Nice, I like the new one a lot more (moving the whole subs vector instead of one-by-one)!
One small nit: I think I'd prefer the flattening metaphor rather than the stripping one

💬 l0rinc commented on pull request "miniscript refactor: Remove unique_ptr-indirection (#30866 follow-up)":
(https://github.com/bitcoin/bitcoin/pull/31713#discussion_r2165991247)
do we need to return vectors here? Seems overly specific, I think spans should also suffice here

💬 maflcko commented on pull request "ipc: Handle unclean shutdowns better":
(https://github.com/bitcoin/bitcoin/pull/32345#issuecomment-3003863654)
the CI failure is real, can manifest itself via segfault, timeout, abort, assertion failure, ...

💬 Sjors commented on pull request "ipc: Handle unclean shutdowns better":
(https://github.com/bitcoin/bitcoin/pull/32345#issuecomment-3003879879)
I've been seeing segfaults etc too in https://github.com/Sjors/bitcoin/pull/90. I'm running it again now with the most recent versions of this and https://github.com/bitcoin-core/libmultiprocess/pull/184.

💬 maflcko commented on pull request "docs: add guidance on initialism capitalisation in PascalCase identifiers.":
(https://github.com/bitcoin/bitcoin/pull/32720#issuecomment-3003915877)
Seems fine. No strong opinion, but at least the two lines of docs shouldn't add several typos, see https://github.com/bitcoin/bitcoin/pull/32720#issuecomment-2960249863

💬 Sjors commented on issue "IPC via TCP Sockets":
(https://github.com/bitcoin/bitcoin/issues/32802#issuecomment-3003950873)
Good point about the lack of authentication.

One use case I have in mind is (something like) a BitAxe that connects directly to your node to fetch templates to solo mine on. Currently this involves running a Stratum (v1) solo mining pool, which just adds useless complexity.

That said, as soon as you have more than one device you're going to need pool software to divide the work between them. At that point it makes more sense to run a sidecar application on the same machine as the node, and hav
...

⚠️ alexandre-leng opened an issue: "Improve Bitcoin Transaction Speed for Retail Payments (In-Store Usage)"
(https://github.com/bitcoin/bitcoin/issues/32808)
### Please describe the feature you'd like to see added.

Hello,

I would like to suggest a feature or improvement that could significantly contribute to the adoption of Bitcoin as a common payment method, especially in physical stores.

Currently, transaction confirmation times can be too slow for real-time, in-person payments. This delay is a major obstacle to using Bitcoin as a day-to-day currency for retail purchases.

Proposal:
Explore protocol-level optimizations or layer 1 improvements th
...

⚠️ alexandre-leng opened an issue: "Reduce Bitcoin Network Energy Consumption for Environmental Sustainability"
(https://github.com/bitcoin/bitcoin/issues/32809)
### Please describe the feature you'd like to see added.

Hello,

I would like to open a feature request or initiate a discussion around the possibility of reducing the overall energy consumption of the Bitcoin network.

While Bitcoin has proven its resilience and decentralization through proof-of-work (PoW), the current energy requirements to secure the network are significant. This has raised growing concerns regarding its environmental impact, especially in the context of global efforts to re
...

✅ willcl-ark closed an issue: "Reduce Bitcoin Network Energy Consumption for Environmental Sustainability"
(https://github.com/bitcoin/bitcoin/issues/32809)

💬 willcl-ark commented on issue "Reduce Bitcoin Network Energy Consumption for Environmental Sustainability":
(https://github.com/bitcoin/bitcoin/issues/32809#issuecomment-3003967808)
General bitcoin questions and/or support requests are best directed to the [Bitcoin StackExchange](https://bitcoin.stackexchange.com/) or the `#bitcoin` IRC channel on the [Libera Chat](https://libera.chat/) network.

For proposed protocol changes you can post to the [bitcoindev mailing list](https://groups.google.com/g/bitcoindev) or the [Delving Bitcoin](https://delvingbitcoin.org/) Discorse forum.

For general bitcoin discussion you can try [bitcointalk](https://bitcointalk.org) or [https://r
...

💬 alexandre-leng commented on issue "Reduce Bitcoin Network Energy Consumption for Environmental Sustainability":
(https://github.com/bitcoin/bitcoin/issues/32809#issuecomment-3003972246)
That would be good because it is an argument that in my opinion hinders the mass adoption of bitcoin as a global currency.

✅ willcl-ark closed an issue: "Improve Bitcoin Transaction Speed for Retail Payments (In-Store Usage)"
(https://github.com/bitcoin/bitcoin/issues/32808)

💬 willcl-ark commented on issue "Improve Bitcoin Transaction Speed for Retail Payments (In-Store Usage)":
(https://github.com/bitcoin/bitcoin/issues/32808#issuecomment-3003972963)
General bitcoin questions and/or support requests are best directed to the [Bitcoin StackExchange](https://bitcoin.stackexchange.com/) or the `#bitcoin` IRC channel on the [Libera Chat](https://libera.chat/) network.

For proposed protocol changes you can post to the [bitcoindev mailing list](https://groups.google.com/g/bitcoindev) or the [Delving Bitcoin](https://delvingbitcoin.org/) Discorse forum.

For general bitcoin discussion you can try [bitcointalk](https://bitcointalk.org) or [https://r
...

💬 maflcko commented on pull request "depends: Override host compilers for FreeBSD and OpenBSD":
(https://github.com/bitcoin/bitcoin/pull/32716#issuecomment-3004016362)
> but I couldn't figure out how to do this override globally

shouldn't this just be `CC=... CXX=...`, like in CI (https://github.com/bitcoin/bitcoin/blob/ad654a4807cd584be9ffcd8640f628ab40cb5170/ci/test/00_setup_env_native_nowallet_libbitcoinkernel.sh#L13), or is this issue `MULTIPROCESS=1 capnp` specific?

💬 maflcko commented on pull request "Refactor: Redefine CTransaction equality to include witness data":
(https://github.com/bitcoin/bitcoin/pull/32723#issuecomment-3004059285)
lgtm. Also, seems fine to remove it and add a `Equals(const CTransaction& other, const EqualsOptions = {})`, where

```cpp
struct EqualsOptions{
bool include_script_sig{true};
bool include_witness_data{true};
};
```

review ACK 6efbd1e1dcdfbe9eae2d5c22abab3ee616a75ff2 🦋

<details><summary>Show signature</summary>

Signature:

```
untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugD
...

💬 willcl-ark commented on pull request "depends: Override host compilers for FreeBSD and OpenBSD":
(https://github.com/bitcoin/bitcoin/pull/32716#issuecomment-3004082028)
> > but I couldn't figure out how to do this override globally
>
> shouldn't this just be `CC=... CXX=...`, like in CI (
>
> https://github.com/bitcoin/bitcoin/blob/ad654a4807cd584be9ffcd8640f628ab40cb5170/ci/test/00_setup_env_native_nowallet_libbitcoinkernel.sh#L13
> ), or is this issue `MULTIPROCESS=1 capnp` specific?

Seems to be `MULTIPROCESS=1`-specific. e.g.:

```bash
docker run -it nixos/nix

# Start a shell in container with no `gcc`/`g++` present
nix-shell --pure -E 'with
...

👍 willcl-ark approved a pull request: "[29.x] More backports"
(https://github.com/bitcoin/bitcoin/pull/32589#pullrequestreview-2957497706)
ACK 0922f6bbc33ac2abe3f3d9dc98dade896718864f

Checked all backports are clean and match their parent commits. All backports which include a `Github-Pull: #xxxxx` line in the commit message are mentioned in `release-notes.md`.

🚀 fanquake merged a pull request: "[29.x] More backports"
(https://github.com/bitcoin/bitcoin/pull/32589)

💬 willcl-ark commented on pull request "test: disable secp256 tests by default":
(https://github.com/bitcoin/bitcoin/pull/32782#issuecomment-3004247908)
I think if there is concern about configurations then I agree it would make more sense to drop the iterations to 4 or 8 as suggested by @hebasto and @real-or-random

💬 vasild commented on pull request "depends: Override host compilers for FreeBSD and OpenBSD":
(https://github.com/bitcoin/bitcoin/pull/32716#issuecomment-3004262238)
> shouldn't this just be `CC=... CXX=...`

Yes, I think it should be. But is not because currently `depends/hosts/default.mk` contains:

```make
default_host_CC = $(host_toolchain)gcc
default_host_CXX = $(host_toolchain)g++
```

`gcc` and `g++` are hardcoded there. The following would make it possible to override the C and C++ compiler from the environment:

```diff
-default_host_CC = $(host_toolchain)gcc
-default_host_CXX = $(host_toolchain)g++
+default_host_CC = $(host_toolchain)
...